From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8367DEB64DC for ; Tue, 11 Jul 2023 10:10:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E10D6B0075; Tue, 11 Jul 2023 06:10:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 191996B0078; Tue, 11 Jul 2023 06:10:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00CA16B007B; Tue, 11 Jul 2023 06:10:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E66226B0075 for ; Tue, 11 Jul 2023 06:10:49 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9B28D1A01AC for ; Tue, 11 Jul 2023 10:10:49 +0000 (UTC) X-FDA: 80998912218.27.4B46007 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 7C20CC0009 for ; Tue, 11 Jul 2023 10:10:47 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689070247; a=rsa-sha256; cv=none; b=RtLhtF68GF/Qtu6NDkN8eXtbKX7Iccc1Fw1GiYvSb2l78OEeWtLlTmyhEhKouo58JjKbWi VbZXLj4Yrd5s7uZZgvwXUwvqkP6G1Xou1SJcfvx08+kREA0YN+p1iN3ZVyCn6xlTf/SOG8 aEqU8/teShidGsh/DTdCtrGbs+W4DYo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689070247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NklhkwlNR5eEmz7lf9gHixIXUDPU7r/AgZFQC+NZaNg=; b=ya2UTFKkqIJeNYR5nBFDIEdWrB42lSYTulhrY/6wEevAmTR93rmmfRU3T0ySHHdFEwgS2U MEcMJo5pvTEML9k4al7utlt0o/VQyVFhxDGJj4bBUtlBBTOxL8LMfkT83RZgrS8JJiKenG q4Ysql4zqSxRwD5nGzbdQACH5DTb/5I= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5728df0a7d9so68666227b3.1 for ; Tue, 11 Jul 2023 03:10:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689070246; x=1691662246; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NklhkwlNR5eEmz7lf9gHixIXUDPU7r/AgZFQC+NZaNg=; b=auKey3V5FvP1xXPmxcA4bDGTFjA4RKPtNgWBY6XPN04N3n+0sOFpno1HQVkViyadB/ IfD1+9Pe8vQ7k9rEpgKeaqG4m1bPN5MYOi7iYJd7yJ19KiqpxsCISsL0/gwtj28HHXPy 8oQaXa0wdN9nGD+JaLbSRzC7KK6vdgI8xj47Ah1mq+5HsyxRfdUb3CqvnBwj0EE05QQA ObSSn+hNPsobfBavmxyp5Hif42LZRBa7St8IhH9gEyRyRTgua+Se2hK4OuhmUz+SWAKv nB2D3YwNpi6WMUky9SRqHlFyXUQ1WpKpHpD73TqgfDriXWJPIOYzE2cHpv0kfy/vYoED bxNQ== X-Gm-Message-State: ABy/qLaIA3n93Al/fbMgypLV1V0PM7NViTJwDrWiJJXurzRayovo/fPx Yzl2T3WXPT2UlOPvRryUvC9DsVQHFygAxw== X-Google-Smtp-Source: APBJJlHROM/cLSAH3LOepEt/2+JNz+Hhq4SVLSNxEnl1cMezgVEjzglk0y8qcYk/QXzASOVvlhHUow== X-Received: by 2002:a81:84d1:0:b0:576:9e6a:67f9 with SMTP id u200-20020a8184d1000000b005769e6a67f9mr13987152ywf.48.1689070246249; Tue, 11 Jul 2023 03:10:46 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id h126-20020a0df784000000b00559f1cb8444sm477002ywf.70.2023.07.11.03.10.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 03:10:46 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-57012b2973eso68478667b3.2 for ; Tue, 11 Jul 2023 03:10:46 -0700 (PDT) X-Received: by 2002:a81:4f4a:0:b0:57a:5c79:482a with SMTP id d71-20020a814f4a000000b0057a5c79482amr10682578ywb.50.1689070245876; Tue, 11 Jul 2023 03:10:45 -0700 (PDT) MIME-Version: 1.0 References: <20230711035444.526-1-zhangpeng.00@bytedance.com> In-Reply-To: <20230711035444.526-1-zhangpeng.00@bytedance.com> From: Geert Uytterhoeven Date: Tue, 11 Jul 2023 12:10:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] Improve the validation for maple tree and some cleanup To: Peng Zhang Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7C20CC0009 X-Stat-Signature: wu8dqacme1dknfep34apbkf1hucg3mxw X-Rspam-User: X-HE-Tag: 1689070247-755130 X-HE-Meta: U2FsdGVkX1+cRdaGvN1gMUHAE41ohcn4G4SEKiEmiLpubVN2n1J64azj+aEJepIdZby3HVk1UQBjFvxCJzKjCGN8beq3na45rVLptErRcb098UgA0/THIJQrz4X6zKUPsIglBW2WKthQUMUFG/CEuTpuIPfd6tKh8hJC+Bcx7+tA1uCa+ASdNsbx77rCkaMhJkK1/diZ/z2toGXV4HQElhhBneFMPA1YkmUk/LX7K/eVmb5jpfZIKnAOA7GHOsizjZamblGkajwGNCe7Xj260yMbdtQCKot7/oxuUy5gGH/A0cNOABvz4kFb/FAsrb6K2RsU4Y2UlYiWXbgyyuH2cviwKut7tvz15CRBcJX8OZGgfl09GiqrzGWhHJEnBHZtYlCryhQpKfnVt/f8s/Al7BaVpWtYVcDgtWU7bnVXiUqjVPCvq4/+5l5l7M9I8o31Z9i4xPQwU9q5h1dd1JYIu+jYMdrYHu7GQ1nJev+QkiLSC9jCMNPDAfzqYcwF1IQFXnsYitYy6JkL6VgFE3dsAHg3OzDpwmc+pf4pO4f0lhF/Wh309RMZQReoPOoNTYyCpuCHYPZyzKBEJv0yrHhUgoxsMw6XS2uwRu4Qz0t+gYLLm5siAyz2pdwugiuom6CNGwB5vkAmwk3lUZqXT9NBmzd5kYyW+M+KG3iJjpxPwRhi1e1EfWb/It9CjcduV+aqZUYhS2fVKv45U6Isk0Khy+xpxTDxNKb5yO5stCd1RZ6Xy9Qagwq4CRlDyfxS+I4sij1MsbNBta4pgHaiucCxpuGBwvarPnh+f6KQh9WudezMuprNs3d6dO+AMcViIKcLoPPWdBBuQbybpDdTnbq1wWXG0PB00oJajhp0xPG4eZgbiBKqsoV3WzOEPbJyMLPmQvBRWRHZH+LoHE9ECP+vkilmmQf6LbuP7yoCh8gX2klMgQBYQG6k2YlhKjPQQdEo0yPCebcMZO7MeKf8USV 5hnABzc8 K+X+ESNmgyjKYukl3Pg7omtXFJHR3cwkgD490s2GnF4Uz9ERfj3AJSvQSF3DCEsKGh1AClTms8O5joszKIyArzyrF5vKjSK3Z0Z9ZXQToVMrKavqWdwualuIeTgRlGMmwy4G6XlhAbsIwVX8dY+k9FTFrqDv6ce2Z8XsXzU1Zr09A5fEpbvB+g6YLICvC+tEXh52a8E72pXsTT0ZhZH4HwphPZJ5TRSDW+OwyK1qMI/Oc/1ECfN/QT2Wv49NHSI0psy0Huvls302CgvO+qCOemv01X/wiNFLHOw1JvtbKkiBwNbsxJT3+TMPWTT7WCCp2rdDK0dhQB1x9Jy02qQz2qxDbxLErHQkXu+IHvFyVjpqxtqLL5m6mSoZ8T3Hp2BFG/0uAvkjQfZaeHPEFft48WPajfstY26YPo4zXzbQ2+2OlG5JwUpagRt5MXLPiKueMCUBcDsbPxqnWwVSaAlgAoZfATqpfUrAjPgbuTWkbuFq4sM638vZpp0wMjtMkD/SuV/zC46yrXKTU3JDLfGKAkWw02h9+xvnjnorx4mduFlgeR8ef3sEWuxLml/HYUaM7hO9RQAkdDnge4rk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peng, On Tue, Jul 11, 2023 at 5:56=E2=80=AFAM Peng Zhang wrote: > These patches do the following: > 001 - 002: Small cleanup to maple tree. > 003 - 006: Improve the validation for maple tree. > 007 - 008: Drop some functions that will no longer be used. > > Thanks Liam for the review. > > Changes since v1: > - Add fixes tag and the necessary Cc. [1/8] > - Add the verification that gaps beyond the node limit are zero. [3/8] > - Revise comment. [5/8] > - Reformat the code. [6/8] > > Peng Zhang (8): > maple_tree: set the node limit when creating a new root node > maple_tree: don't use MAPLE_ARANGE64_META_MAX to indicate no gap > maple_tree: make mas_validate_gaps() to check metadata > maple_tree: fix mas_validate_child_slot() to check last missed slot > maple_tree: make mas_validate_limits() check root node and node limit > maple_tree: update mt_validate() > maple_tree: replace mas_logical_pivot() with mas_safe_pivot() > maple_tree: drop mas_first_entry() > > include/linux/maple_tree.h | 2 - > lib/maple_tree.c | 258 ++++++++++++------------------------- > 2 files changed, 79 insertions(+), 181 deletions(-) Thanks for your series! I gave it a try with test_maple_tree on m68k/ARAnyM, and the net impact is: TEST STARTING BUG at next_prev_test:2014 (1) Pass: 3749128 Run:3749129 -BUG at check_empty_area_window:2655 (1) -Pass: 3754275 Run:3754277 -BUG at check_empty_area_window:2656 (1) -Pass: 3754275 Run:3754278 -BUG at check_empty_area_window:2657 (1) -Pass: 3754275 Run:3754279 -BUG at check_empty_area_window:2661 (1) -Pass: 3754275 Run:3754280 -BUG at check_empty_area_window:2662 (1) -Pass: 3754275 Run:3754281 -maple_tree: 3804518 of 3804524 tests passed +maple_tree: 3804523 of 3804524 tests passed So only one bug left to squash ;-) Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds