From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16158C433EF for ; Mon, 14 Feb 2022 09:48:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B1286B0072; Mon, 14 Feb 2022 04:48:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 460DF6B0073; Mon, 14 Feb 2022 04:48:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34F416B0078; Mon, 14 Feb 2022 04:48:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 29E4A6B0072 for ; Mon, 14 Feb 2022 04:48:19 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CF99D8249980 for ; Mon, 14 Feb 2022 09:48:18 +0000 (UTC) X-FDA: 79140909876.24.64632D1 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 585AB180002 for ; Mon, 14 Feb 2022 09:48:18 +0000 (UTC) Received: by mail-vs1-f54.google.com with SMTP id g10so18109402vss.1 for ; Mon, 14 Feb 2022 01:48:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sVctF2TLthiqqvEqHlD1AtmIxo0t7StGx/mG39a8KA8=; b=xsT57KV0zhkDiRghY3BTyTknFDh6vrhaAJXInGU6UzjYIcEMltDNXxc5I7XAr5niy0 ASHelLNpJH4eZdMANOvMb5FBym1Tg/C+lJpM1hhQ/MCcvh3qCS6uh1snQethxk5O7Co4 mcl5m6qjnKWTqmn47O+QAU8lGomBSdwPQtflvpCeTi6TzmYEmvuS3iYUgU+OzYz3ae4r ACdKDWbsiYVQM2cPSqvcs0+83HXGNSOdTbtZopJqecyt4cd6tRQ4erF1XtC6F62P7MS7 0ZJjfGgsCfmzhk7cCYdzHam1Vkgev7EcxZIwPEHdc/XDPoM+YiQRIpj5PrAJ8/AOVgjw 1brA== X-Gm-Message-State: AOAM533UyHhbWEl7MT38aXV5aSEZTvE3sMBBuafF2SFP3UYQHY0fuR9S JnTc87waYS0LPiPsOW0SF8fwlENXnji/bw== X-Google-Smtp-Source: ABdhPJw9hqm6MNBSoI/U9TiSnOrGzxI7AV7Y+e0sc66rSla3slrF5il3u9pYbr/VzOGIZGXIguzaBQ== X-Received: by 2002:a67:f28b:: with SMTP id m11mr3617280vsk.84.1644832097529; Mon, 14 Feb 2022 01:48:17 -0800 (PST) Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com. [209.85.217.50]) by smtp.gmail.com with ESMTPSA id o2sm1716933vkb.44.2022.02.14.01.48.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 01:48:17 -0800 (PST) Received: by mail-vs1-f50.google.com with SMTP id e6so6146233vsa.8 for ; Mon, 14 Feb 2022 01:48:17 -0800 (PST) X-Received: by 2002:a05:6102:440d:: with SMTP id df13mr981415vsb.5.1644832097058; Mon, 14 Feb 2022 01:48:17 -0800 (PST) MIME-Version: 1.0 References: <1644805853-21338-1-git-send-email-anshuman.khandual@arm.com> <1644805853-21338-31-git-send-email-anshuman.khandual@arm.com> In-Reply-To: <1644805853-21338-31-git-send-email-anshuman.khandual@arm.com> From: Geert Uytterhoeven Date: Mon, 14 Feb 2022 10:48:06 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 30/30] mm/mmap: Drop ARCH_HAS_VM_GET_PAGE_PROT To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Andrew Morton , linux-arch@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 585AB180002 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none X-Stat-Signature: ab3op7chhfyt7qhbn5whimqokkekhpsd X-Rspamd-Server: rspam03 X-HE-Tag: 1644832098-970374 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, On Mon, Feb 14, 2022 at 7:54 AM Anshuman Khandual wrote: > All platforms now define their own vm_get_page_prot() and also there is no > generic version left to fallback on. Hence drop ARCH_HAS_GET_PAGE_PROT. > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Thanks for your patch! > - select ARCH_HAS_VM_GET_PAGE_PROT So before, all architectures selected ARCH_HAS_VM_GET_PAGE_PROT... > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -81,7 +81,6 @@ static void unmap_region(struct mm_struct *mm, > struct vm_area_struct *vma, struct vm_area_struct *prev, > unsigned long start, unsigned long end); > > -#ifndef CONFIG_ARCH_HAS_VM_GET_PAGE_PROT ... hence the block below was not included. > /* description of effects of mapping type and prot in current implementation. > * this is due to the limited x86 page protection hardware. The expected > * behavior is in parens: > @@ -102,8 +101,6 @@ static void unmap_region(struct mm_struct *mm, > * w: (no) no > * x: (yes) yes > */ > -#endif /* CONFIG_ARCH_HAS_VM_GET_PAGE_PROT */ > - So shouldn't the whole block be removed instead? Do I need more coffee?? > static pgprot_t vm_pgprot_modify(pgprot_t oldprot, unsigned long vm_flags) > { > return pgprot_modify(oldprot, vm_get_page_prot(vm_flags)); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds