From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50235C369B2 for ; Thu, 17 Apr 2025 07:35:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893746B0194; Thu, 17 Apr 2025 03:35:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8194D6B0196; Thu, 17 Apr 2025 03:35:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BD126B0197; Thu, 17 Apr 2025 03:35:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 484136B0194 for ; Thu, 17 Apr 2025 03:35:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4A4901214EF for ; Thu, 17 Apr 2025 07:35:52 +0000 (UTC) X-FDA: 83342726544.05.3C6A02C Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by imf04.hostedemail.com (Postfix) with ESMTP id 405A54000D for ; Thu, 17 Apr 2025 07:35:50 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.42 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744875350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlhwLdMuc1vfzHiUTHhLvXWzDjUA9i2BfrRB+g9HjA0=; b=zDmwMIVPI2uQwIKJi6f8HDJOn+zzAo86aGEcVWkIiSXrI5aVHuHmOoSg7yahNFhsyM0UVu dOCo7rsgTMssi24OK9oXFFUc6Wet2PlgGg8MpAkbeki4KfHY4EpaTXn0RyrxVPKuZEPSoR k85H3K68emdXHzuGIAuWZWOlbo/yCwY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.42 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744875350; a=rsa-sha256; cv=none; b=WzcxDIL0C8ars7sL1Ok+Uy/FZFiJo5Db63RIxUI5uKuNoWcseqVQO32/l0oYZBeT2AprUT X6zU+FPIVIHbtbFazVxuRb3c5ZqGnqsA5DZxQk0iqr9mW5J+qRpFE0FOALiMd5Qqkg+Uuu hBIvyLKWmmDEdl5DOt4jRNx9b4SxURY= Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-86929964ed3so439596241.0 for ; Thu, 17 Apr 2025 00:35:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744875348; x=1745480148; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JlhwLdMuc1vfzHiUTHhLvXWzDjUA9i2BfrRB+g9HjA0=; b=BOGapl35ua91wZ7IpO7nxx8jmaAuAtNUS5vIr4eJhG6tJ7l4SiPQTC7E3uS2CYsl68 GyIlJ8Vg1SFlp59MQTK7A3P9RCDvLmElJYjaee3cyizbO8FyQTOlMUxtxFcLZcWKuODY 7HhISSL/2zyqJ5xsBKJrb2Cvo+EESCI0eeX7LFdXUZFk/Np8x+IafDVG0rfOobvFM8OK sTD9kAe5SweD9Hb9r1DBKpQOEeXNLCRQmGx87eb3qE3cCisPDELPF7pnrXs1NWDAjqg8 iED5hcjrH8lOiwRKu60I6C3w9PtenJCXbaWGATbEU76fBCtKHT1LoBMy4B9BSZx7vbAt D7KQ== X-Forwarded-Encrypted: i=1; AJvYcCWiZxsa/l/f4iBmZjsq8wVfuI8juoxxzDMfEEcYPt/DmfY5RXXnM4FmSsi4x6coEFNuDI9OepmOEg==@kvack.org X-Gm-Message-State: AOJu0YxU39/DdMuX4W72lx3zOIWV7yOeI9AQWDMCarAl12e5hGvxenQy 1sXU1bpebp2uWyR4BwjsQk6dzq1CoAMZj3LEydauc0tag6XjGph+gf/mjooj X-Gm-Gg: ASbGncs9eOJ5WGwsI0YzKIfYKv7ZZ7t22O0yuTH6yrDFhK6V6dZ638yNz9Si7vBQ8f8 z2+Sdb/U9hpBD7xupObFeCOuagXnJQ+81zrKakS5DCNA+c1aJ38qQCjVvRSx1hkDar9CESFDLT8 0uwdUm3IRHPZvoj/pZrRGYL2OZRdYa+XNN/FY347l3nrntEUlkz9F5og8q/6QBf+Dfl0MMMaZMZ dzRYHujIi3MzD8cd8Y1QV95+nFSrFUBAZk6X5ZLycEFX6bot1DZ2DhrlXfecJfMYEQG2aDdU0Ze UYWeyGWrALPlX7M3HYccgXEPntQl0DZWIz0QY64PVIZMkCoCO//H2x0wE499v03L1spfx0YkJ/o kKfI= X-Google-Smtp-Source: AGHT+IEqd90BOQb4INw1yg7PpJ3UOm1K0fWf30TaJ0q54PIJHlDwnK4MOaQMC24E3VvqyxpnZhOpqA== X-Received: by 2002:a05:6102:53ce:b0:4bb:9b46:3f92 with SMTP id ada2fe7eead31-4cb591b797emr2927010137.1.1744875348385; Thu, 17 Apr 2025 00:35:48 -0700 (PDT) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com. [209.85.222.51]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4c9c97a2247sm3494563137.14.2025.04.17.00.35.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 00:35:48 -0700 (PDT) Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-86ba07fe7a4so466028241.2 for ; Thu, 17 Apr 2025 00:35:48 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV9860Zbol6JmGqw1t4o1FBPH3C9RjbDKiXbe1NOGHFWrWqdMQbkxlZBdZMr6efD8WLL4YAQeVdXg==@kvack.org X-Received: by 2002:a05:6102:5616:b0:4c1:83c4:8562 with SMTP id ada2fe7eead31-4cb5920c8acmr2955742137.13.1744875348000; Thu, 17 Apr 2025 00:35:48 -0700 (PDT) MIME-Version: 1.0 References: <20250408164000.3215690-1-fvdl@google.com> In-Reply-To: <20250408164000.3215690-1-fvdl@google.com> From: Geert Uytterhoeven Date: Thu, 17 Apr 2025 09:35:35 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: ATxdqUFMS-Y0egsHu_C7T9_O_yPfXL89DbZv7eKbzblmZwQLKEdJhnZx9vS86b8 Message-ID: Subject: Re: [PATCH v2] mm/cma: report base address of single range correctly To: Frank van der Linden Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 405A54000D X-Stat-Signature: zii6u16pmdud964ozznhzamghmt37c1o X-HE-Tag: 1744875350-362813 X-HE-Meta: U2FsdGVkX18jiQZXUXF/MuIkm+0ItiZUyP/kV7gw35S2a8YrOprmx8Nrb2vRpx5e7SRnZ6EXHLYi8hheXaoxWKsW2DjKwtoVnQbCpsJnRqx4N42NngdCLXlqBGfnD4iqIiJrpWr15ZcqgNouC2CwDLb5OtuJyo/yGli35UXkeav4AjEpSwH/PjpeQkcqGpO4BCwzCBhzT4iz+xWA1q3Q2rhspZ/iXrz6mQHUhGdnZTBsOZMoV8BiMJslXz+U03bsVdR19h6ZxgnfRl68aL0Kzofza1PZfkMXm9iLLIoMZ7IrFqcCCBuY9E15WL0yNDH1D74+O9dZTVcDdTcmpNAX+0Lzq14+wGXkvWK1xCyrPsrwdkt2aHOgrktqgSVz+TtYfLccIdvftF6YAO5nn4ORfIUwcHStpfBW6WRq5+S14tg4zbndlFsQAS2xqRq8ynEoCfhaGOZ1NJeJEBroG90z0WTKisgvChpFlH8dwRX1YxdZleNb7lNF/+V0SNuJ+eDXKvELDheLRVjMts8WmsI2PGdmqo/AlegCDVjNgywH6xtUMw2wMtTtUYvDoeqI6+EuYZRCzbGnZvXqlTlqqRf97vW23MYupHx4A0HY6jU+Ek1feYJNZP5st5q8ij5B4oItth9DJmyyMRJ5QiM2QSmx9TG21Pq8vn5zUL3gMIr1cdGux8YMBXJwEt822vU9n6a+9ahig+FJ5pTB/8G+OXIpWUdan33FDkB9L3J1M21nL3i8A+1VLAYWUzMQoTehiWANIYkILCjy1b3eCe/W9B9U22kcQM0rvErc6iW1IfgZUDGuDrjLr4JKg8CZGsUAwij6CCxTtg1XCdvb7dXBU6lyj0Wu68GczeG9+jJTcJpVGDXBBMMmWsDAmg+Y2gw6HEWhrdqVBcc8zDqk72Z9oMAB6INJNWTqu2LB9tFU4f8vZswJgXZTKJNkOqzN1ounrgcWv9N72+UFg10JNhnnnNT 0MKavbx5 lHPPrm3r3R9UIiS8GhLofuxBLIKHa0Hd/I0EvfpkxmlMrSeYrLwz/Uq8MsWiv71KisdqeMMqhsLYqD87OjnDxO8ui8EjcoOcvD6qr76MbHa0a7rurm2UpdUAKHTfO49b5GJoVVYdSrKwNeqAUgiG3ULcBatDhRfzVhZQO2jp/vC8wYCBFezirYSoNzd5IKg8K7JK7Puiz7AA6k4mIX9gro9eoRawqYIPueVfsoCJ56qHbfN8VPPs8xmN6fEFh3uQzmpFOXqiOGAuGBpm+tYv+DJ0kBFFRZqWHXdAy3UmDIv0rr4BDPhQt9yT1Dk2Wql/hgqMnDAKNh2MxpQgjC0PlsZUkVku2ajQFnsm7xOp0OngP1G8BhcS5VpSQ+8tAwpveDyjjR38WqNnfXoByJa+AHg5jf9ClqeXhliTKBrNkPJBe4X7Y4a0aKDP/5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000035, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Frank, On Tue, 8 Apr 2025 at 18:40, Frank van der Linden wrote: > The cma_declare_contiguous_nid code was refactored by > commit c009da4258f9 ("mm, cma: support multiple contiguous > ranges, if requested"), so that it could use an internal > function to attempt a single range area first, and then > try a multi-range one. > > However, that meant that the actual base address used for > the !fixed case (base == 0) wasn't available one level up > to be printed in the informational message, and it would > always end up printing a base address of 0 in the boot > message. > > Make the internal function take a phys_addr_t pointer to > the base address, so that the value is available to the > caller. > > Fixes: c009da4258f9 ("mm, cma: support multiple contiguous ranges, if requested") > Reported-by: Geert Uytterhoeven > Closes: https://lore.kernel.org/linux-mm/CAMuHMdVWviQ7O9yBFE3f=ev0eVb1CnsQvR6SKtEROBbM6z7g3w@mail.gmail.com/ Thanks for your patch, which is now commit 60580e0bd587b1df ("mm/cma: report base address of single range correctly") upstream. > Tested-by: Geert Uytterhoeven FTR, the email addres in this tag does not match the tag given in https://lore.kernel.org/all/CAMuHMdUeGjbOx-aJTvwOVBWdUFmY7wU-p3mKaCbEzQ4PbJDqNg@mail.gmail.com > Signed-off-by: Frank van der Linden Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds