From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6F2C4725D for ; Fri, 19 Jan 2024 19:08:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14416B0071; Fri, 19 Jan 2024 14:08:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C54B6B0072; Fri, 19 Jan 2024 14:08:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88C006B0078; Fri, 19 Jan 2024 14:08:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 782786B0071 for ; Fri, 19 Jan 2024 14:08:35 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 04FCC1C185A for ; Fri, 19 Jan 2024 19:08:34 +0000 (UTC) X-FDA: 81696996990.30.D367437 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf26.hostedemail.com (Postfix) with ESMTP id 3D387140002 for ; Fri, 19 Jan 2024 19:08:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705691312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Los1bUQR+nrchlfUsUNrM4jlMLqPsXp3+vKyRRoEhFE=; b=3WWgkW4NX8IG3ufsqdvQFGxvlP4AE3RfW1tDIESiXRJBzHq6p3n4dMI2blk6f9zmXfm0vv AhojXhAjlePNjWVqAu0RctuDdDtQozr62h+9aV9Bflcb6Wuz+5pXmufEBhn4xa5DJgOG5U 3A20TdnZMu84dUDmFhmONmBKEKDsiKo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705691312; a=rsa-sha256; cv=none; b=hCQlZ2T5ssCczu8CXPd2NWElJFf1dujaSrNEd9ZhOBHlUCWgSYLccXvDaEsQBd6A2wNS0w giaDTYlAdTsz1IY1UcjpfpHaI3F8Ieb/FETpdV8hwOeLex6WIiwRAfUTMxzJAjtMDG/mlR zXg2crIzhhfXznVK9eXxH5S1v6JfyXw= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-dc236729a2bso1066987276.0 for ; Fri, 19 Jan 2024 11:08:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705691311; x=1706296111; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Los1bUQR+nrchlfUsUNrM4jlMLqPsXp3+vKyRRoEhFE=; b=I8oGgniYKQIMqr4oeH4MiNLZoUwHnVbupfgxVl2tRbRcdny1wXFNuhjWuSNfqLoKLp nYHukar7zOBGg8Aoc7wlrqvt4lVuFted50Yt+5l5t49h991Z+9lz4KhLwYRp+JmtaPtf RzYcloZ7iKA2wGe8zEl5+rOZg4+ryUsT4jB8TG7+WKF3r3vMYz61djPDEN072ysoIRY9 u8zdOFYwZh1ySQn6ENlshWZcmOSb11IKQl81qz8YjyDI1ae1baA24ieMoXb8iQRuvMeA 5376TIxNO8CJL1/cLKhrB1rtKb+rTRNluKsFoY51DgI1ojfKu6EOPP3FgKxOULxC96/i VnIQ== X-Gm-Message-State: AOJu0YxF+pIBHlgD4KXTlq0bOyfZQ6lBO+szi+TYH9VKEBk0NfIEfLvx 1YL/Y+YI7apjALjMwN/MIi7CObtKMDiyYnRaDlAWNYVAtPdpSR+fBGbzh4YJQe4= X-Google-Smtp-Source: AGHT+IHV6ca41+xjBm3xLNoxH9juW1KfdeR6aeABVQluYxSVOMV7XJAZMjzF9rq1GDLSFObB5O0drA== X-Received: by 2002:a25:8b85:0:b0:dbd:a56e:891c with SMTP id j5-20020a258b85000000b00dbda56e891cmr322999ybl.2.1705691311153; Fri, 19 Jan 2024 11:08:31 -0800 (PST) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id a5-20020a259385000000b00dc25d5f4c75sm986669ybm.10.2024.01.19.11.08.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jan 2024 11:08:30 -0800 (PST) Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dc261316b0dso967010276.3 for ; Fri, 19 Jan 2024 11:08:30 -0800 (PST) X-Received: by 2002:a05:6902:1611:b0:dbe:a537:58cd with SMTP id bw17-20020a056902161100b00dbea53758cdmr355239ybb.52.1705691310589; Fri, 19 Jan 2024 11:08:30 -0800 (PST) MIME-Version: 1.0 References: <20240111192329.449189-1-urezki@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 19 Jan 2024 20:08:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() To: Uladzislau Rezki Cc: Christoph Hellwig , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot , linux-m68k Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3D387140002 X-Stat-Signature: yib9qwrnsbfhyakmriyjo81ammyhma9s X-HE-Tag: 1705691312-294633 X-HE-Meta: U2FsdGVkX1+Y03OGSNLh3OjJdFsl8lLtUH75xupSHXgivABDblwr5WJveNiJ1vjdUbi0W7yY0h8VK6gzmkZw4m7+fJzFS3E2dOjK30gnzKdzDkTs2poILmxgapDBOngau3h/1CeBT/4VQlVzrMtBb4Aaiid+ixqa2eqCg86d7AlPgjBeRgftfLh5SxTCuwc0huj0uJn+/l9u1liCQqMaIfHM7003O6Y8KPGlxCztEkW+JBoPpwYovcYak+boga0R10tkGiOX57Y7mMZCjSJWWJ70EzK9IKUHM6hbBuR6dtP0gguOFH7aJZ1Ck8x6ZeCsgOufXpvXELAu3OO0J5cEbDs4rnH8MflyNlDs8xW011c48bLtb75eVLtRZPvrVjjm2YoWfHssEyY9EARTmeKzyvs4TN2+hjGO6AtMN2RgUGUaqa19QJDwZv7DZ2Ox2tBA6fH3MTehbrOxSmuwDfKa4Y4fBFjCJeUItyTUdo9xiZyxdvtkr4D8TRUAjXEHt2UDNXW/5SVFZEW+Fw2uiwmISpyaQXEjcffmK8MdZVy+LOp6txwreuI1E1vmUlwI2//HDdMBnnBoZrC52UiNGfrNZVHYvAwZtTwGgSmbWhMc0LY//0M+YUfRkvz9mt/yWHq37AjRXV9wJPLrK7PmI2O/8wrKM+tFv+aa9CRgF0EHVQ1AGLElgPS1dRv0w/EwxurYXRafxXiaQrIzK2HxKyMuDeiC6Sq+QqR1tC/4wtOfNrUTxvX2xOEzW8WCfnmjT1DARUVbuEDWSmgQT23kLMGw6BdqcmMf4aU1YlVVi6GiLviQgIolqHy0mU7COXzYvSZBzyo0P9q9tfdt4AwjRyB7qKuXnjLNmZoWZkqaGnLqPSSSz13dSh8ECD0mKnxH9S+sAk/a71UwmRXbLKsjawRatbo1IKhefBKvYBTdek34XAldVoaqNE+BJnRXnEEmPoVlkbJVGJ/HqgPqvXSPedW sx5YqJoL JLkj/psC+4lYtMh1RPVs7mLdaanM3048rnN41SavoeH1JtEz+z7l5hI6/erF32eMWRRU2Gs3xbz7VOIECj3EJlFU/8Xy2wy21UneqxAVpmDPmpSQ69xql4bNadlbzGyRdX4ylrsggItvsi3YqQJvBJ9FvsDF4193RaNBowFSbitafImyQumNTfrjILzl0jc8crKIt4lTTNUVmh/g8DYfpzLzfczUNPlh/CNtx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: CC linux-m68k On Fri, Jan 12, 2024 at 9:11=E2=80=AFAM Uladzislau Rezki = wrote: > > On Thu, Jan 11, 2024 at 08:23:29PM +0100, Uladzislau Rezki (Sony) wrote= : > > > #endif > > > VMCOREINFO_SYMBOL(_stext); > > > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=3D0x%lx\n", VMALLOC_= START); > > > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=3D0x%lx\n", (unsigne= d long) VMALLOC_START); > > > > Well, the right fix is of course to make sure VMALLOC_START has a > > consistent type, else we need to plaster this crud all over. > > unsigned long seems like the right type for it, so at least m68k should > > be fixed to confirm to that by adding a UL postfix to the definition. > > > I agree with you. I wanted to focus on fixing that particular place > because i wanted to avoid other(on this step), possible side effects > or drawbacks if i went with patching the arch/m68k/* files. > > But, in general arch/m68k/* has to be fixed. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds