From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E390CC433EF for ; Mon, 25 Apr 2022 07:07:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E6998D0008; Mon, 25 Apr 2022 03:07:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 194CE8D0006; Mon, 25 Apr 2022 03:07:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 040B98D0008; Mon, 25 Apr 2022 03:07:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E9E4D8D0006 for ; Mon, 25 Apr 2022 03:07:27 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B6455281C6 for ; Mon, 25 Apr 2022 07:07:27 +0000 (UTC) X-FDA: 79394520534.08.348EFAC Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 93B22C0015 for ; Mon, 25 Apr 2022 07:07:26 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id a186so10137041qkc.10 for ; Mon, 25 Apr 2022 00:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i0fy0ju/RjV4t6J/6vekfJMKMcci/Xy9FO1WhPYjEWY=; b=fjz451256ryzQoeV8bLDISfEq+cxJUH/mW49h0xQrUY9USa2G+4ruhmpZqhWq252JG QmwVpXKYGcZ1hLMLIedA7TAzrZSJP6+huai6IlThr7iap+j3GRFK4uybVNgAajcAidXo hGuETjYCKpoAQXUiGQi5kHMAIIyjc1Rj/e68/LwkYjmR3Z154Ya7td/d8x17OB2xKnV3 pVZ9GpXyuCT8XjuNAuP2v5KXBiFwKscil5EOi/CpPwdpAFn0Fg4uITvBZGh1sd0tRvhv 36yTYUb5/lBZHkP+0F4p7fbOo0JF/z0X/JKjimKc8lbZlCdbxYRhV6OaZf198zmwRt4n n4vw== X-Gm-Message-State: AOAM530Vk5xbLBitQZItU9M8Rfxp+p9ZD/e4fyyuoQGlJT4HjHftEeJ7 uOnVU/aReSJHUN1XOT9z17MNEkd22L2L6w== X-Google-Smtp-Source: ABdhPJxyb63JWNfrz+hVOHzY5NN5/ILktmxdsCCGer/Nzq2rEebyR9uwnikgSf6EbzRGHzbFVrfalw== X-Received: by 2002:a37:a247:0:b0:69d:5e7d:42b7 with SMTP id l68-20020a37a247000000b0069d5e7d42b7mr9228371qke.320.1650870446172; Mon, 25 Apr 2022 00:07:26 -0700 (PDT) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id t17-20020a05620a035100b0069ea7219390sm4474812qkm.55.2022.04.25.00.07.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 00:07:25 -0700 (PDT) Received: by mail-yb1-f173.google.com with SMTP id u33so990962ybd.11 for ; Mon, 25 Apr 2022 00:07:24 -0700 (PDT) X-Received: by 2002:a25:d393:0:b0:648:4871:3b91 with SMTP id e141-20020a25d393000000b0064848713b91mr5823322ybf.506.1650870444696; Mon, 25 Apr 2022 00:07:24 -0700 (PDT) MIME-Version: 1.0 References: <20220415164413.2727220-1-song@kernel.org> <20220415164413.2727220-3-song@kernel.org> <5e5e4759efef83250f9511d4ab0e1ba34f987ce5.camel@fb.com> In-Reply-To: <5e5e4759efef83250f9511d4ab0e1ba34f987ce5.camel@fb.com> From: Geert Uytterhoeven Date: Mon, 25 Apr 2022 09:07:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 bpf 2/4] page_alloc: use vmalloc_huge for large system hash To: "song@kernel.org" Cc: "linux-mm@kvack.org" , Rik van Riel , "linux-kernel@vger.kernel.org" , "bpf@vger.kernel.org" , "rick.p.edgecombe@intel.com" , "hch@lst.de" , "akpm@linux-foundation.org" , "daniel@iogearbox.net" , "hch@infradead.org" , "mcgrof@kernel.org" , "ast@kernel.org" , Kernel Team , "imbrenda@linux.ibm.com" , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 93B22C0015 Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none X-Rspam-User: X-Stat-Signature: sssui9nkh4sz3fnuuognmsxufxbb18hp X-HE-Tag: 1650870446-489163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Song, On Fri, 2022-04-15 at 09:44 -0700, Song Liu wrote: > > Use vmalloc_huge() in alloc_large_system_hash() so that large system > > hash > > (>= PMD_SIZE) could benefit from huge pages. Note that vmalloc_huge > > only > > allocates huge pages for systems with HAVE_ARCH_HUGE_VMALLOC. > > > > Reviewed-by: Christoph Hellwig > > Signed-off-by: Song Liu > > Reviewed-by: Rik van Riel Thanks for your patch, which is now commit f2edd118d02dd114 ("page_alloc: use vmalloc_huge for large system hash") upstream (and which hasn't been in linux-next before). As reported by noreply@ellerman.id.au, this is breaking e.g. m68k/m5272c3_defconfig with: page_alloc.c:(.init.text+0x13de): undefined reference to `vmalloc_huge' vmalloc_huge() is provided by mm/vmalloc.c, which is not compiled if CONFIG_MMU=n. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds