From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3102EC02193 for ; Thu, 30 Jan 2025 08:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D7A92800CC; Thu, 30 Jan 2025 03:21:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 960422800CB; Thu, 30 Jan 2025 03:21:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D9842800CC; Thu, 30 Jan 2025 03:21:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5BFB72800CB for ; Thu, 30 Jan 2025 03:21:31 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C7D40A0B41 for ; Thu, 30 Jan 2025 08:21:30 +0000 (UTC) X-FDA: 83063423940.27.D91E360 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by imf23.hostedemail.com (Postfix) with ESMTP id C2858140009 for ; Thu, 30 Jan 2025 08:21:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738225288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GaD/E6PXTaDQ2QuYo/3qqTDpp2nzD7hhPFRo29uLk0A=; b=0D0QxTR9M3viB1k2RyIxDrT1U+lAhRGrErn2ckAHCBpD40Mj2JBNYDIxCdPFo0bQo53TNW hLFlHEfxLx5dq+34l2ZQyCqBmp30+Fq7hTUithZdAyjo5GdWoAJi3pTDXlI5+5gnPwN3Sm WKpRPlr9CZauNK4CaVfTcB7DAHrq9QU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738225288; a=rsa-sha256; cv=none; b=S7ZbvUO9dTi0o9ONHMJ2c0l6/ORvao3tz6BvKP2N6UKfCmrxbo52Wi0jvDLste9F9Iyjly O2pyEM3YLWMrsDrCfV/bWVWDjdRPyY998cTSNRysTjJaZtoLFh9iig95L779NYpnb2F7lO WDBhJUV4Ne0DjaXTfmjxmFHlyA5MLnM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-518ae5060d4so168253e0c.0 for ; Thu, 30 Jan 2025 00:21:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738225285; x=1738830085; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GaD/E6PXTaDQ2QuYo/3qqTDpp2nzD7hhPFRo29uLk0A=; b=lnJ1HJhU/ybRjVMNofuK499YZ2U9+CWUfpxhrpDST9HmBA3zcAXgm0rUFOQ9OOD0rh +SQVQs5MDTz1sCKurRsrn0m1CLC1pkO0NOOojXp7CCa8LAn9hG45PiNhXOkgrCcgnnoZ NuEuSefPHYfLfNNZi7VT/qe/aYXcRGONzhoF0sldunRMqRZqnpGfq2zJKPlpR75OQeWv krIDnhILqEGA8TFjA4KD6kYOdo7dA7xUfjf3UBQTOss2ob8OonS9VNIsyqI6eH2VgpZW JcJ9I2SMWexNFXGxe5Lgt4+nwVB/thig/Mfbwgl20b4AKg9mFqi+HyzT+1QH1x9SfkND oEUw== X-Forwarded-Encrypted: i=1; AJvYcCWpL4/syhsbFkWDhPttlX4JJxMlJxc31WJbGYqaEQ+abEuzLlFspc7hxbfYCH7ii0gArybWwhNOKQ==@kvack.org X-Gm-Message-State: AOJu0YzI0EFOrDo+UGM9EbQX8ruRaTPTY1nl8B2hWEbZRvf+OobnFjRQ UR5aohmjK5NKBcW+WJgJnSLjKmHpDwQQvZN2f73VlUa82ru7QH3d9zUETod2 X-Gm-Gg: ASbGncuyYXPPZrMWAlWGllhvslFfMeb5fxJ4gYOTndPCx81uteWuTivhcbgjiQsCwL6 DoMjag/5beRjDSxcqskEhElLCfCZn9tQTHpTdWrTGYLPeuXdxNiynzrjX0xj2cUa/CvpXj0pGQz qIqNontRAoJ1TL/swr5IuOpNdUsLlPgUwZl8qe6BRoWg+ui0JEN5NX5m4uDAauyMCE1l6C41cKh X/pFRukzyogZ8caYm+HTC8hMJbPI6ZE/G2CB/U8Mv1lkj+ToIFVF2w0y+dggcAoQs0RUAwvNev8 VCzybHYx0qgsufHgPa0bUNOlv8bmMI6HVihdf2ANOL/34hgg3aXHJsTlcQ== X-Google-Smtp-Source: AGHT+IHkRNedLZlo2x/BYhDeMVih41yXHAMsHl61uS4XNgRDcNtu3DtgOp6VIeT4MCuJkL5jqn3a2w== X-Received: by 2002:a05:6122:8c2:b0:518:965c:34a with SMTP id 71dfb90a1353d-51e9e3d2831mr5991012e0c.2.1738225285530; Thu, 30 Jan 2025 00:21:25 -0800 (PST) Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com. [209.85.221.174]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51eb1d91b6bsm139892e0c.45.2025.01.30.00.21.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 00:21:24 -0800 (PST) Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-51c7b5f3b8bso157721e0c.2 for ; Thu, 30 Jan 2025 00:21:24 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXUYqNxmvsPpKZyFTz/Umt4ODYTMTzvRMuhDejsriasuI0Rf61ltCWDrryp56MSlyhDOH0W+2LJMQ==@kvack.org X-Received: by 2002:a05:6102:a52:b0:4b2:7996:6ba4 with SMTP id ada2fe7eead31-4b9a5266e7amr5391829137.25.1738225284361; Thu, 30 Jan 2025 00:21:24 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 30 Jan 2025 09:21:12 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZniYx50uUBB4BKLzCpQ-mS0oONl2y__yoxAs6c6zYEzharbM-CAzfEZmbQ Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: "Liam R. Howlett" Cc: Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, Matthew Wilcox , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: jjgczf5gf8bz7chcesn5xkpu5qxunuzn X-Rspamd-Queue-Id: C2858140009 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738225288-109691 X-HE-Meta: U2FsdGVkX18r3R8vHSgBYeI9/sT+mIZpPuqz0yZxkmbMiyyET1wUkfGwAjGQT3jWHULHLOLVawnEHkCP7TGHSfs7Z7wDDL8RUw2PzDLmuVDBpd06R7Fvxaqf8uVYMrFuBPLPeqyyidGz6lSsNRgAdUGXfSvcVM1mwAYEnKyzTKdKX9JSDAq/xnbrFTSm1ooBrw+wtkUwt7vshF25PDkJQJIoU2jeJnFjBmC2swQa5DVuspHQ1yZkL6Fet6iWtfYH5x3+RpxvZVyuU6xxudAZvWhVDR9Pc157gHngNQyt3nNA36d0XjlMYKyfHrkRRaKe1m+a6TqZxEgtkNksNk5LxxNaJu4y18Jm1h9uQb6O2YCq/Ci6vyJTLXuKY+XARFX8QqToIFiKm3IiaQcGWejmG1j6dXEzPDfDk70SStT6se9nxHBpiBTkNeg9v7G7lKOzJfx4uBMq8WWW7gwfjCkFp0VcrtQZpa6aLR1JzM3u+NU0zy7nlpJg5YA6gD1chSfBARKYHosn1h8szD/aOr7e+VJVJOZ2Kc0YQA3BcHc8HIfeIVBxFZlK0yhiQOguz6cuZQZBC234KmmfO9JQvjIxo948JOkJOk/igdFRPRjf8uaiVE10cKLsDpaGX6DnBLKXY3EU8AQKNR7+x92Z2uuxx1wqa2/vybQOWSRIlbbT+AaDU/Xr5yFSImx53VHF2eUUqTaty9W7dvgZXtrk1WA4J3FkfAVelKkRg8pGNLOEn1jTsOoZbVB9d9dUn0HrPCqlVcMdJxv1+wTjaeOQT6nknSAP6E/ajs8Bz3x58fKGDBM+W6l6nTVv0N+skMPoG1Rb39KbL1X20FM1sZPUhrGo+VKz0FDsPuHjpY4EOvZOVGUj70QXlSfsJOIuVu+EJ2WdJFwpwxoNKLsfxg3BGfiEpSXmRGysZDPfoFw6ceSEcmRwk6X2q9/kG1OgrZ+7MkVP2fLv6oEczagjL0vE3/R hc1iJOoQ GQ+ycT5vL/Xuyaf5VNw0/9bydYwdG5Wuxky4z9bqHpewzwbeTcJFKBJ4LTyfw+C0bLSuM9B/sB285i1e+11dCTfbtuWQuv23Fb+mlsiZirtF14sBse5C8dqspBQ8ly4B9f1NnI+DWmPnmpNsU9l85c+q0NZmodLFDzNIFQ8WzgNA/wDMfEQwj+s1aqLE1AB7MNgiSm99FIsas4xOs2Ao/jSD5hi3tBwgFX9+cL/+wcCX4LPfku53Tn5KTELsSdbndlsZRAIL5Ad73ddb4JHj/zqebQvb8lbzdh7UPY9SLg0p1kkFapkbiyjJzLW69xq9RoecYR4WuZku2F0Z3yyFGXf6+L8T5cJ96wH1vqQYthpKk2bwoJdCsBC8dUcFq/HS9YPz1UE8M7a9oBmHRPgpFHO7DEMy4zrPRDGj6dedyd8IVcNaDWzJnnX2fMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liam, On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett wrote: > I've never used the kunit testing of xarray and have used the userspace > testing instead, so I can't speak to the obscure invocation as both > commands seem insanely long and obscure to me. The long and obscure command line is a red herring: a simple "modprobe test_xarray" is all it takes... > You should look at the userspace testing (that this broke) as it has > been really useful in certain scenarios. BTW, how do I even build tools/testing/radix-tree? "make tools/help" doesn't show the radix-tree test. "make tools/all" doesn't seem to try to build it. Same for "make kselftest-all". When trying the above, and ignoring failures due to missing packages on my host: - there are several weird build errors, - this doesn't play well with O=, - lots of scary warnings when building for 32-bit, - ... At least the kunit tests build (and run[1] ;-) most of the time... [1] test_xarray started failing on m68k recently https://lore.kernel.org/all/CAMuHMdU_bfadUO=0OZ=AoQ9EAmQPA4wsLCBqohXR+QCeCKRn4A@mail.gmail.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds