linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	akpm@linux-foundation.org,  christophe.leroy@csgroup.eu,
	justinstitt@google.com,  linux-kernel@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,  linuxppc-dev@lists.ozlabs.org,
	llvm@lists.linux.dev, maddy@linux.ibm.com,  morbo@google.com,
	mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org,
	 ndesaulniers@google.com, npiggin@gmail.com,
	 Matthew Wilcox <willy@infradead.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] xarray: port tests to kunit
Date: Thu, 30 Jan 2025 09:21:12 +0100	[thread overview]
Message-ID: <CAMuHMdVcuhzO57Qn-kcUJDM=HmkSwuheyNJPF1tx+gxRKnKZXA@mail.gmail.com> (raw)
In-Reply-To: <xf3445vgszstqfwycf5wc5owhnifxb3mny5xjjaihghqgnozmd@3h7hnifir4vu>

Hi Liam,

On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett <Liam.Howlett@oracle.com> wrote:
> I've never used the kunit testing of xarray and have used the userspace
> testing instead, so I can't speak to the obscure invocation as both
> commands seem insanely long and obscure to me.

The long and obscure command line is a red herring: a simple
"modprobe test_xarray" is all it takes...

> You should look at the userspace testing (that this broke) as it has
> been really useful in certain scenarios.

BTW, how do I even build tools/testing/radix-tree?
"make tools/help" doesn't show the radix-tree test.
"make tools/all" doesn't seem to try to build it.
Same for "make kselftest-all".
When trying the above, and ignoring failures due to missing packages
on my host:
  - there are several weird build errors,
  - this doesn't play well with O=,
  - lots of scary warnings when building for 32-bit,
  - ...

At least the kunit tests build (and run[1] ;-) most of the time...

[1] test_xarray started failing on m68k recently
    https://lore.kernel.org/all/CAMuHMdU_bfadUO=0OZ=AoQ9EAmQPA4wsLCBqohXR+QCeCKRn4A@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


  parent reply	other threads:[~2025-01-30  8:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com>
     [not found] ` <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com>
2025-01-29 21:26   ` Liam R. Howlett
2025-01-29 21:28     ` Tamir Duberstein
2025-01-29 22:26       ` Liam R. Howlett
2025-01-29 22:33         ` Tamir Duberstein
2025-01-29 23:02           ` Matthew Wilcox
2025-01-29 23:08             ` Tamir Duberstein
2025-01-29 23:11               ` Matthew Wilcox
2025-01-29 23:17                 ` Tamir Duberstein
2025-01-30  8:21         ` Geert Uytterhoeven [this message]
2025-01-30 12:51           ` Liam R. Howlett
2025-01-30 13:25             ` Geert Uytterhoeven
2025-01-30 14:05               ` Liam R. Howlett
2025-01-30 14:24                 ` Geert Uytterhoeven
2025-01-30 15:16                   ` Liam R. Howlett
2025-01-31  7:39                     ` Geert Uytterhoeven
2025-01-30 14:09               ` Lorenzo Stoakes
2025-01-30 14:38                 ` Geert Uytterhoeven
2025-01-30 14:49                   ` Lorenzo Stoakes
2025-01-30 14:22           ` Matthew Wilcox
2025-01-31  0:22       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVcuhzO57Qn-kcUJDM=HmkSwuheyNJPF1tx+gxRKnKZXA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=llvm@lists.linux.dev \
    --cc=maddy@linux.ibm.com \
    --cc=morbo@google.com \
    --cc=mpe@ellerman.id.au \
    --cc=nathan@kernel.org \
    --cc=naveen@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=npiggin@gmail.com \
    --cc=sidhartha.kumar@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox