From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A69C6FD18 for ; Sun, 5 Mar 2023 16:49:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72DD16B0071; Sun, 5 Mar 2023 11:49:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DE2A6B0073; Sun, 5 Mar 2023 11:49:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CD316B0074; Sun, 5 Mar 2023 11:49:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4D4F66B0071 for ; Sun, 5 Mar 2023 11:49:08 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CE0A14079F for ; Sun, 5 Mar 2023 16:49:08 +0000 (UTC) X-FDA: 80535429576.23.B83A624 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 47ECF180015 for ; Sun, 5 Mar 2023 16:49:05 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678034945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=laWnaU7+yvIkdIWbPnbMvJLuXve3O1O7/VL48bFhhYw=; b=bsFqf3n45JFmG5XaqkKjXfLG0Z5MeLdFsqujfg+9TTWW9PdGeofCsz1Vta91ah0pi70Sir dp5RAud7zf/Rkk1/WZmB2Fece5td9W3ody153JSuVSPQXA/awCxvr3M88X3RB594Qwx259 Tm2Pi9mQCnn9SHnL77o+GVakv4UtVlE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678034945; a=rsa-sha256; cv=none; b=rhp44cDo0D0kprXD5rvd70UxiFtwiB6x9Da4LGF5EbVWm/pXpAF1uBrdS1VVRND/Xrb+If VIbTlsxaa9Diy5/XshEWFjxWWe1bx61Ug40kKrc6BY++t3k8bJBY1tuC2WaI9lkqHwbpMl fWZgrFtrDlKi3tfBhN2aIxyrdTLwCg0= Received: by mail-qt1-f173.google.com with SMTP id c3so8252473qtc.8 for ; Sun, 05 Mar 2023 08:49:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678034944; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=laWnaU7+yvIkdIWbPnbMvJLuXve3O1O7/VL48bFhhYw=; b=MPFqyNk5m1nYQEwMKCWc5o3JFOieMh3A3FREp8lZZbfDd5hrzqnsSXZMz6tmn5VjwW 5zohlLRVtU9GQ0y5aqTRcGaA/cwwkD4G1+cP6IHVDKhxvQW0HJb8KnO9+e57a5P9f3kB z8YdsayS0YW/nUBqv2eKOKxghH5vrFBAzzKszxDXbCCWZBL1HnrgMgzNa1j7BONYHnrv bno+uNBLFZOfoJQl2S+kp0vgS+ocTNB3Yp6FDBH9+u2SbsMqXZDVTrwIzaMVTmVdf6DI tJ0XLXnn+N/L88cIB2rOTNnnKkJkIZ56t+AAXv914ueQjHxp84ki1QIrPhdSIrOcuk0H r3tg== X-Gm-Message-State: AO0yUKXnZLitku630TvNiYGsVF5J8IKpCKs3in296z4DnmZWzFc3RsI/ cByViGHqrLsivh7xjxW5hLiXkd17aQ0G6A== X-Google-Smtp-Source: AK7set+dplp8l1X2IkdTedYumEbPzGwBKHr8LwtugcRIGtpnNOzLfaJhJV3AVsM9Yro7vHZsTkX/KA== X-Received: by 2002:a05:622a:1443:b0:3bf:c178:c6ea with SMTP id v3-20020a05622a144300b003bfc178c6eamr12731137qtx.56.1678034944134; Sun, 05 Mar 2023 08:49:04 -0800 (PST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com. [209.85.128.174]) by smtp.gmail.com with ESMTPSA id m19-20020a05622a055300b003b2957fb45bsm6015400qtx.8.2023.03.05.08.49.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 08:49:03 -0800 (PST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-536c02c9dfbso140976767b3.11 for ; Sun, 05 Mar 2023 08:49:03 -0800 (PST) X-Received: by 2002:a81:b61d:0:b0:52e:f66d:b70f with SMTP id u29-20020a81b61d000000b0052ef66db70fmr4814861ywh.5.1678034943362; Sun, 05 Mar 2023 08:49:03 -0800 (PST) MIME-Version: 1.0 References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-14-willy@infradead.org> In-Reply-To: From: Geert Uytterhoeven Date: Sun, 5 Mar 2023 17:48:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 13/34] m68k: Implement the new page table range API To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 47ECF180015 X-Stat-Signature: b7t79r8sdz3x3sgbphg91jgxhp7w1m14 X-HE-Tag: 1678034945-697849 X-HE-Meta: U2FsdGVkX1/JxHuAUdZWu0s9cD6fswhTWYEp7MDcJJf3cgjqFfA4pseNrP77BSxfXfOoC/23BjppybqvHT951PlcqkCj7lRHk2xSlNhm0gHL3Yggw0Y/VYuN3SYhoxRShPAxijfqf8Sm2SVzgww9D4fIRrftLtEE131RqMhqxcwjqVMkIGmqjxR/DJnvKmUr4cwML6GVAX434BHveAJ1NAkm87V1Abu6Crf7tJMMJl4KqaVhs1lQ6K5tvBkbZonnyBeMQuIY8PU8Gcs3E8s6vYyEwMcRRlm4rK/OVbLpdUHaUtRKM3zLuTo6efe05vgi47jHpfSM//3UYgrNglgmc0xjRz4UovwtUe2lPa1J5iLfOQ0kQCmgCPn5YL4H0Jse7jkNAv1uWZRLb1TknK9gU9jcigqxC48t7N1JRwPplqrDWiXVezoFsJH+qRwV6TOsOFcVpmFDJtTIHW41idQIreYwSrbE8sQJ0hCz5yfqVm9GQhrqVtMARACmAl+wetYZiL6C7Jc1em2BniLzlNayVOWx/giBoNNqeuNTuebXvkEnmX8ht88dmg2q4FLbTukG7imkGOmo7DJF1/zW/bU9GNDMdR+M7CAzr6AB2Kkl78+YBTBd+HErX/J4Jh7dun0/VhhrE3yobeOix2Niawmgnh2ZXTtnnkxXHcDbBZfypz6prHzpCeR2BLbvcibhjtS/1rp8LkbrPwdfLVfFXFr9xwMojE5D2LazcuDVNqAm7Ki7WvJI1UTXGcPR9AwWHbNnwx1SlcIq3+IxN0c62ySYezjpr6UvWi3X2MZihwVFnpUKOVR4KeryR7zz12q4me2FeTr9MwBQvrP8tBntvu1HCmRp4loxIBmiGyqICmXEL6HVCOQxjk1FTlDFIjpaa/ALvDNsK45CuG5sDeK65HbSFKaAGLoWb4paH1ij0teT7cIkwk3+3pBWtv8l7M5APNMm+yuQ5jFRXX11SkINzGp wtmNKZs6 ju1Mg0Rv7Xf7wARo2zOdd1/hV7aeCCTljNyDC5YvAfl0pPHopev3QsAeTUKJmzeLkL8uJm/chyIB0bnSt3M4OVGW6TiyKDrwAPVuXvXE7yJUsal8ZoL9wNyti8/TSu6vCi5f14LDvcC+vurGhsDaj95N1G2t4SS21UqikjxP9e4k8AKahZBJTFCuYMg+Yb+NukDdZD/9vvjHGn0KCyODTQy3at7OPVfCzgw/YHIMj+d7jP0fdzp4lRxhcN26QGdQEeGF8md8LSqsWSZOtlvbRTzZwuZhGMg+dMBHAZgo177dIVMQxeZGnCr27kmY6kK0BFkThC6oS7jV3xdCjThRaKiVX9MPH/6UIGgNdbxT6jZ9ZPFkaLWbnRLD425k/U0IlhkjxkL4Gep1ZlzU09Rz+Z5EfDitVOYf5hCQ7z8QZSLygzVzCcjWtbYcqIdvUJGJlzyo/g+e+vfv59LJJ1ro/4/fbOdPJItFbhskkNhLS6TbyJzAFxTY4uNquC3hWpJdOwr92AzDG+eSaz9VDRFeK64Gq/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Willy, On Sun, Mar 5, 2023 at 4:28=E2=80=AFPM Matthew Wilcox = wrote: > On Sun, Mar 05, 2023 at 11:16:13AM +0100, Geert Uytterhoeven wrote: > > > + while (nr--) { > > > + __asm__ __volatile__("nop\n\t" > > > + ".chip 68040\n\t" > > > + "cpushp %%bc,(%0)\n\t" > > > + ".chip 68k" > > > + : : "a" (paddr + nr * PA= GE_SIZE)); > > > > As gcc (9.5.0) keeps on calculating "paddr + nr * PAGE_SIZE" > > inside the loop (albeit using a shift instead of a multiplication), > > please use "paddr" here, followed by "paddr +=3D PAGE_SIZE;". > > Thanks. So this? > > +++ b/arch/m68k/include/asm/cacheflush_mm.h > @@ -235,13 +235,14 @@ static inline void __flush_pages_to_ram(void *vaddr= , unsigned int nr) > } else if (CPU_IS_040_OR_060) { > unsigned long paddr =3D __pa(vaddr); > > - while (nr--) { > + do { > __asm__ __volatile__("nop\n\t" > ".chip 68040\n\t" > "cpushp %%bc,(%0)\n\t" > ".chip 68k" > - : : "a" (paddr + nr * PAGE_S= IZE)); > - } > + : : "a" (paddr)); > + paddr +=3D PAGE_SIZE; > + } while (--nr); > } else { > unsigned long _tmp; > __asm__ __volatile__("movec %%cacr,%0\n\t" LGTM. Might be safer to keep the "while (nr--) {", just in case someone ever passes zero. > Also, I noticed that I broke sun3. It puts the PFN in bits 0-n instead > of 12-n. New patch coming soon. Thanks, hadn't noticed (there are no sun3-specific code changes in this series?) Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds