From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EF5C47082 for ; Mon, 7 Jun 2021 08:53:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5619560E08 for ; Mon, 7 Jun 2021 08:53:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5619560E08 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DABBD6B006C; Mon, 7 Jun 2021 04:53:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5C066B006E; Mon, 7 Jun 2021 04:53:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAF3C6B0070; Mon, 7 Jun 2021 04:53:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 860AB6B006C for ; Mon, 7 Jun 2021 04:53:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 19767181AEF00 for ; Mon, 7 Jun 2021 08:53:20 +0000 (UTC) X-FDA: 78226313760.27.E1580C6 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf03.hostedemail.com (Postfix) with ESMTP id 765CBC00CBF2 for ; Mon, 7 Jun 2021 08:53:17 +0000 (UTC) Received: by mail-ua1-f51.google.com with SMTP id g34so9255881uah.8 for ; Mon, 07 Jun 2021 01:53:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y7XwbZyFAy9rqQo5J7t8DRS+d/mueoOLl5p+cSQb+8Y=; b=envCjUGqojz7gHhJabEjMrmUzxf4GwBHKSUtg+Y920NffA9fMNqL/gjRBx/BOj4Fk0 3EAroIVdNWAFCj+15pA4fCW2SYXcySQlUb2K53RCSgVigi2JbSNJaAFEdP8/+3Oxtdti q61D+GNyqfOdNTHwQx2jPz2KYpZsjA+9HdoQQJ8c0fiaVq8AVnXcx0s5K1p1vYD9DwVU f6bP17BeETiGXjXGVFXQTS1OZ7ols5tjuu0HWz6P427FaJNIYdP+5/nTpQwkld4EJgvX /0WC0OY/FHnDBHNhvFer89UIbpdkqLAExZS/DZuK6J5ZoYMZbml+5zArmKYOF18D3meS DnCA== X-Gm-Message-State: AOAM532HGC4nl6AnVcPujZUo6kYICabb2mipTf5bQ0LDwR/xc5piKDaI gDotc18HCIqLMcdwi7HZv98DR6hJYNtjEwE03eo= X-Google-Smtp-Source: ABdhPJw70xfmNroh3KIu5QGmqKsYwQ+PKLyHQ50n7DeatYgE4iGl6TNz+FWGTOL2BBcrgRRRH99rMYwIPPT469OpB6M= X-Received: by 2002:ab0:63d9:: with SMTP id i25mr6682382uap.106.1623055999326; Mon, 07 Jun 2021 01:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20210604064916.26580-1-rppt@kernel.org> <20210604064916.26580-9-rppt@kernel.org> In-Reply-To: <20210604064916.26580-9-rppt@kernel.org> From: Geert Uytterhoeven Date: Mon, 7 Jun 2021 10:53:08 +0200 Message-ID: Subject: Re: [PATCH v2 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Ivan Kokshaysky , Jonathan Corbet , Matt Turner , Mike Rapoport , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, alpha , Linux-Arch , Linux ARM , "open list:DOCUMENTATION" , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Linux MM , linux-riscv , linux-s390 , Linux-sh list , arcml , "open list:TENSILICA XTENSA PORT (xtensa)" , linuxppc-dev , sparclinux Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of geertuytterhoeven@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=geertuytterhoeven@gmail.com X-Stat-Signature: 3cdkcxftgqqhzz9i94h66hzcq8w1kcua X-Rspamd-Queue-Id: 765CBC00CBF2 X-Rspamd-Server: rspam02 X-HE-Tag: 1623055997-933661 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Fri, Jun 4, 2021 at 8:50 AM Mike Rapoport wrote: > From: Mike Rapoport > > After removal of DISCINTIGMEM the NEED_MULTIPLE_NODES and NUMA > configuration options are equivalent. > > Drop CONFIG_NEED_MULTIPLE_NODES and use CONFIG_NUMA instead. > > Done with > > $ sed -i 's/CONFIG_NEED_MULTIPLE_NODES/CONFIG_NUMA/' \ > $(git grep -wl CONFIG_NEED_MULTIPLE_NODES) > $ sed -i 's/NEED_MULTIPLE_NODES/NUMA/' \ > $(git grep -wl NEED_MULTIPLE_NODES) > > with manual tweaks afterwards. > > Signed-off-by: Mike Rapoport Thanks for your patch! As you dropped the following hunk from v2 of PATCH 5/9, there's now one reference left of CONFIG_NEED_MULTIPLE_NODES (plus the discontigmem comment): -diff --git a/mm/memory.c b/mm/memory.c -index f3ffab9b9e39157b..fd0ebb63be3304f5 100644 ---- a/mm/memory.c -+++ b/mm/memory.c -@@ -90,8 +90,7 @@ - #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. - #endif - --#ifndef CONFIG_NEED_MULTIPLE_NODES --/* use the per-pgdat data instead for discontigmem - mbligh */ -+#ifdef CONFIG_FLATMEM - unsigned long max_mapnr; - EXPORT_SYMBOL(max_mapnr); - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds