From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066E9C7EE23 for ; Wed, 1 Mar 2023 08:06:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 456066B0071; Wed, 1 Mar 2023 03:06:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4052B6B0072; Wed, 1 Mar 2023 03:06:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CD816B0073; Wed, 1 Mar 2023 03:06:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E2D86B0071 for ; Wed, 1 Mar 2023 03:06:39 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E78691C6D5A for ; Wed, 1 Mar 2023 08:06:38 +0000 (UTC) X-FDA: 80519597676.14.6608180 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 21E1EC000B for ; Wed, 1 Mar 2023 08:06:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677657996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IxktB80SVUUGX5HN3L3vi17Q72ZYHj/nfVmA7YVgBaA=; b=psx6wi0MI2DJC/BBly4b3s2qK6hk7SWRWQ/B3J3TLBXlvXaPM+KjgeBXKAxVAJBoz4LbZ7 2uf4wUs2qjlks3uay4HOjFlMyGv2VC9xHPlgXIE9EjFge0Tk0Sw4FGqxHEQ/ib1VDkCtnl L0z6T3niUcsqxs6D+pFqxM92TlbuCdY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677657996; a=rsa-sha256; cv=none; b=7dfA57S73WgNdN+0X0zRPX1iejjYVexfUgusHvvn5ImMyUPYQws7qTrJJkODwxexdDYFQd dxG35rv2S9dX/QQJZTjmtn2+yA6Gf3RoDViu0EeajTn+zSgiqJzd9RD3S13feBKhHs9ah7 54TqfEkkCECIRmCitYTnfAp/PVC4EW0= Received: by mail-qv1-f48.google.com with SMTP id op8so8671798qvb.11 for ; Wed, 01 Mar 2023 00:06:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IxktB80SVUUGX5HN3L3vi17Q72ZYHj/nfVmA7YVgBaA=; b=dvWzvQPGstcFv7xuHhj6XUDJ72iRoJWwBRicYE+ZEGojd2E3sYo8wKrNxwUNtjD5R9 D6xgWnG/YeopTZCSOo1Y7o+6aLudpDm0/MSxTyWDhEPUMrIDeMauhsIHN34itcd6I2E3 HsKXMFh3K7AoxwUg57bqXWSCprhdfsXeP8PvhwzAT1Uk9Uc7bnwd0CUJo7J2ttoNyW9u eg90GsbUbx/8QDQp1BQqixruDdvB0nO2lBD4nV+IQVBJNqpsDIgil/bG4dCY7yCB3gfE VCao65usmjwhV4djAdXDvCryxS56XO06VjRlWLdx+LmTQZBjbrEISUrWlCDLjOCIcXir Tnmg== X-Gm-Message-State: AO0yUKVAYlN6WT96hPRfBzfObpPUhbOh9vbKkUeZL/vF3VwkRdOhJvQy JtzgX7R26A99yeGXnH4T545rW03Ke+vcKQ== X-Google-Smtp-Source: AK7set/UediH4MGf375Cf/F/Yjm20dnHDKVvmvDL0hqZnM/JUWJbB2ejN/YqmwN2c6oTVXHeTeBO+A== X-Received: by 2002:ad4:5d41:0:b0:56f:52ba:ccf1 with SMTP id jk1-20020ad45d41000000b0056f52baccf1mr10945112qvb.22.1677657995037; Wed, 01 Mar 2023 00:06:35 -0800 (PST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com. [209.85.128.172]) by smtp.gmail.com with ESMTPSA id n19-20020a05620a153300b0073df51b5127sm8309977qkk.43.2023.03.01.00.06.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Mar 2023 00:06:34 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-536c02c9dfbso343918357b3.11 for ; Wed, 01 Mar 2023 00:06:34 -0800 (PST) X-Received: by 2002:a81:ad45:0:b0:52e:cacb:d7c4 with SMTP id l5-20020a81ad45000000b0052ecacbd7c4mr3373237ywk.5.1677657994373; Wed, 01 Mar 2023 00:06:34 -0800 (PST) MIME-Version: 1.0 References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-23-willy@infradead.org> In-Reply-To: <20230228213738.272178-23-willy@infradead.org> From: Geert Uytterhoeven Date: Wed, 1 Mar 2023 09:06:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 22/34] superh: Implement the new page table range API To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , linux-sh@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 21E1EC000B X-Stat-Signature: dau8dqyxp9rfpwt95br9jhrjnzcadhir X-HE-Tag: 1677657995-289781 X-HE-Meta: U2FsdGVkX19lIpR//A9XxPpHqEfrguq0qfQxLr+P3NFeZFQ5irxioBdJmchNo7d1qqXr+1YnjBQyLGAJwGNSNPt6saeglnh8wJ5fVGZEEVdnHpbkz9lN7Dws3Ue/qmdZEuj3UVRwaZciBQNSxfHMDYyfsU2d88uk4KkVt8Z+lRQL95iqDvL0oOPzUPg+Oj2wchftASswWnYDFCs8Uf2N7730y1F8H5NYPe14WtvY3WG82gWuONNy4kZduIpQ8c4UWzaOYQ16CyZLOCsclVsGHq8UZ2l1lriMoDMosTNffYb0za2s7/lHk/9Cfb9RkTdO1sF5VYDM6gP6Ky747lwRfmt48pIAc4SvGx6Q5iHMlWIRRMZ3W2cFS8sAezzeq4lPWmjiPy5emDDgdN6T8/EszCHUsqG5NyPog8+t6OcVBhD6HWuOpIHKYDophioVYPwtAZce0BKmFE/0QCf8JMtEoRix7reseibIMXJfo5qqsmhVM7jZpaEesewVWbhiLd1HefvM94TyuwdzdR9fzKmVRj5/3VqezEq8lt1Fg+ENpRB16AnO9ogdWoDOTL3sKnwUVBxVkvq5EvexSqidIXt7h8SGsQyuj6E4HgNQQq/h7JFLEhvse6I7/K4puWVWMKjByrxG2UfncQhPFwQFdh5K1l85AVbROMTYmcWglAFJSjgxJQk0Bqx3XhPcmZDMVAY7qJKZozkQn8krK+pijbhamH5+TTO/B8MPvVc0jJKO4DbN/LUiFOOTF9bQtLOfTwFUc84pTFZog5bcmvG8CM9DdgSdu9BjEJg1oEwj9XcMIqhgEZfMeCXW4Lm/3dNgyfxcSMrJKbRZd5PKQkXPKseQXS5CjUfhimMY1E5lg5JQDJA6XU4ZFaVG6B27eeoxRvoVdsGr6JWHk4upYpUWYxJw8TuYJEGeGuu0udLaTbBbiaN//kvoMd80QuNU1OjUUwN/qoRKv8s7rsEHwKZZcBC cA5YsQ9w jCYRFvZbOsh0rELJqyNN6bQRxGxoUwO6NnAjiIJTS7Cy0MTCa8GhSsLtrVrjtYWuadBZLbKviknB5vsiY0+Ao+NjWpt1pbG2y9ovtUwZPEQL6Zk0dscc0996ap6xhF4qvtI0sY4GL/f5TnfPzdQP+DXaB9EShE7K92i1TfH5m/ThR6OuPNpPxip1dhQQaAJ13q/pbQFF5TQzQ42HAar+t4ofqery64ocNkHRVkwwQiz3OhMvcZcsrqgTNoZlYAaY8RQKMSHXvusqDO4DvUZk/2f03HtTPpNVInodaMRjXjWdoQOK2F09YD7aqS1FXdyneh+munOgV+yFoiwV8mwCAlXRlVfAAKM6EZNOLBCPgOzKePQC4BN/A36Gs363ygZa87kxGTVcGTAOcgl8AtRRKx3shHNXXyDP8uLxnab69ixZw4/5K7K9zGjstGSjL1F0MCpIntFG3kwUnZDTZ8PyyHW0vHI761mx4L6i05KQgsmxUuqM+2XsnQLM8YAVCGh3c2cUulNODpAot709HEThbNUecog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Willy, On Tue, Feb 28, 2023 at 10:39 PM Matthew Wilcox (Oracle) wrote: > Add set_ptes(), update_mmu_cache_range(), flush_dcache_folio() and > flush_icache_pages(). Change the PG_dcache_clean flag from being > per-page to per-folio. Flush the entire folio containing the pages in > flush_icache_pages() for ease of implementation. > > Signed-off-by: Matthew Wilcox (Oracle) Thanks for your patch! > --- a/arch/sh/mm/cache.c > +++ b/arch/sh/mm/cache.c > void __flush_anon_page(struct page *page, unsigned long vmaddr) > { > + struct folio *folio = page_folio(page); > unsigned long addr = (unsigned long) page_address(page); > > if (pages_do_alias(addr, vmaddr)) { > - if (boot_cpu_data.dcache.n_aliases && page_mapcount(page) && > - test_bit(PG_dcache_clean, &page->flags)) { > + if (boot_cpu_data.dcache.n_aliases && folio_mapped(folio) && > + test_bit(PG_dcache_clean, &folio->flags)) { > void *kaddr; > > kaddr = kmap_coherent(page, vmaddr); > /* XXX.. For now kunmap_coherent() does a purge */ > /* __flush_purge_region((void *)kaddr, PAGE_SIZE); */ > kunmap_coherent(kaddr); > - } else > - __flush_purge_region((void *)addr, PAGE_SIZE); > + } else Trailing whitespace. Please run scripts/checkpath.pl (on the full series). > + __flush_purge_region(folio_address(folio), > + folio_size(folio)); > } > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds