From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756E8C0218D for ; Fri, 31 Jan 2025 07:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE647280085; Fri, 31 Jan 2025 02:40:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7146280082; Fri, 31 Jan 2025 02:40:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EAA1280085; Fri, 31 Jan 2025 02:40:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6E68C280082 for ; Fri, 31 Jan 2025 02:40:10 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1499BA04FB for ; Fri, 31 Jan 2025 07:40:10 +0000 (UTC) X-FDA: 83066948580.20.C025AAD Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A8B3C0006 for ; Fri, 31 Jan 2025 07:40:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.65 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738309208; a=rsa-sha256; cv=none; b=AvPcYX2Hut9IpubHNBcNFl+IfZyLcPO00aabS6XT1KEQNR+UaqeDtLwrSvRsEmmilisjot c9cug4yKuUNaoA40woT+gDxPa0zlnDERA+Tp/UaZ/Tn4JQCwymza6yYs/9V7vaNr3aiHzS cvpAOAgn7wnIh4PKO100DJnA9v4F4Bk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.65 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738309208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8kQmZAAK+6ewvnmsf4szqYR99Nu9ojx8MPSG+efC0JQ=; b=i7TLyFE6Bmiwearb6Y7/heXm0akYu8sZLI+4oOi6+g6xBGtSOQEGGZAkHwj6C7uk9yB8hA TMIulDQrcmZmKBMXk5nxJLV8LVpNSGcPkYPfCqE4U1z9qg/3HUsqfT58W3cY+Fau7RXtGl cscbhFHbyQLB9yBVHaRGmH5HAlpRzRA= Received: by mail-ua1-f65.google.com with SMTP id a1e0cc1a2514c-8641c7574a5so494427241.1 for ; Thu, 30 Jan 2025 23:40:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738309206; x=1738914006; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8kQmZAAK+6ewvnmsf4szqYR99Nu9ojx8MPSG+efC0JQ=; b=HrPAIpEYPxtnkHbb4yL+26DmZgwMQh9gJqClC3s+ClrMKzXqMFk6Kiy++nVMKcYoCk 5ehk6DMTgJQerrOqZcFh8lFz1mb56qLFQrOtSL9Xalgpnu4zWXzzzK7Sl475Ov/OpZXC pDwUC0MG6FjBsVj6XFCF7H83c2YE7dfl1QwK0J3xBs2QMLsoda9zgJK4W+xUkPYPRAwR AWu5sTAT4sJUsCpvdXBcUjMTNP1NoTyvzjO/XRy/Yw7ebIra/7R8OpF53GUQDGSg3i2N 1SA+y0axMhYebDHERi7xqOAT9uz0wSm1Mv0Yk3ijaapSPwmvNv+GxTDEmw3hZfTgV0Jt sbkg== X-Forwarded-Encrypted: i=1; AJvYcCW5/zuCTEy9Z9Wq0rwwIL/vMy6pmdq6rXosdQr+HgvLXOF4SbnXSMAclWQ8LxbmL093ZREQNPOueg==@kvack.org X-Gm-Message-State: AOJu0YyjE6jgrCwHW9n3zgQHAyXFJd70HZTCkqHHxtKViVOCrQYZqyOI 3JPB1M75l9Exh0FiJY9DL6A60qKW4Tk0/A6+BO8DABTg3Bw6UMZ1Yzqv0Wc6qw7G/Q== X-Gm-Gg: ASbGncuhjfI8CIBEnugVKBDTa1DFtpKgA/k1X9ttrWdKTABhssVi06qTbjMZBNdZT1L 5vfrcori7t6/EedjGTNESJYPURyvbYbtRtPiZik/0kT4sbzgGBHWNZHp4bkwjHY4GtHS2Y5PpmO KnU1OJPUL+PRhzBdlqUBLZudlTXRriJPA3QK0I/sfLgf5r5xYpXC1vPKALS+a9I3uF79JqlZ+1p qMWG9HFG8Jwk0+QjcvwrZsDXhu1TJWTXTVy5FMcP1kuQmLVDQBkTnAx0TTx7FGOUbTXER+T1rHL wRwDlj0DmBfo0o0m+39eIw/AM13sqIaYaXkc13Lr1XqH1rTgHX5H4A== X-Google-Smtp-Source: AGHT+IFJLFqsqekOcxf61K41CZZcfr92iWXOBbNfIn8iGkyCOSRsml79+PT3RN9vWJ073I239rUufQ== X-Received: by 2002:a05:6122:d87:b0:518:81aa:899b with SMTP id 71dfb90a1353d-51e9e4e2f3cmr8999982e0c.6.1738309206230; Thu, 30 Jan 2025 23:40:06 -0800 (PST) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com. [209.85.222.47]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-86694051dd2sm548248241.7.2025.01.30.23.40.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 23:40:05 -0800 (PST) Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-8641c7574a5so494419241.1 for ; Thu, 30 Jan 2025 23:40:05 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVDeQLGRvvTQ72SmfOOuhzgf9bprRhCkSdOSc0OqvdWimPUX9IU5ICQTbPeZ3PDYpqxXaKIf9z6TA==@kvack.org X-Received: by 2002:a05:6122:d87:b0:518:81aa:899b with SMTP id 71dfb90a1353d-51e9e4e2f3cmr8999970e0c.6.1738309205451; Thu, 30 Jan 2025 23:40:05 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 31 Jan 2025 08:39:53 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZkH_w9tBM_pRW6Ohl7HsK0YqaRuQD-fO1ItmvH8HD9xdtZANpKrFhiastY Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: "Liam R. Howlett" , Geert Uytterhoeven , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, Matthew Wilcox , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 0A8B3C0006 X-Rspamd-Server: rspam10 X-Stat-Signature: iii6tpmehky1f447c8pz48f1kt46oquo X-HE-Tag: 1738309207-866445 X-HE-Meta: U2FsdGVkX1/SupR1WL1icl+IIDhW+tvX20SYJ407N3qx0eCTazxvi+Zcm0WnVODCv/0YR1uxLPwbX8OYGcgjGhWNNlXd6mJHoMyEvgrKH/b9JmI5tNvFjIWzRUoZyNO3bv7Ivk2x94IoNWb3MbzO3CWl76brRLrj+eoYOUGAAzhe4Xz0tuZtC7joJ0QVMpyRthTdQysKRCzI5peL0i87QqS/3v8vl2O0L254G9WlHn4KZXPNwY+ACrN0uVDIEvw8MbvrHooPon8Aggp62EbhoFIiD2V3IBdaEQrQPOPXBoVOkRKg69rs1lS1qcasii+2tMhS//EZ+AlM8YVyIxLAZGQdoUEmJd5hjHbAYb97jrULkuxF2LEErDpS8SjQgN/4VDYFq62sbkgejXecMPveJRxF4BjRQF2h8p4fR7R7b8cc9gex1q/U2KzBEsfziieKTZ2wuX3NIN/l5gkp0tTaUuMd0RwqXETBo9zQbNwxabft2F3gk8u/If9TB5sxXqmDQfQ+DnXT9kTPYiNpox/EVm4x8rr3QKbh03Tjp45yZCZCj69VfQ4SeV/CaExN6El9txizz+vHNx1JVYxGMaOjOIWnmpSQ82d/jIlfFRNu1reJ/cnkDljqlOeFgcw2elURto6AKw1iQI806rkrIfhIGwtNQkkH2HEiz8/xnRHo0IiR2CENkF9DfWtLMeapjxvcymJ6VuW4vnxk9LBoBIuepLDELLJe9iH5xI+13dllC7xl7HmjFNtpzKk+poe9KoFslpi5O2GzwwJu4KU4bWJGdA9hV/hm94C0s4U6WOfWdgVLIXjNFKy06DwuERJIqaGnMGE3fzw+7yGi6eJZgIvI09mNySpp6+cVdvDYtihxNG0fYUWx+Bsfela59oizBg3TL2oBCEEhbPVeE4JleFzcyNApkK6+UzXq0xfuEKyDb/sQ/UyiVqM/zAFPoiT/hFZ6U35yf29x+CFYwQgofzU eQAwDVs8 JlMaIsIkX6vkjBZrYbhu+lDRl4MwiEYYcG+8iDlKP8hjXdKtVtA91yRATiJniigUIXKximI6zBBkdoiKhksK4o8XC8sVE3K4AdTE3b5HXtQWTPXDzY7t4/WcMpDDRtebZvWgAn9/6niQaU1K/Lc5VXWXwaheORH4j0DacI10GEtr9pqwqk4wseeUjyPcpc03xWuBBkHDXH8BtVCemUn4C/aBOyU2Llry6WWqjSi0Pox8RGKQMlIuFpEVhldFexEHVcyN3sL77B3H2GWL7lHiPspNT/5MOjHvIXoY3QUi1kqu2I/1layd9F3gxeHMezyAqzN7qPsEsvdaDteX5pmhkgIKH9SNPVH116szZYrFjX/dYeSomtQkGKadLT+SgdcopNaU3labYLVhNMZ8Kh/8CcLSpRk4zl67scPyemEW+e0xvh8Zzgvzsa4ttOFOb2ivMwTeqT6fUoOAN0JEezEPNxSucveW1SEkh1+A1CFgMQaQLu6OPOYGbBnvd8ArwbSUfArknjgECyjYkjrmWHYFLCEdg9yTgocQuV0rOeRizBBg5beRcrZOOzYlw7Y0pL3KcTahkopxru2Hy0CyfzA6IMwQecY3+QXdxgtWP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liam, On Thu, 30 Jan 2025 at 16:17, Liam R. Howlett wro= te: > * Geert Uytterhoeven [250130 09:25]: > > On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett = wrote: > > > > > it is to get m68k to build, you should probably know how to read = a > > > > > makefile. > > > > > > > > Like all other kernel cross-compilation? Usually you don't even hav= e > > > > to know where your cross-compiler is living: > > > > > > > > make ARCH=3Dm68k > > > > > > Ignoring that I had to make a config - which asked challenging > > > questions... > > > > make ARCH=3Dm68k defconfig > > That also prompts, defoldconfig did not. Hmm, using a defconfig should never ask for questions. Perhaps this might happen if it has an option enabled that depends on specific compiler support? > > > And ignoring the steps to get m68k compiler... > > > > apt install gcc-m68k-linux-gnu? > > There are a few compilers, multilib or such? I've had issues with > getting all the archs working for cross compile on the same machine > (arm, arm64, riscv, m68k, ppc, ppc64, parisc). I have installed all of the above (and more) from Ubuntu (except for parisc, as Ubuntu does not have it), and more from https://www.kernel.org/pub/tools/crosstool/. All of them should work fine (for building kernels). > > > > > > When trying the above, and ignoring failures due to missing pac= kages > > > > > > on my host: > > > > > > - there are several weird build errors, > > > > > > - this doesn't play well with O=3D, > > > > > > - lots of scary warnings when building for 32-bit, > > > > > > - ... > > > > > > > > > > > > In file included from ./include/linux/sched.h:12, > > > from arch/m68k/kernel/asm-offsets.c:15: > > > ./arch/m68k/include/asm/current.h:7:30: error: invalid register name = for =E2=80=98current=E2=80=99 > > > 7 | register struct task_struct *current __asm__("%a2"); > > > > Which compiler are you using? > > I've had a hard time getting m68k to boot in qemu because of the lack of > userspace. I use m68k for nommu testing, but have a hard time getting > the buildroot to work correctly to build what I need. I only do m68k with MMU, and use Debian (ports) userland. Perhaps https://landley.net/toybox/ might give you a nommu userland. > More importantly, I think I get your point, you think that the testing > should be integrated and complain if it's broken - at least by bots. I > don't think this is practical in all cases, unfortunately. Exactly: - (cross)building kernel module tests is easy, and included in a kernel build, so build failures are detected early. - (cross)building the userland testing tools is cumbersome. So there's an opportunity for improvement... Thanks! Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds