From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E378BC3DA6E for ; Wed, 20 Dec 2023 11:54:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82EE48D0005; Wed, 20 Dec 2023 06:54:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DE0C8D0001; Wed, 20 Dec 2023 06:54:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F5388D0005; Wed, 20 Dec 2023 06:54:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 612348D0001 for ; Wed, 20 Dec 2023 06:54:06 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3D99F40AE5 for ; Wed, 20 Dec 2023 11:54:06 +0000 (UTC) X-FDA: 81587038092.25.772CC1D Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 2F55A180002 for ; Wed, 20 Dec 2023 11:54:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703073244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZRd6E3ZRamqxe4Uwdjw8iwxCl/2bY0Td/Eb0RJLZ5RU=; b=8nT7A55dwrFFT5LMIvujG4FOpaERrFfjiygJ4U3/smv62ZmziZiemd+GPAwdrMoP29FAgq l8ASvj/pQi+YQtnEr6x1jW4Bjp4kNPbtneUvddWHfzHkL4qAFgf+0sHw+oKYiSgQMFxg9+ NZMPVVIOx0I3z/ej3q2tA1Wn6AkuHIw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703073244; a=rsa-sha256; cv=none; b=t4l0fzWHm+UjdUe3elQQRcYDU+Wy6zN0EfsT6F5AkutEwBWXche4nOl35VqOGNv3gKHtAF FyoFkm9bCnu2I5gjRQ2suT1GD7yjZuIeNVzqRfHhDD5EFCj3SdwfVhKBY0mJRqUiqfke7E FjMT30vkXcfTP0Sy83u8Y463cnEAhxQ= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-5e784ce9bb8so5754507b3.0 for ; Wed, 20 Dec 2023 03:54:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703073243; x=1703678043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZRd6E3ZRamqxe4Uwdjw8iwxCl/2bY0Td/Eb0RJLZ5RU=; b=pqIZX4qI16/1B7/i8e515vCN8npv1mtCT/s2RxvYqiFXZA6Eoz8MBBGmpllYEmkL0J /8/jpGGFVP8+cYgxhMLcDsm27mCko4P6ls9s4EOenp+1rtAF1ODGN873md1HtuhORdpq o5ipyl30qVI/GzChAtLeLycdvlOn0yLlixaSiWQGql2MQYOtMawyBB6z8nChhjxdrtBZ 6rdVuBIQw/2XvybWK3mvsg2RJtugZdv2Q78+ENK+2MoHE1a0+KQMfjLcHmSb9viAaMNo qanR53rq3Cny+oqO+iQSYxhR5H4SNoYgWyV/H5h43dKU+tIDtgWMaX/cvCuOPnUDSfn8 sr3g== X-Gm-Message-State: AOJu0YzrZ70dzk8mq+SWhBuJlAx83qjMMizRJcfsLk+xmcaTJ2EGkpB6 wKOyRvVA2im0oxxOBPr9d7g3vPPO7vyXhw== X-Google-Smtp-Source: AGHT+IE50RJ51XjofdvP4VePTgVe5RveXgQSP+Cazbfo9K+s+gVRkzfc12HwTEJAg8lZasOx8trRKA== X-Received: by 2002:a0d:e694:0:b0:5e4:cba8:e4f1 with SMTP id p142-20020a0de694000000b005e4cba8e4f1mr1489280ywe.17.1703073243061; Wed, 20 Dec 2023 03:54:03 -0800 (PST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com. [209.85.128.174]) by smtp.gmail.com with ESMTPSA id n190-20020a0dcbc7000000b005e8e6d35fb2sm83297ywd.70.2023.12.20.03.54.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 03:54:02 -0800 (PST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-5e7415df4d6so5415697b3.0 for ; Wed, 20 Dec 2023 03:54:01 -0800 (PST) X-Received: by 2002:a0d:e747:0:b0:5d8:212:8483 with SMTP id q68-20020a0de747000000b005d802128483mr2237190ywe.20.1703073241008; Wed, 20 Dec 2023 03:54:01 -0800 (PST) MIME-Version: 1.0 References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033300.3553457-1-kent.overstreet@linux.dev> <20231216033300.3553457-10-kent.overstreet@linux.dev> In-Reply-To: <20231216033300.3553457-10-kent.overstreet@linux.dev> From: Geert Uytterhoeven Date: Wed, 20 Dec 2023 12:53:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 42/50] sem: Split out sem_types.h To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2F55A180002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: uu8f6r6kzmqy94y1dsmn1835agza7jpr X-HE-Tag: 1703073243-40567 X-HE-Meta: U2FsdGVkX1/02Puy1MeHfK0z2qJbGwIZILXWa7/cCLlJLLkDBvey07RArYFbs1qH7zaUX/qap0xqzCZ7S6x3pavNf7kfhk4eV4omM7TE8zjgVRHqjJC9LZTafJLJFX5KHZipeaZpBj/lh/VdG6nhdrJqzJYmhYQzRezE3BehFUV/b6bMKfRS1th2gJPNeF9mTbvMxQxJnvYqO0xSrhq5l+650EzaI21rXolx420MjcB3VH6VCRpimMUq232TqfkiO2o3+Tg/ZhVG7ZVJOUBiR1d+2pB2iskgKRWroFtklQgUteK6ZSqfeJuSQIT9XFDqDAtbtTI5OommhgX4Ce7q0t9hnP+U+Wn/sZRcSwBHEVxRkuB8x2GtP+XB/ewqJpYSL506UkY27Q+q9AH6A+CIs5arVdBQsfM6SdoZ4BnWP90jXM44ZKEDlGWkScdhOLGQBPtbQHiLv1vG/XEwrSfuLVTOUwpj/KQWyutIHt4DqPsNY/Y1XStsqE6u+LG8tsHBpp/Cm32HsER47okaYnU0UTzwsQxa0Bvl5eclG5RhFpvpre7dYjUMrivLgKgaIwSQ0LY6IUZ7MckBE+ak5m3oub/UVdSxFUnfyDwd1zvQ2H6GxpQEWA1QvLTn8runU7Am8t6dySKWpxme68HWoFSJrL1sLalXSxAykbjy29iHE2gjYSPeXLPEBEdpaoWF2jDfVujxSjZzPoutLcgE7EPAnejAC9YE7Nj2fQJuS274HlNz3D/PC6uZTB1MTLZxSRTJEixqBsPA8s1A90zOX0fH7/d152s/IzFVAdKnAwEKgQT/KL2nFhCofcaTb+jM9BqcXXVVcFJu4uzscqVGq4kfBR4fjAfdpoM/Pn9I+3sbr3NsDcmQ8JqlYg6lrT2RAOE//76w15fS/1F/Qia2S/zvUR86Ggticuiz6wqfdrPe0h0RvSLz1XORa/fk+YT+qkwaYDHa59n2gduu3Om22cF Y345kmG4 CsnjqpoJJsQKx/8EKAtYxrh68Ie81zdrblnZyJjVLHMTcUCa/bufMLFx7yDHlZhZ3zkbEjy/gKuO3hySdby9OB32nm2/c/1lBFJQgVjUPJT0rWsnLaueFMEWAeB4Lc683BFR2ilwshG46ax+ufQPyGIKXSu9eOeQNhnyrwYF497GZYm4aBayRUNaUi3U/gEfPmTYEtpCec7qHQPDiSgpNMBworraNT0euhhq7oPtD3axpuXplrCJHLwK8ZD7L53cg6O/fABbTk8ixcVfQYpGFxnblN7xaddetS7eXgJsdJ60pjUZLkfejqWL+4t9t0dMu3Rtmcmg2KSfShY9ZElRDsHWJjp/fFG8tYrSAE25qg9sb9kPsaflwC43GZeS3UQi6pBtYMUjhOZselj5IIhqNajAmhQeAuRoQq7rCCWSfOjB6H+H6dQMLcjHsG9RnJeAkWqlhxQWM7mgHYOWixofLVlwU8qAFfQyCfdPqCd6sk6hRo4Eyn/GKQCmOMOmjsdxYXToDNHi8coLMudj0ENnHKkdUHUXKsbpEVsY/6CvmWAQBU8ntr4qdLM7ZMDE+eZ9LwuYv+8nND+Zyujo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kent, On Sat, Dec 16, 2023 at 4:37=E2=80=AFAM Kent Overstreet wrote: > More sched.h dependency pruning. > > Signed-off-by: Kent Overstreet Thanks for your patch, which is now commit eb72d60ccaed883a ("sem: Split out sem_types.h") in next-20231220. $ make ARCH=3Dm68k defconfig arch/m68k/kernel/asm-offsets.i *** Default configuration is based on 'multi_defconfig' # # No change to .config # UPD include/config/kernel.release UPD include/generated/utsrelease.h CC arch/m68k/kernel/asm-offsets.s In file included from arch/m68k/kernel/asm-offsets.c:15: ./include/linux/sched.h:551:3: error: conflicting types for =E2=80=98____cacheline_aligned=E2=80=99 551 | } ____cacheline_aligned; | ^~~~~~~~~~~~~~~~~~~~~ ./include/linux/sched.h:509:3: note: previous declaration of =E2=80=98____cacheline_aligned=E2=80=99 was here 509 | } ____cacheline_aligned; | ^~~~~~~~~~~~~~~~~~~~~ make[3]: *** [scripts/Makefile.build:116: arch/m68k/kernel/asm-offsets.s] Error 1 make[2]: *** [Makefile:1191: prepare0] Error 2 make[1]: *** [Makefile:350: __build_one_by_one] Error 2 make: *** [Makefile:234: __sub-make] Error 2 > --- a/include/linux/audit.h > +++ b/include/linux/audit.h > @@ -400,6 +400,7 @@ static inline void audit_ptrace(struct task_struct *t= ) > } > > /* Private API (for audit.c only) */ > +struct kern_ipc_perm; > extern void __audit_ipc_obj(struct kern_ipc_perm *ipcp); > extern void __audit_ipc_set_perm(unsigned long qbytes, uid_t uid, gid_t = gid, umode_t mode); > extern void __audit_bprm(struct linux_binprm *bprm); > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 157e7af36bb7..98885e3a81e8 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -13,12 +13,13 @@ > > #include > #include > -#include > +#include > #include > #include > #include > #include > #include > +#include > #include > #include > #include > diff --git a/include/linux/sem.h b/include/linux/sem.h > index 5608a500c43e..c4deefe42aeb 100644 > --- a/include/linux/sem.h > +++ b/include/linux/sem.h > @@ -3,25 +3,17 @@ > #define _LINUX_SEM_H > > #include > +#include > > struct task_struct; > -struct sem_undo_list; > > #ifdef CONFIG_SYSVIPC > > -struct sysv_sem { > - struct sem_undo_list *undo_list; > -}; > - > extern int copy_semundo(unsigned long clone_flags, struct task_struct *t= sk); > extern void exit_sem(struct task_struct *tsk); > > #else > > -struct sysv_sem { > - /* empty */ > -}; > - > static inline int copy_semundo(unsigned long clone_flags, struct task_st= ruct *tsk) > { > return 0; > diff --git a/include/linux/sem_types.h b/include/linux/sem_types.h > new file mode 100644 > index 000000000000..73df1971a7ae > --- /dev/null > +++ b/include/linux/sem_types.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_SEM_TYPES_H > +#define _LINUX_SEM_TYPES_H > + > +struct sem_undo_list; > + > +struct sysv_sem { > +#ifdef CONFIG_SYSVIPC > + struct sem_undo_list *undo_list; > +#endif > +}; > + > +#endif /* _LINUX_SEM_TYPES_H */ > Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds