From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA26E77188 for ; Fri, 3 Jan 2025 11:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 495326B007B; Fri, 3 Jan 2025 06:19:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F71F6B0082; Fri, 3 Jan 2025 06:19:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2712D6B0083; Fri, 3 Jan 2025 06:19:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0AD106B007B for ; Fri, 3 Jan 2025 06:19:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B43AE140696 for ; Fri, 3 Jan 2025 11:19:37 +0000 (UTC) X-FDA: 82965894732.14.35CA65C Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf27.hostedemail.com (Postfix) with ESMTP id 72D1040006 for ; Fri, 3 Jan 2025 11:18:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735903136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HDFVJ3n3kKrw5RCyDZC9551byJLb/mR9RzkqrgJ1y6U=; b=L8o2jQoZ0eAtW+E32MO0Sc+Vt0qE9LVFcEW10PIRR0ZfR3UJ+Jd2ofCznFU9l3SIIjMuR1 mM2PC7PwJ3ZwZibkhtePaixRX7Z4vBaoNZQP97be6JkD1ujKCODmUHx/fKJB+FhNkcdNzj mlbka8PrhePF24cCxsGI8Gfv+nEAXBU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735903136; a=rsa-sha256; cv=none; b=1poLixbr4cOHjtbxL+b3kKQp09KRUm4/kfnT43kpHkUvtOVToeFU+YuNDkyRaNmMhG++5H mAb2RFXVoS0GgMwQ33hlITh96f1cvd2bskTPI4kN+TaHtJgpI7ePnaXPFRB7eqB91mLJ2u 9zjjL7HOmawu0DuuBV8fZpKXSnN/1UA= Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-29e5c0c46c3so6226775fac.3 for ; Fri, 03 Jan 2025 03:19:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735903174; x=1736507974; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HDFVJ3n3kKrw5RCyDZC9551byJLb/mR9RzkqrgJ1y6U=; b=XorNtPgnwMMvl4eUUEYsuppoMA+CHi0ws6twHRwFU09i/VKm+jv0lqiOfuqECHJdbM H10vCiHhIhsLhN2G4Gl2vY6Rwqpf9BvwB2RZ+d+PeRxRkbEk9DogpqzZ2WwUE0itX/84 MV/l2miGA7dO69byvaKd4DjdBVzFVkuv4v3dzhjJtUvF3/X3kkPoieee0jPLDrKKhK7a sa5cDZGPa0RovR5rsuU/fmOrvMFjc3ITcdnD/qC8RlTXcxtVnH2Wi/PjocqRt2E9Fg2E TSwF6b1XS5pcer99Si9guadMIAuOk2zGeB/qlL4xA9INpzpiHsU4R0hFkD5TpS3LcEDn CiOA== X-Forwarded-Encrypted: i=1; AJvYcCV+QDOHOwXoDzY3+RVQXgJkR7C/eQ+1rvttQvNO6nEaczKwNbBIQMtKtVdVpnhwqg28457mI45IrA==@kvack.org X-Gm-Message-State: AOJu0Yxb4sdLEnCLUUuz6VoK4MHUheCRq25Qzd7pYytOfdaMhHi2/oSx le3Yl4BTvfIDUwCRlguAsMNJmBEZ4x1X51TOz+W2pmfGHPpw+oJ1RETfxoSp+vk= X-Gm-Gg: ASbGncvQEpPjrt9xIFvG0sHp/sfE/b+GD49oeVUvtDcCWwPvxPkN9AGTqXKQPkVK6s4 5JGStCfbBcthtWTzu12xjVScDafv1R3Dny7OdfO7C0DfQt93R7WoXqHVFjwbTA5s0DeCFM3l11J 6xOEJrGulv3hXkJjuIz7bRIFgJxC7N642K0w7k2L/+UXsXXXk4CXI30NPe+tlPV0uqvRDEn8r+6 Krn4GsTMrS+PxQs6feX7KbtboKsSMJBAN05DJA7J1qEBE/3uFfqaCCWKC/qkObSQJRFKyLkmUUS pj12vUuOuJxcNC56g8LphnM= X-Google-Smtp-Source: AGHT+IFvP6Opi2AwtssycgrafIduJug3pCGVWvQoNr3HgVaZUbBYsoEgw6VhsENYHedXfx2ZHCHOyg== X-Received: by 2002:a05:6871:1c5:b0:2a3:c59f:577b with SMTP id 586e51a60fabf-2a7fb2ea4a0mr27621458fac.24.1735903173947; Fri, 03 Jan 2025 03:19:33 -0800 (PST) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com. [209.85.167.171]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2a7d7568b65sm9720701fac.31.2025.01.03.03.19.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jan 2025 03:19:33 -0800 (PST) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3eb7f3b1342so5177592b6e.1 for ; Fri, 03 Jan 2025 03:19:33 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXeJjHjeoi0sPj34KTVK2yVhjJpLevTdpTxvUM6LGjepVCynjXEi3rYEtH6DDuZnuJNNfeRWNzdag==@kvack.org X-Received: by 2002:a05:6102:5684:b0:4b1:130f:9fc0 with SMTP id ada2fe7eead31-4b2cc3808a4mr38937534137.16.1735902681279; Fri, 03 Jan 2025 03:11:21 -0800 (PST) MIME-Version: 1.0 References: <20241228145746.2783627-1-yukaixiong@huawei.com> <20241228145746.2783627-15-yukaixiong@huawei.com> In-Reply-To: <20241228145746.2783627-15-yukaixiong@huawei.com> From: Geert Uytterhoeven Date: Fri, 3 Jan 2025 12:11:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 -next 14/15] sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 72D1040006 X-Rspamd-Server: rspam12 X-Stat-Signature: m9r4etjkf8zrjbaxtogj5mc8i5ajeifo X-Rspam-User: X-HE-Tag: 1735903120-324698 X-HE-Meta: U2FsdGVkX19zMW7x03XBgok/kjitqRWRYzgQTI1J8Y8Dk02Y+ITZirQE/8dtjPmIrivsYcVkXIKMq4E2ei0EmyyL247s470JzFaM3KI1giJgq77o6JTvy6qE/o0nK+o+NmjkLKFy9q6GGirppnjzL2lQ05lQ+ma6J0/aHCn2VjvLR1QywZw4XMVqbJisJHHgNBOK3g475vbZ4814NJ/gackeVeSJxc4eYYhtsNPQ7VIQQd5ROKPbjcd2/aroc4BYEG2KCeqTfRBTzRS5BvxEF9D2wcz+k+y/Va7iYxJQhQkWsW+SNKwnlWQRsscx5dGsVeRWcrbx/w3neppn1mlIW9AGaDHv6jzElc/LMBaVuEqf2KEgmOc0a0wPmAeQCe0SrytonoKleOx823sL5zTAdmn/eSaoMImImOp+aOQGZ+MstCS/Sm9cI16+veMzEfnvcylkUnmV10sg5DtPBpUdhNDcdmxbOhzkawmCN9JgyuLiK87uOwycIdjydYe/zL/idTQ6ToKdgZRYigK9WnV5p6l3Tvx+HB6WOZp9LhJVcvTU+vUHLOPDcDyT4oyDmtx3CyP5yxYSf51WfgGEbzWC8N16hRUIa1tJ9iP/KwmN25GPFQHSX8q8F9z/MylR6gWeAfoILCh0d++p6h1ivfv8u+J7DcNsr1BPOmrU0AUCuo7yasauDNvWCLGfR9cmcj0lJbTJdUtq1u1rH4+0eezJLit2fdteYeApcrW7rHKkVCGHEoF1SoEsGRkLIkAYIBA+EAia2uJwSYHIyZOT15b6MW3b1QwKaIcrga6Zzn4JZNIScMPhS75OijChoiMbGWlBBoxEwmMsdxxBYci5def7YiLFvahxk+1Dx/9EXkknnDX7P1nsICfx76i5SaVXqjOMm1o8Wqpv/Thj0lPyqUuip6+wHd2Stpm0xb+MOqkSxMdSJ/1f96A8kPIQWfGJfmg0dWGF5Zl/TSX1sky5Gbo vCrnCdZR pv4fjRxiP0O2aWnKnotqRmX7/DJVG3LjFMQLR4eSWww2M1/CCA2I74taZBMErLVmt9tam7w+xg6elK9GziqmxutX8OGCfj2L9/bGNti1ZPlteHjXUmi5GXP7/w0z7UX8gI8GpbJjXY2LAbel9WvgwCiHAhwjlHgyMGhrsD117le0O9j1L/PGUPtho+7a5ptSAhJVnjxSO4QohTonieKv7w0VDVUoFecEOaVVFxBZXa+EaixB2YxJfzHn4SR3TgQJ6/SiOEDH5c7pysxXckLoeKdj2XCz4ecw1qS9y3RA+EGfjYvOZSfRARrUjG0lJzvE/oF20kwofePnAhDf/aKHfPzAGsngwF2rLFN548XzEUpkSc++t847XfwrKJR8eFiFrtMrG1Y97/Og5U607xM0laDUe26YcRgU+TKo+cweowwWZn5JKnPmb+uH24y0PGVXHcPxM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kaixiong, On Sat, Dec 28, 2024 at 4:07=E2=80=AFPM Kaixiong Yu = wrote: > When CONFIG_SUPERH and CONFIG_VSYSCALL are defined, > vdso_enabled belongs to arch/sh/kernel/vsyscall/vsyscall.c. > So, move it into its own file. After this patch is applied, > all sysctls of vm_table would be moved. So, delete vm_table. > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook > --- > v4: > - const qualify struct ctl_table vdso_table Thanks for your patch! I gave this a try on landisk, and /proc/sys/vm/vdso_enabled disappeared. > --- a/arch/sh/kernel/vsyscall/vsyscall.c > +++ b/arch/sh/kernel/vsyscall/vsyscall.c > @@ -55,6 +67,8 @@ int __init vsyscall_init(void) > &vsyscall_trapa_start, > &vsyscall_trapa_end - &vsyscall_trapa_start); > > + register_sysctl_init("vm", vdso_table); "failed when register_sysctl_sz vdso_table to vm" Adding some debug prints shows that kzalloc() in __register_sysctl_table() fails, presumably because it is called too early in the boot process. > + > return 0; > } Moving the call to register_sysctl_init() into its own fs_initcall(), like the gmail-whitespace-damaged patch below, fixes that. --- a/arch/sh/kernel/vsyscall/vsyscall.c +++ b/arch/sh/kernel/vsyscall/vsyscall.c @@ -67,11 +67,17 @@ int __init vsyscall_init(void) &vsyscall_trapa_start, &vsyscall_trapa_end - &vsyscall_trapa_start); - register_sysctl_init("vm", vdso_table); + return 0; +} +static int __init vm_sysctl_init(void) +{ + register_sysctl_init("vm", vdso_table); return 0; } +fs_initcall(vm_sysctl_init); + /* Setup a VMA at program startup for the vsyscall page */ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp= ) { Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds