From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9A75C433F5 for ; Wed, 9 Feb 2022 16:19:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28A616B0071; Wed, 9 Feb 2022 11:19:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 239136B0075; Wed, 9 Feb 2022 11:19:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 101F16B0078; Wed, 9 Feb 2022 11:19:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id F1B8E6B0071 for ; Wed, 9 Feb 2022 11:19:24 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A355096F0B for ; Wed, 9 Feb 2022 16:19:24 +0000 (UTC) X-FDA: 79123751448.28.03B57A8 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf11.hostedemail.com (Postfix) with ESMTP id 35EE840002 for ; Wed, 9 Feb 2022 16:19:24 +0000 (UTC) Received: by mail-vs1-f53.google.com with SMTP id e18so2100244vsq.10 for ; Wed, 09 Feb 2022 08:19:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bnya6VmSL6leRIRse/uCEksReFzWugbjTC+ac8YkiUs=; b=w2xrDbXDPMt1MOyhKMsqct0/9+s+0iVaAbhVidxVI8dYEAm9TODSd+A/9x/vECI2If Hz1Tx51qmB8vSUmKww6OkYYuQn5y9uaQMlJ/dDH51IpIt67+l/yvrw3u6Ddy5DNmvMl5 yd71BxQxZA+HtSl6ng+3x6wnswQwNgrVuZApLi+3yI1i+prUC1Khlu2WI8GZBzqRiAH6 6DEmn+O5MiEbncGgAVjcR/szR9NJwpqvIcUfJv3rvI07BqYFLg12CF8qqcHuBdu4G/eG bqFOkmfkGC5hubHspzKJg6qPaV/xFojE62lAl5frJEg9cYYx3vVVkBrF4YO9+zDgNZZe uPyQ== X-Gm-Message-State: AOAM530/B96tY6r7gL+0Km8ikUnAlZhaYCgzUFBqE96qPgtJPnXbfX6l +prJpiueWThAQkFf4vd+NEFRDJ0aE3Iupw== X-Google-Smtp-Source: ABdhPJyoShwyxJJ/Dk0uFjpbrmHnYqnhtnLBjk65ZnGguHjMlVfZK5VTy3lifAYWgFK53rDz3O2w/g== X-Received: by 2002:a05:6102:ccb:: with SMTP id g11mr962256vst.75.1644423563378; Wed, 09 Feb 2022 08:19:23 -0800 (PST) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com. [209.85.217.53]) by smtp.gmail.com with ESMTPSA id j63sm1263388vkj.24.2022.02.09.08.19.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 08:19:22 -0800 (PST) Received: by mail-vs1-f53.google.com with SMTP id u17so3170760vsg.8 for ; Wed, 09 Feb 2022 08:19:22 -0800 (PST) X-Received: by 2002:a67:a401:: with SMTP id n1mr910748vse.38.1644423562636; Wed, 09 Feb 2022 08:19:22 -0800 (PST) MIME-Version: 1.0 References: <20220209094158.21941-1-sj@kernel.org> <20220209094158.21941-2-sj@kernel.org> <715a8b2e-1048-c098-8b89-bcf3c13cbd75@google.com> In-Reply-To: <715a8b2e-1048-c098-8b89-bcf3c13cbd75@google.com> From: Geert Uytterhoeven Date: Wed, 9 Feb 2022 17:19:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for-mm 1/2] mm/internal: Implement no-op mlock_page_drain() for !CONFIG_MMU To: Hugh Dickins Cc: SeongJae Park , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: 3gefxfxi9jygqfq9ejd5pysqzh95ui4r Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com X-Rspamd-Queue-Id: 35EE840002 X-HE-Tag: 1644423564-955563 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hugh, On Wed, Feb 9, 2022 at 4:38 PM Hugh Dickins wrote: > The thing is, SeongJae's patch makes me wonder, why did it not need a > !CONFIG_MMU definition for need_mlock_page_drain() too? That's because > mm/swap.c's call to it is under an #ifdef CONFIG_SMP, and I imagine that > CONFIG_MMU=n usually goes along with (but does not necessarily imply?) > CONFIG_SMP=n. It'll be safer to add a need_mlock_page_drain() stub too. RISC-V K210 is SMP without MMU. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds