From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3887C0219D for ; Thu, 13 Feb 2025 11:05:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82532280002; Thu, 13 Feb 2025 06:05:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D459280001; Thu, 13 Feb 2025 06:05:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69C90280002; Thu, 13 Feb 2025 06:05:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4DB3E280001 for ; Thu, 13 Feb 2025 06:05:56 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F1FF14A6AB for ; Thu, 13 Feb 2025 11:05:55 +0000 (UTC) X-FDA: 83114641470.18.9E15991 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by imf22.hostedemail.com (Postfix) with ESMTP id DC728C0004 for ; Thu, 13 Feb 2025 11:05:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739444754; a=rsa-sha256; cv=none; b=8o3dHXIKKzIWy3m+deJCtFi9Hmwjd7Yaep8RtZYo8T+kWNwo/RCC24JP3KYCBwlZPcejZt /evNnl5n/Zq83kgQPj3/Tje59Ro8h4EbVZAeUR164x3zIYoIEwAamkIsg+stG73wkrvRdx 5omXhQoAyJg2JDdrEuh9uboztM7XynA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739444754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zAeciXbZsCKyuzMnsNDc2dPCf1u4qXoSEiFxuqZqCsA=; b=qR5aueuiKMFRxUyjDMZ8V+Ed2+G80HJ7e+Qo9xzNrJJeOr8TGmfwESLjvJaxEJRBDBwxW7 QXLY8UqsLP30IJPiBI8g+Ki4BZ4ydMA0cEQQWym35Ij/yQTD7kJ648pYNxWCV44GtooPGx R0N3PyguGfeUkhnY9oPv0CA9J6PgY7A= Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-4bbeb009101so206904137.1 for ; Thu, 13 Feb 2025 03:05:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739444752; x=1740049552; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zAeciXbZsCKyuzMnsNDc2dPCf1u4qXoSEiFxuqZqCsA=; b=ZOrxEEF41C7OX5aXbsHIu6mrK/hQ5amfxr6QDsmZYxgpZWiEkNmSMQvcDflR4tAYG3 SKLGRN1poDw9hG3Hvhoc4eTI4mXiX19WWY+Gu9E/08iy3ub/lVUFq2ySeEskajRRG7Ra cX9fOIPTqjgyEuZnBdD2jaYrbmiuv2x3LmQaHX78Sf5MjdkkPzUQfhgBKNmWspjN6Kkk OUQqTlE1E88nUyhsTHfKXr1SpK4R8uEwfyzAbFY00CCplifL4sHA6dQ5pRIgxW1UScb2 Dmt4szHra0lnYQYQ/4fdho1xD7e1/UxexcJa/IkB72UopcPyaJSFsDJabwWMQkIqrjfP 4Whw== X-Forwarded-Encrypted: i=1; AJvYcCWiOsktDxSwW2b0Lb6PMuQpb+ut927DVFj5glNm6lAJLnsE6Y0rGkEk/xN3/tmpcLY5enPXv8lzWg==@kvack.org X-Gm-Message-State: AOJu0Yxy/2VDp7RXML0YsV7irY5DncFwjOBjCn8vxsN52K8ND79Qqzi9 BnSoHCcKZqzHzr86c6ZPakaMUEbBd+mOJdAdZ8VAl2/Feqca3j2Nb2Lcg321eyQ= X-Gm-Gg: ASbGncuf9E02i35m2GaYC8glXQcjEQUrIUDmt0gp222ytRBVYK6KBkLXIOQ7Mr1OZ// Da/dGtzv2AZmOxEHSmwVi01c72VtJgf926sCfORfVv1sSt5pLGldOKhbEIhDSg7tY1fHFy/ORo/ QL6JvqcDO52gbeOme3X/O3TKuaDQuWB3WsZYRukZkiRXxv5Y5Qqc26zxXjzvZrfQJ+Ple6H4upM k/Xc6bhgPTcjpt8S9RZvyBMJrMWqOYLugwG82r7T84nhki8EzyIJYNEezPUSo0jnSWE7I0uTbEt zlUwv89ryJ3OiNz0T1GhYRVg6NcU0HqZtSXQQAmvDGwMfPpDN+84oA== X-Google-Smtp-Source: AGHT+IGFq1/bPNUcokilMKJH8oKTEjZrfkFr5nTpaIu3e/WOmpwgbpjkYr56+PVLKif0hLwbWforFA== X-Received: by 2002:a05:6102:2ad4:b0:4bb:e511:159e with SMTP id ada2fe7eead31-4bc032e0facmr2936148137.0.1739444752352; Thu, 13 Feb 2025 03:05:52 -0800 (PST) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com. [209.85.217.54]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4bc07961654sm137647137.19.2025.02.13.03.05.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 03:05:51 -0800 (PST) Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-4bbeb009101so206891137.1 for ; Thu, 13 Feb 2025 03:05:49 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUProW9GOEqErk4HpBhUuhECW/DuWgPou1EwIXscTeiNr2czUsYH8VkCkQehuv0zrNF+SinbYXF8g==@kvack.org X-Received: by 2002:a05:6102:4191:b0:4bb:c76d:39ec with SMTP id ada2fe7eead31-4bc037ed546mr2901047137.21.1739444749243; Thu, 13 Feb 2025 03:05:49 -0800 (PST) MIME-Version: 1.0 References: <20250213163659.414309-1-shikemeng@huaweicloud.com> In-Reply-To: <20250213163659.414309-1-shikemeng@huaweicloud.com> From: Geert Uytterhoeven Date: Thu, 13 Feb 2025 12:05:35 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZnHf2rYoOMv80GeHY-uBNi4bTK5uU1XQydU8dNetDolpRg56K4qRZqIqP0 Message-ID: Subject: Re: [PATCH] test_xarray: fix failure in check_pause when CONFIG_XARRAY_MULTI is not defined To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 4xjs98hmx9c3jom3oh9y59955gzprmd6 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DC728C0004 X-Rspam-User: X-HE-Tag: 1739444753-735209 X-HE-Meta: U2FsdGVkX191Xr/8sb6pCeadPoEW4XumSFXB2FhtrEUTIUw5x8o/zHfe+j6MCQXCgb+mp+37ezLD2dpw0PeEEZDB6t5cO2naQsvRt0cOHlrPixDTCMWv5Zhonv6oh8yERSOGcq/t3oi8bCYg//dzSgIv3kQv/zSaeGbMVTmWWKKBxFKb182uvbeqHC/ABWJn7icIDwegwJ+eEGSKeInZ1N91ALQpDXJqBprRk1DtzRNv7TwbSfuCojpe/MfpyrP1RHCFZFvHXKVOsokGlgxaZh58aUxAwcAx6tbD7s+nk5dzajreMy/uIO3Fw0twj/N1Mea5Pone8NbQUQYsEEF/Q7fGv3QJNVKMEdgbqfd4wE9TIl8T9SQieqqdT+tcBRgq608ND9S+Rl4vI7sCf4kkVYZ+YSNf9YGHRavxDzGYw6baL0gWsyYQ3FQtznrP5hfX2Eosy67ULoWr1gJU76ZnDW3sfc+mzl9p6CiKV+xvPdUhzkXslPrw51++PxhlKNiEDI12VBSAUSr5AY68mpPWtiH9ejcltVBPtOrDbIPo4pkJO2wXTS7NTirk4/mNTz4WI+7HiP5MPHKU+fEm+CVeZ6jIb4sipdT7KEL/v3qmwIFPsfqbg0tPDBZtr8SxxRraC1zROHKknok0j2PulwW/qdwF/WtEQ2n8I44+Jh0F6lyNfc8Ue47lFvbcdSN4qdHihCEDBU9BkDDFcHQxl6iu7Hi8hhpcHTQmaUReQOetl1ox1G7UOQp7kvCKx62GKnPvW5yWQd4KG0s++T4O58rg2CQ9sQQz5XPmRA5f2uSZvmmm0pH7EPajnmdjXcVn0lHDivXDNH62pOS+95mdlNukYGYhNc/mG87YEvMvc5xd1hKKyDaoDihYL1YqkULewU68u3ev5pqSBmjhaOHjpSH23TSAcEgq0jD3XsmbGlRAhT2uqD7eprkxSb5IIu+nzIfdVLJ2tVMEjZFreOfytAO FCveQX08 zPgnEiw4UlbxfrbyWKjx1VDamFV8TuOI8dgcLTFs1zUJJlZ8Silc0ZU/8Gz7yH7p4PBCOAzDaAf//74JvH/ov6Emlg4LAyRn2TeYLc7BxcjWtTWg4nGkjJU79edAGK8XYwzhQRteYHNbne/zpCysK4n/7Gpg2bUjRoS/yMS8TXE99uHz6kLkf4FaFFU82Fk/zMJl8ucBsMNlZUC/MJXIZb1YAY9moEQ73KY0jEN3pR4wGT/WTEu/qmrAkE09rv7nlEvSKIG+d6K/Fu7COuGKxNVb9mUdNoMbocIrm9e5OWI8PPw6cGL9ZtYI4wrk6Bfloc7w7jIs+elyUDBQJf+GyRge3dY237Uc18p+bZTOMhIv/8lyeFvJ3OnA1q2gbfbN1skevENYL77yd/3VyzHwKCKKInn0V+LYty6hcfyt3sSF3llNYsKaceyb4Lt3E6bQopL17WhwyXeQUZVArjEuKJtwqVgEtWQGFgVpfxr7SurHg8mU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000515, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kemeng, On Thu, 13 Feb 2025 at 08:40, Kemeng Shi wrote: > In case CONFIG_XARRAY_MULTI is not defined, xa_store_order can store a > multi-index entry but xas_for_each can't tell sbiling entry from valid > entry. So the check_pause failed when we store a multi-index entry and > wish xas_for_each can handle it normally. Avoid to store multi-index > entry when CONFIG_XARRAY_MULTI is disabled to fix the failure. > > Signed-off-by: Kemeng Shi > Reported-by: Geert Uytterhoeven Thanks, this fixes the selftest on m68k/ARAnyM. Closes: https://lore.kernel.org/r/CAMuHMdU_bfadUO=0OZ=AoQ9EAmQPA4wsLCBqohXR+QCeCKRn4A@mail.gmail.com Fixes: c9ba5249ef8b080c ("Xarray: move forward index correctly in xas_pause()") Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds