From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EA0C61DA3 for ; Tue, 21 Feb 2023 10:03:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9937E6B0071; Tue, 21 Feb 2023 05:03:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9439C6B0072; Tue, 21 Feb 2023 05:03:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A8C6B0073; Tue, 21 Feb 2023 05:03:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 70E996B0071 for ; Tue, 21 Feb 2023 05:03:30 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 44CB4A1086 for ; Tue, 21 Feb 2023 10:03:30 +0000 (UTC) X-FDA: 80490861780.09.E31797D Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 756CFC001A for ; Tue, 21 Feb 2023 10:03:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676973807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8IkLkYW3Mrz4W4E6CahA4nVgDfr/jjbUUP9owXsZ0sQ=; b=8Ea4y1HcF92YvH7Ej59P1ergIqidUaMQEG0pehK/RfTJCPsPI6KsbBUv62aCqphesLySXT z3dBHVO+ww78f3l+HQVGux4613078jeopfHJXU0nDJdXl7oZWeLI/dA5Yi8d8otLvxu9zF Ffx9pNiXb04Fj2jJyrPfz7kQcLZsiY4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676973807; a=rsa-sha256; cv=none; b=x0K3fyrzIC2WFsoP/kdn+/KJ2JF6iDzTjWFRchNWiL1+aUaMF9IROGV9mPIUgHBLcnmJyN L+GB61dtpfN15d6odINkrmS6QmKpKJK/TcdRrzogFDtnT6W8fk4ff2N1HSzZv2DAcRq+ee MaRCUnP7HA4Vw7ETPfqF1oe6cx1/aMo= Received: by mail-qt1-f170.google.com with SMTP id fp16so3763750qtb.10 for ; Tue, 21 Feb 2023 02:03:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8IkLkYW3Mrz4W4E6CahA4nVgDfr/jjbUUP9owXsZ0sQ=; b=ugrxOivXTL0mZBoUvlqFEOzcHJ1wvDWHlNIiRw6Bw1VcGvAF/QLmXcQwYikfqCx+Z1 pmPX877VNAqt8m1YQg+kxPZLihUZsZ9K2/qpUxda3Q7zEVbyJRt24wQDoj0o5c6A5A/l HSbUIwKl/T3ldzKsbwxOzuZuzsn7ur6kKpslI6fAutqLr91GIWAty9d3o+9zwE6qKsoA 9wOxoIAMOV1ljBuCSTpGap5klbF9oB6qr3ixGHENvYIehHjWtTcmIDv9ID+obLsitcQd XBpJRRBhOo35EgY8i0pCo3lNpPaphyKslzs+H0r0LVXDCIEegstXgytVA9biz23EWZaO 1p9g== X-Gm-Message-State: AO0yUKVx55FZnN6VMH+xnkKvPEyw+M84GT+sWV9+T4cT0I3Tc0eOkYaD VzM/XCaMG/U5bccTxBP4ftNRx5/jWMMAiw== X-Google-Smtp-Source: AK7set+vA9SvL4fvLdJbXCu5k/syNZHw/MRzGzyHWdhgTSgcnQmfUhDvC0POWaC6VXrOkXCbeMMcvA== X-Received: by 2002:a05:622a:2d3:b0:3bd:905:3444 with SMTP id a19-20020a05622a02d300b003bd09053444mr6437181qtx.8.1676973806251; Tue, 21 Feb 2023 02:03:26 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id q13-20020a05620a024d00b006f9ddaaf01esm10626720qkn.102.2023.02.21.02.03.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 02:03:25 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id e82so5536520ybh.9 for ; Tue, 21 Feb 2023 02:03:25 -0800 (PST) X-Received: by 2002:a25:e206:0:b0:95b:7778:5158 with SMTP id h6-20020a25e206000000b0095b77785158mr440109ybe.12.1676973805392; Tue, 21 Feb 2023 02:03:25 -0800 (PST) MIME-Version: 1.0 References: <20230221060723.26291-1-bhe@redhat.com> <20230221060723.26291-3-bhe@redhat.com> In-Reply-To: <20230221060723.26291-3-bhe@redhat.com> From: Geert Uytterhoeven Date: Tue, 21 Feb 2023 11:03:14 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 2/2] arch/*/io.h: remove ioremap_uc in some architectures To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, hch@infradead.org, mcgrof@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 756CFC001A X-Rspam-User: X-Stat-Signature: qqsdy8uoue1m5aw8cbqr9uds3pzizs7z X-HE-Tag: 1676973807-836849 X-HE-Meta: U2FsdGVkX19Jz42gp1A4ya/Z0RxMoAH5QGRgm3CCqLbLJqjZV3uqhKFKM6ibaKLWlRes4jj+8u/ugO6YuOjzSpvxh7JoPdbEOQpcYqT+fQAtvLWjn5lX2KRXfOMyI49yNiTmNO/g9Q8y0tlMGt5x8s3WVrDPCxeHKFEZr98JcqDlFeTPLANOBvs6kpHGcaVPrcy2WbQg0VPffiZAK+mGqu6LPy2guhHAoJIicHguNnvEjtiwqRnP8KJ95HrLSAHsKrKg+bzi3Pm28lGO1Lxt9B7RezAASQMVA+j0zFCec4oGFh0Xkr6itsTC0+CQK2uotRWAp2nfVPAnWyOiIyk1cLcr6Cltl71utjrNYW/EsIW6zV3rITb4aidmPYDDul0cEPXtkB/Z92cmO/7WHOtOPgpZ6V/oInHqQ3YwJUp1pgInfxXWXbPZ/5Ctv02hr5mp37IjY4Drk2PR6mZLEFDvyqbucUnf+iKUYUtj+BUWX0bjsRa/Wuf7BVchyIdA743ih5d18QN/bUIgkX6BaPzuS6rHax3t1Lpt7Ein+/jxbmYYunYFqrW170OdpMLzVyo82zHpEurVUXzS7lrTz+62SbV6yYWhJCCBeK+DVbGGPdsCJQIak4Xgff2k088leP6ZqWa8o+IqzIQYyuzAUt3MpJyOx6JQAinds9Mr7ESr4udzfvQ3pKkqIyzEjQoLSfyA4RAB6/Cq9cXF0OtEAPdm29+XT0Nz8yExeNgJnfdUflA3LXcjGRvHZlOV549Leg7ymAHH3Lt3V+iI4sWMc3p4iKwhG3V+/GkbpAE3EZaiPo7Tr1LdKNzfq+FUDrVUmANpC2cw/CDATC5Ha9Jql/yHhPIJUuLIuID5VEsvvjqpcy2cVc9LKIBY5ogObtzGezVQHiy8DJppbbzjTkl8laZy9GBNHQoCEDkP/WJfp1Fnjqllm1tWwLAGFwWlAk5yqA2qrHYYYjaj1l7jPxvJ9D3 /VdiVtDw RkTA362B6Wl7R5yNG+2mtM+0Duqa98kwyhiS7o0EAZysXtUiJWw6ouV/9QutjktT3R6XE/7K9KcVHC33qkkTBCVfIAgdUsdb9/w2vbn9fnJcWzbu2OAzS+7yUi0nBahNm60eWAhnjjX4w5bs6RKt+aN64t1mSJXkeZRQSZuaIOfzqAKvSQLm768oqtbTVm6npwDCjFRolGR2KvK0lFG27OBvJrw+VSO92XsTI0yy75dSSS0/zGhoJALVmGQfVwQhoJPHEiw8B3o0lfE5txeNaoW/qFwaN1CrE0cKdxWLSRK5VRm7fb77SkhUoNuceHC9DL9TUTyEkiI8CISH4w+PmysQEXUREB+EopZ/DxFlRNlaDOYWoIRW7mKcZ5IRuv+DrD7+efCxP9ElM43b0lSk0ncIYtmkQwNt2sdn6GaEqOHKG27FvMzj8n329h9DEw16c/VHG9UBwEcELspEkOTm0vkMkjaQgcpoKIRy843git/O1y74x7Yy2EHW30MDzlRfQ867bDTxhEwsVW+8mhC1kCBFelwTv5Q+EXNvfVlBlBz8XlHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baoquan, Thanks for your patch! On Tue, Feb 21, 2023 at 7:36 AM Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior, everywhere else this is the same as ioremap() anyway. > > So here, remove the ioremap_uc() definition in architecutures other > than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. If any ARCH really needs a specific ioremap_uc() for Please make it very clear that this changes existing behavior. At first, I had completely missed that. And of course the documentation should be updated to reflect that. > its own usage, one ioremap_uc() can be added in the ARH. s/ARH/ARCH/ > arch/m68k/include/asm/kmap.h | 1 - Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds