From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 857D2EB64D9 for ; Sun, 2 Jul 2023 18:20:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B00118E007E; Sun, 2 Jul 2023 14:20:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A888F8E007C; Sun, 2 Jul 2023 14:20:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9029F8E007E; Sun, 2 Jul 2023 14:20:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7D58B8E007C for ; Sun, 2 Jul 2023 14:20:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4EBF41A01C7 for ; Sun, 2 Jul 2023 18:20:42 +0000 (UTC) X-FDA: 80967487524.01.3C21B63 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 599AD40008 for ; Sun, 2 Jul 2023 18:20:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688322040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UKh5KqdrwuQG18TgxeMA+E0eI4gePeGoB28R4nIaZ1w=; b=W9DYT1gALUPEB+fOtaAem1cKNBFH6TfkhtFG376Y3IFCvEy1J8XnM4Yl0ZhGcpNto97SGy Xfaz20OjGkkHqlQEvrO9+ZaH+hiKCr5q2FAHgRfyDovIBi07teq+LyO5knIMNHwRM0BT0q HrkTK486NzkgbW8R/bzpZjnF65Pa4GE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688322040; a=rsa-sha256; cv=none; b=RrCjOiscNqbKhLBdMMVFcqrRSaY8D5AanPXKqTxwuBDWZFgEGUdUmnRi3MYxnsMGUXDXzu E88q9RT+HquVgpw0hL358ER+NRwjS2uLmkpG8WqnZJ53gCnXx5QoXbMGQcSH/fphdyIGQL nfv705oRX8VvYC1LRoyokH9WQ/FKUlQ= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-c4d04d50c4cso692598276.1 for ; Sun, 02 Jul 2023 11:20:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688322039; x=1690914039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UKh5KqdrwuQG18TgxeMA+E0eI4gePeGoB28R4nIaZ1w=; b=YnydeenpcuAlYCNfUWKA88RmOCqafv5neoNCLPqPUERxWEF2Y3N/8DdrqltmvM8yVP Vvuhjk7oVoylXfYu3h5W72If/l/VAthA947GmUTOzz579whernohYF22rtsItaRhqw51 1STEFOr3QiY8mqUFjncHXg6mymf5UkP9K9KvHr3EerAIE6ZzqPR62As3hC05wL0XU1Bt XH15JyLeHtTNVdpiqgM5/rxrM1XagW7IJt2rZmNq1T/c5oUqK7iTRpSPDmY1iDDZyLd+ RXhh+3Qtiq034Lc3rZhjoN4DDX+u0B9YW+eN0AaA81X260OnHQs/+XgKDkwhm98GM2WZ 1/sQ== X-Gm-Message-State: ABy/qLY4WJweSHwC5EcpzBvBPIhh0/jYbpis1kGDJI4J61ZPG8+Ges7p GOSXC328G/bZHHz7AiBRfTbDdriMQ64nGQ== X-Google-Smtp-Source: APBJJlGQNpxn96/AQyboX/lcRYRQrzQer7G+g9E92S5vy15zykvMKRo59HmMQ2p67G56xnOBdmrWhA== X-Received: by 2002:a81:6e03:0:b0:577:3663:e478 with SMTP id j3-20020a816e03000000b005773663e478mr8867990ywc.8.1688322039311; Sun, 02 Jul 2023 11:20:39 -0700 (PDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com. [209.85.219.175]) by smtp.gmail.com with ESMTPSA id g187-20020a8152c4000000b00568b941e5e3sm756180ywb.72.2023.07.02.11.20.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jul 2023 11:20:38 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-c4d04d50c4cso692588276.1 for ; Sun, 02 Jul 2023 11:20:38 -0700 (PDT) X-Received: by 2002:a25:ac1f:0:b0:bab:ef61:8b31 with SMTP id w31-20020a25ac1f000000b00babef618b31mr7966031ybi.53.1688322038540; Sun, 02 Jul 2023 11:20:38 -0700 (PDT) MIME-Version: 1.0 References: <20230518145544.1722059-1-Liam.Howlett@oracle.com> <20230518145544.1722059-34-Liam.Howlett@oracle.com> In-Reply-To: <20230518145544.1722059-34-Liam.Howlett@oracle.com> From: Geert Uytterhoeven Date: Sun, 2 Jul 2023 20:20:26 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 33/35] maple_tree: Update testing code for mas_{next,prev,walk} To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 599AD40008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: m1jamzy86jpjwihpz454oqxnsprozasp X-HE-Tag: 1688322040-541594 X-HE-Meta: U2FsdGVkX1+wl3XpCAX46sYs2FxMR4mWkNnv8yFiJ5ZAIMydRaPdeECCiAOKuu8ZS4pi0NS/VWBYAQmAswoB7Vuy7wDmU2oU2AKz1QowZPtwfQGD9uScy6FhLfhB/UN5gWuQAvKuZ9nq7Cu5p/A3ydxp4qKsP4gTzHeldYviNo21hRZjuCf9ab0ieBALnO8PF8rtg612EIyoJihGfoGExPZFXrNW37yTZEZ49tX3xJfhXx+mzZv1o2RZgmtw3Ee6Yh1T7GGyTkmEqFtqVS7/iAShJgI8yvpEVtwXQSRvJ8shtgAI5zZkLAYp9OIbEH7Rl3G4ot8eEN+/vfRF0nNG6S/3UCKLjn2DkTXxwV8Gi97tW8wYy+u50xnW8cpC0HH9MVQxF7kMVvotMXNWRpzDVWjkhVGXkygF/gSA7KAbuDAM1D8S+q3qXECKWTxdTwNe7gdqPV/qxq2fGBvK308OlZAAot23XyN2MU/GRwjCr0BOzI+yyu4Sx/LTcSa+YWWBIXUp6EVFXVkERkwfQOjp4W4R5dC1FDbukmYvSYH7xPzx4UfWx/afSIXNI/lE8pXZJZuJ2r82mblpVWPpalCtd3fzBP9p6b6AFepJe1r+7LrWxL4xj67Jt15aIrJUBuGArQDC99kJb144zPzZCnxAEllFwGG0OJylR/X2UUv1BvyOM13Xi+Rv9ZiXqE1CufHzuWSJGWJojlYKB+66aZYQzRe2z2sJB7nh4m4Rj0V/HBbK84Wn62liGTHsxn7RH7IEtwDZj3PIlg8y/Mpubn30bFGIyzaQiLn4IFzqgybv7WnzHmWsEJYhhDP4mxh7bfSHbI1iJvxaQVDGfvf5feZwGeALf0KLfydqdQRjKIz9pWLFRhKy5FaWNe72JeA2XVMkr7WlhgRAPbtVn4kmU1x1BdukOnZHE2FSJgg6jTJy9G2oLzTBDOzJ8UhopbNSB6N6nRzIbN579mOpGHiZAkG iAfFPmVy GOX4hVlNS9FunQTSx6gIFrFs/OmwV9Q8J4AS17aYMLuKb+qN45AbloCCRNDiQS0MUdIjRqCYMawTxdH7ij/0Laf/FgiPntiP7RBLjSHdIiJUIP59/1T2XPs8/FnFxOL/gUD/HosLnZKdVf8Uc0l539FE2po4HdQOK3vJTp44lbuXspoydFtqPWvudD4d9N0YhheSUZlbPZ/92cdzv2+7xNGpg/SIL17u8TQBHg//zzWTlebxfyG4Ca4zCNfHNsqtO3+dJPv4UM0RtcUekuexbtXAIo4NIAALFqcnC32C6O8GRprNAiL+4CL7bz1VBzT83jOL1y4b7ZUpgvkIWZrLd7zJGfjL6DLKhwQO2OSvnx8ovdBLW6UWZ9vD+Gm9tnvOP3e0r4jCeSqp3/FDe3ZgBwsPJQK2GDvCMFebeOkBymmcHfWbVgONUZHSskbuSPDrMOoDCzwNDNuFyIaEiI/Y9vzJzj/j25UqfuJnGOWYukRv17Bb9ZhGl+TNNtfvrU3tm5UJ1F5QdSYaNONxmKN7e9yQlvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Liam, On Thu, May 18, 2023 at 9:37=E2=80=AFPM Liam R. Howlett wrote: > Now that the functions have changed the limits, update the testing of > the maple tree to test these new settings. > > Signed-off-by: Liam R. Howlett Thanks for your patch, which is now commit eb2e817f38cafbf7 ("maple_tree: update testing code for mas_{next,prev,walk}") in > --- a/lib/test_maple_tree.c > +++ b/lib/test_maple_tree.c > @@ -2011,7 +2011,7 @@ static noinline void __init next_prev_test(struct m= aple_tree *mt) > > val =3D mas_next(&mas, ULONG_MAX); > MT_BUG_ON(mt, val !=3D NULL); > - MT_BUG_ON(mt, mas.index !=3D ULONG_MAX); > + MT_BUG_ON(mt, mas.index !=3D 0x7d6); On m68k (ARAnyM): TEST STARTING BUG at next_prev_test:2014 (1) Pass: 3749128 Run:3749129 And after that it seems to hang[*]. After adding a debug print (thus shifting all line numbers by +1): next_prev_test:mas.index =3D 0x138e BUG at next_prev_test:2015 (1) 0x138e =3D 5006, while the expected value is 0x7d6 =3D 2006. I guess converting this test to the KUnit framework would make it a bit easier to investigate failures... [*] Left the debug one running, and I got a few more: BUG at check_empty_area_window:2656 (1) Pass: 3754275 Run:3754277 BUG at check_empty_area_window:2657 (1) Pass: 3754275 Run:3754278 BUG at check_empty_area_window:2658 (1) Pass: 3754275 Run:3754279 BUG at check_empty_area_window:2662 (1) Pass: 3754275 Run:3754280 BUG at check_empty_area_window:2663 (1) Pass: 3754275 Run:3754281 maple_tree: 3804518 of 3804524 tests passed So the full test took more than 20 minutes... > MT_BUG_ON(mt, mas.last !=3D ULONG_MAX); > > val =3D mas_prev(&mas, 0); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds