From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75AE7C433FE for ; Thu, 7 Oct 2021 09:28:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D350461090 for ; Thu, 7 Oct 2021 09:28:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D350461090 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 663716B006C; Thu, 7 Oct 2021 05:28:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 613F36B0071; Thu, 7 Oct 2021 05:28:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DB586B0073; Thu, 7 Oct 2021 05:28:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 3BF836B006C for ; Thu, 7 Oct 2021 05:28:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E6DDE8249980 for ; Thu, 7 Oct 2021 09:28:19 +0000 (UTC) X-FDA: 78669115518.28.AE7FE11 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 947ABB000E3E for ; Thu, 7 Oct 2021 09:28:19 +0000 (UTC) Received: by mail-vk1-f170.google.com with SMTP id f126so2433552vke.3 for ; Thu, 07 Oct 2021 02:28:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hzHW72Ay3gWV8fEJFQ+iu6g37baZLnF8PQ8Ot4oxoaI=; b=y+EeltxCci9+SqALjCxPaHkHYKN3OVg8WUCR0h5vIwB5NZ6+8cSLxq7LFNExD+J3qP jzAdyjN0k6tp1uKuPvIaqdIpZ/FX5xHXKEqv+3DPo4R8JCpT4F/CMIT7ad7UEsRvO81H RZ9g2osJLvswQnkg6sBIJMQdNQnKc5mRIT0xETdtAlMd+wACQmutqr25zBe4Lf7/RtYZ b3QPBqsHob0/ZlBEAMUUiSFeUwImq8tSW8Fzc2AAqTIyMX6NDT50s2qId8fu/Fr0wk7t bxHJQUUuEtKhrIFQ8Eb9z+A6PnRsOF/P2egYGuMAp+HE1YjQQTJ/Iuvb7FdW8F5XVw4M O+Xg== X-Gm-Message-State: AOAM5306TSBCZcG9yyn1U2D6OtCnXQUKfQxts4WiblGqAyP8y3q9yW5z Nexg+W6rdYmaAjb0oTi0TxsbeQq9nnojZOtY5qQ= X-Google-Smtp-Source: ABdhPJxa3fwE1gntWrjljDsvFH6UlsS62TRi8FeltjZ+YAQFTMpawuIEL6cDelrBaNePH9pbfBWO3F+KAs1dSlBCJEY= X-Received: by 2002:a1f:3a4b:: with SMTP id h72mr2286297vka.19.1633598898975; Thu, 07 Oct 2021 02:28:18 -0700 (PDT) MIME-Version: 1.0 References: <20211006025350.a5PczFZP4%akpm@linux-foundation.org> <58fbf2ff-b367-2137-aa77-fcde6c46bbb7@infradead.org> <20211006182052.6ecc17cf@canb.auug.org.au> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 7 Oct 2021 11:28:07 +0200 Message-ID: Subject: Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Stephen Rothwell , Randy Dunlap , Andrew Morton , Mark Brown , Linux FS Devel , Linux Kernel Mailing List , Linux MM , Linux-Next , Michal Hocko , mm-commits@vger.kernel.org, Rob Clark , Sean Paul , linux-arm-msm , freedreno@lists.freedesktop.org, Daniel Vetter , Intel Graphics , DRI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 947ABB000E3E X-Stat-Signature: jj7m4qc8gomfmqk8ddwrk797bqiyusr5 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com X-HE-Tag: 1633598899-170909 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christian, On Wed, Oct 6, 2021 at 9:28 AM Christian K=C3=B6nig wrote: > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap = wrote: > >> on i386: > >> > >> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined ref= erence to `msm_hdmi_phy_8996_cfg' > >> > >> > >> Full randconfig fle is attached. > > This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is > > not and has been exposed by commit > > > > b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > > > > from the drm-misc tree. > > Good point, how about this change: > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index 5879f67bc88c..d9879b011fb0 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -5,7 +5,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > depends on IOMMU_SUPPORT > - depends on (OF && COMMON_CLK) || COMPILE_TEST > + depends on (OF || COMPILE_TEST) && COMMON_CLK I'd make that: - depends on DRM + depends on COMMON_CLK && DRM && IOMMU_SUPPORT depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST - depends on IOMMU_SUPPORT - depends on (OF && COMMON_CLK) || COMPILE_TEST + depends on OF || COMPILE_TEST to keep a better separation between hard and soft dependencies. Note that the "depends on OF || COMPILE_TEST" can even be deleted, as the dependency on ARCH_QCOM || SOC_IMX5 implies OF. > depends on QCOM_OCMEM || QCOM_OCMEM=3Dn > depends on QCOM_LLCC || QCOM_LLCC=3Dn > depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=3Dn > Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds