From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F43E7C4F4 for ; Thu, 5 Oct 2023 08:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C88066B01A8; Thu, 5 Oct 2023 04:11:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C38026B01AB; Thu, 5 Oct 2023 04:11:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00546B01F2; Thu, 5 Oct 2023 04:11:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9DA586B01A8 for ; Thu, 5 Oct 2023 04:11:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 41FEA40113 for ; Thu, 5 Oct 2023 08:11:49 +0000 (UTC) X-FDA: 81310689138.06.EC2159F Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf14.hostedemail.com (Postfix) with ESMTP id 3265F100017 for ; Thu, 5 Oct 2023 08:11:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696493507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ey3mu0cYa/bhtbEBQ1BIB9STmNOx3N6SafWjGpaN/7o=; b=qiAKz5+yjbjnz4+2LsGLMZkDj82sIVyurwHHAeqDP/qaN+J5xqKOQx6vWefGuNRJrZNlyi 0cbaapQ7jDAYPRev8kavkqcRDv2zsGyKlQLkZU+KdOelinGb87KWcr5/q/JXQTX0Z1hX5t RAI6NJfRCEoIn7JpHYMB7sNWMU8fW/8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696493507; a=rsa-sha256; cv=none; b=GQ49YyTQXu1Qb3xRxVO9ngDOdccXvuPTXSUYtOPip4s2yB91D4vXca7wNVNOCzwaolgoUz 61dIIoDptRE/YuoU3hsrh311hT9mTjmxbxY5jKVlNVidZF/gQi/hPTebfgdaFzWOMJYo7W mWv/tyitbjKDZDvz+4O9U8bna+0B5EE= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-d81f079fe73so809631276.3 for ; Thu, 05 Oct 2023 01:11:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696493506; x=1697098306; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ey3mu0cYa/bhtbEBQ1BIB9STmNOx3N6SafWjGpaN/7o=; b=e7CGJJ5Nv6g3r8ZvcjxqZAuaML7LLhtDV06SpVzdxUUwsamns0N7lUsXqRhYNDurfU SQwVkK8TiwrO16cUp7bPEN96Xy5MHQ8Y6IJhY7kcL+j4PKLU+y8uIelOcqZdXdKe7V/J M2vhJE5POHqcYbHnAFx0XCafMfuDVUKea+3zXbrJ5Ujilyqv6nqc/2FCmwMkOUvFKCqF tSE/xb2CagvQKYvNfE01X9+QUhRDIzlgv1jcW+P9XgVVIG75QRWoW/gf7AEzu57kAo2R 8+MCJyv3pi0wqvZEbrxE3JO/cChUL6TKfQOu881DOaTK3B1CZ7pnORjB4x28XgKV+7rr 8r/Q== X-Gm-Message-State: AOJu0YwdC+FCOZsbmOZz7RYzAntRWYHc83mOrWlcLHfjL4xJHB76DJPC H07WAVH3Vs3fD1E1jckIogMvL9jE5QkWjg== X-Google-Smtp-Source: AGHT+IHfjy3Ksp2Huu2fDgBN7NYJTHHK51RUWXiFJAZkwS0EQHEZl/DlimcM78WUpAvS1Ld3QYheGA== X-Received: by 2002:a25:d310:0:b0:d80:9ef:928e with SMTP id e16-20020a25d310000000b00d8009ef928emr4155664ybf.33.1696493506054; Thu, 05 Oct 2023 01:11:46 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id b33-20020a25aea1000000b00d8179f577basm254094ybj.49.2023.10.05.01.11.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 01:11:45 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-59f7f46b326so7218537b3.0 for ; Thu, 05 Oct 2023 01:11:45 -0700 (PDT) X-Received: by 2002:a81:8246:0:b0:58d:f1fe:5954 with SMTP id s67-20020a818246000000b0058df1fe5954mr4952101ywf.32.1696493505212; Thu, 05 Oct 2023 01:11:45 -0700 (PDT) MIME-Version: 1.0 References: <20231004165317.1061855-1-willy@infradead.org> <20231004165317.1061855-10-willy@infradead.org> In-Reply-To: <20231004165317.1061855-10-willy@infradead.org> From: Geert Uytterhoeven Date: Thu, 5 Oct 2023 10:11:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/17] m68k: Implement xor_unlock_is_negative_byte To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, torvalds@linux-foundation.org, npiggin@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3265F100017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sy5n4uc89hq9mik989i9ncnpwtzhmxnj X-HE-Tag: 1696493506-101519 X-HE-Meta: U2FsdGVkX18zlUQsjfvZ5Jqn/An40j5f+bpEakjUL6sSAEALpO8Ctf5gRcqgNBQ12Tm21bfWFxgGsR0ecJHDlT03sFXZW2Jl4+f31dIHtA0goh7vaIXVxEhDG5jHUysk21bgRH6Q8RAnlXzTT86oRpMMf9rCjmVg5pH5hrihuPZk0/r8GbrIMKXh2tFhU94ZXl36Wb8GW9VllKkCnrcYv6WMsDPPSP/EwYqYCCRnRynYRGWQUWzScqkd1t2Gs7fWG/EaCICNHfEDWZBEuV2ybop1pF+P7o6mZ18rwqZ82PpuVL5L8+iuNkL/7orZRvC0MyrYjmpiE/kR1ZD8g+t1HGTfcZAyVnnj9c9cv+XKGlw6Hc6Zqf3Wbr1Xx+iESSiurSy9RD12aMxWTPM0p7KvsQpErsEvCvGxh6nx7VgZvZeWUh4lxng6sYU0Ua/lwlhdgaINEbx3XEDspwvFC/q7joMcPTDoni9RuDBo2CtVfMjKDJf2WolZG0yzNVKviJFw6GlaIGwbez5iM4S5nhshYlOE85A2Yd3OYiMeB5K02M9sUhauRVPpiDYktYha5raGaBK5NIaCsr4StnAD1aEBkfheuI/h8tVHUQZ8iyfVuuTITHeyQLGZ4zOP8eKjbMIARS+ylXfUKQ7DqSBMv4QmUjcZEIsFpZ6RF2Khvq+/7vWUzchwoT3wyNO0f+q+kW8CPm76iZJyZZL8EgsLnSJbA3X7PVWEgU8Wo7l9KupN0nhcvJUAlPrI5wYQLtZ9nL9EjP06juhuHuC5vA7ccjNTMZnzWb4yMtLXNcEPZcBI3vLDJWdN5H5WEvshV3SL2QCIxHPMAKul9SEYTap7p79A+1nSLMjua5zKkQk0/I9XarGLa+9ZRBGtpVJYmxk2nqrMEicvaHkmPslcRrbuQaEMT8X58XT2FCq0hewsMdP/45g7dg8du+cmcCcpeUXcRfxcyM4oOzQkBtkMvrqyQhV LzcLZw53 onq5Y1GoGynZJCAkZn7DcMiy3yzNdvHtNhkxtEkA51Ykn+WyUUh8+NEi78zcPdpjmkMfw4pprBf8rgyGxQSSbtPJxyquIK7YJN8aa2Wr4nU93nHRq/K+l8T7hqngW7qN0acOXcO96oHg77uiTh6o9WtLRBuwwZTE3dsnQWjaOmAqCvPGqdy1nVHgRCZcNC1N/TWTFbEz3W3KmJwedW8B0VeJ8N0qMS7gYtB4+1A5mAY4MO5+1IKmV78/4h/f1wytozELduDhmwZVhpKTcSTMZxzW/tvCs/qpFQ1Y1Qc4BWkxr1PsPwgt0KBTJVVD0LEbwedNkiyeqxwZaWTzspejrnC4+bqgIbTPwqFM5L5Wqz+JqjQunoPKOlAXWnH06bZW8ufoRmu1qEEAhZdzTECcRZsXN0bRUS7ecjJPRyAYviHRru3iZHMmaP+6yUa7WXnFz+d2PINbFvJVhjq6wz6CCvHJbQeFJSCmPJy2Zjn4WO/Beqtu9JrWvRlmipYd+vSQI5Br6dMqgj4aiP+d7IaGeZA7MVQVhC3g5a0jnOXgJS/AdjUm9bHMBh4U7uQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 4, 2023 at 6:53=E2=80=AFPM Matthew Wilcox (Oracle) wrote: > Using EOR to clear the guaranteed-to-be-set lock bit will test the > negative flag just like the x86 implementation. This should be > more efficient than the generic implementation in filemap.c. It > would be better if m68k had __GCC_ASM_FLAG_OUTPUTS__. > > Coldfire doesn't have a byte-sized EOR, so we test bit 7 after the > EOR, which is a second memory access, but it's slightly better than > the current C code. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds