From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782EDC76196 for ; Thu, 6 Apr 2023 12:11:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D63076B0071; Thu, 6 Apr 2023 08:11:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D13256B0074; Thu, 6 Apr 2023 08:11:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDA6B6B007B; Thu, 6 Apr 2023 08:11:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA3D16B0071 for ; Thu, 6 Apr 2023 08:11:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7F2E0C1215 for ; Thu, 6 Apr 2023 12:11:01 +0000 (UTC) X-FDA: 80650850322.10.9009C6E Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf23.hostedemail.com (Postfix) with ESMTP id 9BB0F140002 for ; Thu, 6 Apr 2023 12:10:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680783058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ck5MlPzpVYxy8IU0ivZGLSHLjTz+SenFqhG42tF0DZ0=; b=3WAcJjp7FRU4qIF8MDi54Lpz8DyltaqORUgbapmH1UhRt0v00pbaJ/ztS9AbvNdeVOp1qD ZbvKZEFpw8QTnGCYvHBSdwf76vFFnAvtysOIXF0DSr17wxON5FoDn3shU/fRGhjMNCOe46 uJYFO4hfSg6M13rB4BaOBngooDtN9gM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680783058; a=rsa-sha256; cv=none; b=i+y8tEs9QvaUMX8xKeV48k1ejKO8hlmZnthUM7tmBVdGioXEJHek8NG+N2BusO0FT3vLbd /ReOLcma76FRuNUz0+bhHYKrTV4mjXcquWrpEE0MP1zLmf9Q6gP4BQo49W/jY3iDHlaDZ5 cF9bAnJKlnMr1thbaSpZ9BYjUDnsPpo= Received: by mail-yb1-f175.google.com with SMTP id n125so45825815ybg.7 for ; Thu, 06 Apr 2023 05:10:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680783057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ck5MlPzpVYxy8IU0ivZGLSHLjTz+SenFqhG42tF0DZ0=; b=10pZFOZrIT1DG5V30Xo7UFoauZlxDkzYWS5PBmKz/wxG49OlWkeSlF50pkfoC0Yxvu VnVkw3DfKq7v8s2U2CZF88orVMOGbjFXUeKa16kfcHIDQuDdX6+hQwxiIr9ylBu2plRC 0Nm0UVCGslcGUHyAc9OhrRd+oo3SpqfvTeB8rt6420Uhgiotyyrv11SaTN1V8qFweLBG jfjQERMqiJV8j5k/dxYdJX5OVNRz8Qh41jvj9O78f/EuUuo7NIFdZVW+ZR8Acthz5a3+ 0vFmCOlbtxZ57IPP/KuirJupB0lZAsnE0mnZmuTOGKyTQcp86QWPPtKJS/MhGZXE/gtf IcFg== X-Gm-Message-State: AAQBX9f4l4zoZV3XFhQCKKynutNYgO1VokpvgUzco4WzoiKKgd7uBnr6 hswefzgjyewWe2XYvuOtfFe0dI2VmoGwyw== X-Google-Smtp-Source: AKy350btwh5EJoEuqoI+53CGNbQCAcmnutia5x3AlPUW84wnCcp82AkJH2HkQKNq7tWb53efSQibQw== X-Received: by 2002:a25:494:0:b0:8b5:2f7e:c81 with SMTP id 142-20020a250494000000b008b52f7e0c81mr1950071ybe.29.1680783057656; Thu, 06 Apr 2023 05:10:57 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id b84-20020a256757000000b00b7767ca747fsm381293ybc.28.2023.04.06.05.10.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 05:10:56 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-54c0c86a436so35192477b3.6 for ; Thu, 06 Apr 2023 05:10:56 -0700 (PDT) X-Received: by 2002:a81:a707:0:b0:544:4008:baa1 with SMTP id e7-20020a81a707000000b005444008baa1mr5540717ywh.4.1680783056332; Thu, 06 Apr 2023 05:10:56 -0700 (PDT) MIME-Version: 1.0 References: <20230405-sunhme-includes-fix-v1-1-bf17cc5de20d@kernel.org> <082e6ff7-6799-fa80-81e2-6f8092f8bb51@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 6 Apr 2023 14:10:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next] net: sunhme: move asm includes to below linux includes To: Matthew Wilcox Cc: Sean Anderson , Simon Horman , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , kernel test robot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Memory Management List , linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9BB0F140002 X-Rspam-User: X-Stat-Signature: 36okx7cqdx59f9ytqq4zoonpbw16teae X-HE-Tag: 1680783058-755058 X-HE-Meta: U2FsdGVkX1+j/8YayoE03lVWJzILk7r0XuzUr9kD1FkA/Yj93Rv6kxvEXX93UqIWWWhKa4cIEXCI2ED0v9oDezmZ70EIeKT9INGD0tPxjxz2WB9x0Zv3lriOPRRu6pvH2vzYdAWs47IkwYdVjMKRuBZAy0TCczO+DEvqmf4N9L2tVyaWZC8G/lqpvZ2jqLbeRSWZ0uL4uy+avzegN8D94Qa22FrQ9h48FvYzNk7FKus2ptmwhH8S3GI6Gq6Qe7VJZInAJ/yX0FT/qzgI182m+VQm8QIbJWePB7XQHHS1cvwzRUNNpnukwawtXmnzLqIaX60ue/W3xBeEqxMSqpA2qIrS3l6tEyroMPiVum+vfFZnZgWl+phqqTq4kLE0vj4Keg+MUEkMPDExqgk0vsLmrw7innv4nWFe8FSI4887VlUNn/wAUDA1i+FXtldtXpG/c0Bx/HZL1iHoh8IvrBGTVoLNCE5NrW8P0m+u4Q2DMNpD95WUDB/4CgRtEaEey1I74049Z2r3MHltKcc3aUsnSZl/3KO/i184yCxcAO2uCExtj9vdFoZ/7p0h7Ij3yXWaQMMjgpZKygaTeshZjAwUEsVmZHLcAPbKTiyg2HY8Gh/L0FSpUmpyMJ6KF37xDQFxN20pLhaDcJhzoPQqLKSuxPZPByXbI67auhdC24gYjsfaS56/8G3Od9t0XbULaZbbETKM/cVYsa6wB0npGTBLdiUmm2ci18I7pjC6OVyKakcZhsrvM6xstf5hri9ig9nTyD1Yz/9UsXAhrHtHPlml1R6tT2PuFj8aGPx4Xs6wxpWr1acjOv6rcorUkD6w4/BLnZgt9psokwwg0Nm+u+eSJU/ETS/KPI/FYgyAkYk2z7AZ+6v0kbZNDPGzw1C2nmOmGDU7QtcqGb3z20OYcjtruWmHEFNFR0EvDJYWLbZT/31oDwynacx27j/wYFp90Dc29hZVEqf13DAwQC+RcR9 w78T/VhM k7w3hsG/gk3TYfy9wET35HdByoynx4ndZA+dS4ceBg0vSLm8Esp6yJ6yFu8VZdE6cwyXWQ9m1Tt1bYKPmqCzDpizrFSVJ9+M0wshxL7j2F2DIX/L1M4ux1HpF+5YEWUJuJNsbF9sb7XTC3ypFaUM6GIO43sB9xnUP2H+7yAzZQ4EGEAHTLkvLwHAzj4uek7xKcbYOW5SqrwR16RPPi38BD5hBrWmz2UWSNPTnoZl/xxpO1eHjHrGnnksYxB7UZk7O7MaZxYR4zFnxzwnvFrvTzokv1tNMxCyYUDt1AQfGSunOdimzVQpVHEVM+QUl5QKn7OAJf+2eO5vSN+THB0psp+cbamrhxM+jsCQeH7GBepHADjREuHm87On1vmMRboV8krHj80SOYGD0M5PtkhbmOY7pm4gPMovi3AnBdMvwQhP64l4lqEySl5zZCfMFeq56ts3MbVn+HZs83UrQA7d8BCZTYMDU5xw3raWKDMNn3gtNZL/TUknmERsXEN6zY1kqFlqIo3H0B6MG4AkjS0E+RVndbM5KLy7M0flq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Willy, On Wed, Apr 5, 2023 at 8:34=E2=80=AFPM Matthew Wilcox = wrote: > On Wed, Apr 05, 2023 at 02:09:55PM -0400, Sean Anderson wrote: > > On 4/5/23 14:07, Matthew Wilcox wrote: > > > We always include linux/* headers before asm/*. The "sorting" of > > > headers in this way was inappropriate. > > > > Is this written down anywhere? I couldn't find it in Documentation/proc= ess... > > Feel free to send a patch. Generally, it should be: > > #include > #include > > #include > #include > > #include "local.h" > > Some drivers do this a different way with a single local.h that includes > all necessary includes. > > Also if and both exist, you should include > (which almost certainly includes ) Indeed. Usually should not be included directly, except for a few exceptions like . Witness e.g. the (violated a lot) comment at the top of include/linux/irq.h= : /* * Please do not include this file in generic code. There is currently * no requirement for any architecture to implement anything held * within this file. * * Thanks. --rmk */ Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds