From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131])
	by kanga.kvack.org (Postfix) with SMTP id 207116B0037
	for <linux-mm@kvack.org>; Sat, 16 Mar 2013 13:37:25 -0400 (EDT)
Received: by mail-ie0-f171.google.com with SMTP id 10so5607202ied.2
        for <linux-mm@kvack.org>; Sat, 16 Mar 2013 10:37:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1363453413-8139-2-git-send-email-jiang.liu@huawei.com>
References: <1363453413-8139-1-git-send-email-jiang.liu@huawei.com>
	<1363453413-8139-2-git-send-email-jiang.liu@huawei.com>
Date: Sat, 16 Mar 2013 18:37:24 +0100
Message-ID: <CAMuHMdUbg67zLqn7x_vpzEWpbuwjmxO5MYRNJQhxMpqtLxTVOg@mail.gmail.com>
Subject: Re: [PATCH v2, part3 01/12] mm: enhance free_reserved_area() to
 support poisoning memory with zero
From: Geert Uytterhoeven <geert@linux-m68k.org>
Content-Type: text/plain; charset=UTF-8
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Jiang Liu <liuj97@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, David Rientjes <rientjes@google.com>, Jiang Liu <jiang.liu@huawei.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org

On Sat, Mar 16, 2013 at 6:03 PM, Jiang Liu <liuj97@gmail.com> wrote:
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5130,13 +5130,13 @@ unsigned long free_reserved_area(unsigned long start, unsigned long end,
>         pos = start = PAGE_ALIGN(start);
>         end &= PAGE_MASK;
>         for (pages = 0; pos < end; pos += PAGE_SIZE, pages++) {
> -               if (poison)
> +               if ((unsigned int)poison <= 0xFF)

"if (poison >= 0)"? No cast needed.

>                         memset((void *)pos, poison, PAGE_SIZE);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>