From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F47C6FD1D for ; Wed, 15 Mar 2023 07:44:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56F36B0072; Wed, 15 Mar 2023 03:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E07F86B0074; Wed, 15 Mar 2023 03:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA9EA6B0075; Wed, 15 Mar 2023 03:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B840C6B0072 for ; Wed, 15 Mar 2023 03:44:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94004AB262 for ; Wed, 15 Mar 2023 07:44:00 +0000 (UTC) X-FDA: 80570343840.06.F34300F Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf30.hostedemail.com (Postfix) with ESMTP id 9C0828000A for ; Wed, 15 Mar 2023 07:43:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678866238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irw1UVNowl4JF0FKbWda8y5x3cm6gsUP6fVPn73ScMA=; b=APj2bmhl4r0yG4YXgbOqYH7qTqTBm7Pmka0yL+YVRytFxEUnQTapfI5YbebrwV/x7N+Uzf 4WyaKPGHsAdh3qyeyV5QKuP21OJrsKubCvMJ5kX+Rv6kEMSnufdGrdx3H3NnSw/T+jObNf J7LW+HtyiMWCzPrPgKLcucJR+KkLTYs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678866238; a=rsa-sha256; cv=none; b=GSbiEcZGrq9/9bHd69fr+G7LOF/SeQyRhgaZ+Ab/55cDbtXbjKJXtwgu9u7do+d1ZMf2bX 534S3GKGRzDAmnlZBH18yZgB3A4C2b/a3TyBHNLkC1B5S67+DGbI2llgX3cprhV6PP8Gcz vcTQuEL8Oxa29CitZraG48APGdPCyiE= Received: by mail-qv1-f51.google.com with SMTP id nf5so15288000qvb.5 for ; Wed, 15 Mar 2023 00:43:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678866237; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=irw1UVNowl4JF0FKbWda8y5x3cm6gsUP6fVPn73ScMA=; b=fwqU5zeEI6oDvGICfJoQWSmdol9fx/SZZ7O9yTzE2KVjZ9ffw1dNH6FWg12Imk5TNg rZH+uTHCkTDhBDe/asb9c5UQnlQqKyo9uORJMMPnLwvSQv+OdoJgo+uI6q3dfUZvULAs wRye6IgrRlqinBrm2TKZMvq7uwJyJKzny5mrF85+SolMIFM4E3EfjL1B0j6KNsYoR4WX i6/f4p/MZ4QLomRFiUqL3rZM8K7/ahf7oVCE84j63HEXfCQh7JVk6L0neBoBElNf87RJ YZcOO+H7WR3ZRIqawTjTQzdEPaVXn/er3V9aZIvE3GG11UkfVMPdpP0d8jBdqOrMJJRS txZg== X-Gm-Message-State: AO0yUKVuPKTMjhGan9uQqM+s87FOvOW4Sn8YZ9Q06xjSRUj6ye6UcP9t zpQUNPnZclCgY7sMV+Ta+FYSzpeNA7/l1trV X-Google-Smtp-Source: AK7set8TPnqWK9IV6rSgEi5zasieuUzRiS4LsuJz7N0b6ydqMSDYChNDp8Tz6dOvWIMpPCyOjMkjsQ== X-Received: by 2002:ac8:7d4c:0:b0:3bf:a5e2:79af with SMTP id h12-20020ac87d4c000000b003bfa5e279afmr69730668qtb.37.1678866237461; Wed, 15 Mar 2023 00:43:57 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id i4-20020a05620a248400b00745ba217187sm3354499qkn.3.2023.03.15.00.43.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 00:43:57 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id y5so1988092ybu.3 for ; Wed, 15 Mar 2023 00:43:56 -0700 (PDT) X-Received: by 2002:a05:6902:188:b0:a99:de9d:d504 with SMTP id t8-20020a056902018800b00a99de9dd504mr25136921ybh.12.1678866236647; Wed, 15 Mar 2023 00:43:56 -0700 (PDT) MIME-Version: 1.0 References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-15-willy@infradead.org> In-Reply-To: <20230315051444.3229621-15-willy@infradead.org> From: Geert Uytterhoeven Date: Wed, 15 Mar 2023 08:43:44 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 14/36] m68k: Implement the new page table range API To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9C0828000A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 76xqawwiaupohffrc8497mndhndrdxy9 X-HE-Tag: 1678866238-197927 X-HE-Meta: U2FsdGVkX19ZpNci979KAlJCturIgwZeqEYP/4Q9tsX0K8MnQ6hvhkS6df8SdEWuxpil1waCFU2lSrGhQKTv+t5TBTf+1bjBo1oDULQyYrBYGYn3ZDKGo5y0uyf1kDunF73VQFDi8XoWtL1rhyFhMkiA5Y6V/kBzCfMmnybYqApZJ13ErJlWerJzOcXk+zXuHUI0/9x0KIdyw1a5bb4Eempi97DRiAHEBNpCXi+OlAxmAudmEPWEgrzzdWh2+TBYHjvAWUvKyjrEWhcuN7BZmJLY+UgZaaaJxlnSetJ5Pb+K0r/BYdCvoUKU+ygO3SuMvuZHa+SO1zakzsTJuSeZPYoJWH28/03Zj/ORGEcQ5akbesnpMNb2rWLucWRkIIMSw2854bhnZSg95/IF8Y+caQhZ0Lqw6u8MnDf+SOhCiMpOpaIhAFILp03q2TrLWZmWMAiwMmsy45zSXhl14SnXOknm1u3BLCjm/fJscQ2/Gwf8VXluioJnLvYk82iHg2FYOfmARu1ducp1jWBBQ4nZqkuuQFf3+sIJUCqruCuQcjkOcEJMm2taswHxpe9BlSlY0a9UbIDD997OVXDFFUNgxZFDOuCCbXme0xwSb4iUoRrvY/VwPcQEztOjuYZE0MSWa4YUUeCir4j4NoPoEKHHkeJAhzi0eLFQyOThfPaZdrUfuH2AsG7EGmSI2ixDt3lg/47Tx/0yXHWdW+ZoK8hGM+9rO/RTV2tODJAHWlgi4byPGFHeWNhcOxCgC/jXrYbTRX8Lf+3EdWFR+uZUV3z1G+Psp/GbgAFzoHayBM6Hudts0k+TpZ8tw+bLzZO/M4yxuHXktcu52Kqd8V7JaJ3O8FKN/QC64UilOKcP7Xd4f79NE90NdrJWldL6boPCSaEvcS5JpoMnl0arCvbwXfq/PrpmanNUFcrLB8EpNmMmlZiICRL2u5hDIdQrvfkXrDpRmAD5mWylFSun3Np6zPy sBIWsv4q OKeOpEnGHx/hANxspQ6IpjrdjMNyvldV9WJ3QULw+3pWo4PQ4UF77WTLNW5B2ldICl6WAi/DfnqqFQolMBuGhopBemoyEj6yN62HITbDCgZX+ShTBzML2yQJMR+0KWDnv+TaB8WB0tNXLACL1uHmogVIOCPzcY40RBdnY9+mMEUbh3EdsiZBXyi75gGstld3EKYeHmVMAn2CbEg8PQelw5Qygiq8MdB2MtKLJxHWumzifmzROq66RVGsIkBSiS7T9rVVQTLp2hHKvBr3Pf5HSmMkq1wozYG/hP9sqmUsJ+rA6s6HE/Qdq/sbtBQwYcs+3QDL+Jk5yj9yDI/kOVU91Oc8B550RGI9hoorswqxK45dSR5Bep4o6mkx9oXq8oQR1aSfBuoEWBSrJEWiD/AUsCYa+lmGv+wzso77S3zfzapWCg2KRO+x7u/wSf0xzv5FeeMfVpamSfL6Y9gYQH6iGWh3gVGIBD6f8E/iUK7AGjMEnJG4QEfEVeWfOttEWheqeNxoLIGzT7j5zOcnO+ugz+cg6zQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Willy, On Wed, Mar 15, 2023 at 6:14=E2=80=AFAM Matthew Wilcox (Oracle) wrote: > Add PFN_PTE_SHIFT, update_mmu_cache_range(), flush_icache_pages() and > flush_dcache_folio(). > > Signed-off-by: Matthew Wilcox (Oracle) Thanks for your patch! > --- a/arch/m68k/include/asm/cacheflush_mm.h > +++ b/arch/m68k/include/asm/cacheflush_mm.h > @@ -220,24 +220,29 @@ static inline void flush_cache_page(struct vm_area_= struct *vma, unsigned long vm > > /* Push the page at kernel virtual address and clear the icache */ > /* RZ: use cpush %bc instead of cpush %dc, cinv %ic */ > -static inline void __flush_page_to_ram(void *vaddr) > +static inline void __flush_pages_to_ram(void *vaddr, unsigned int nr) > { > if (CPU_IS_COLDFIRE) { > unsigned long addr, start, end; > addr =3D ((unsigned long) vaddr) & ~(PAGE_SIZE - 1); > start =3D addr & ICACHE_SET_MASK; > - end =3D (addr + PAGE_SIZE - 1) & ICACHE_SET_MASK; > + end =3D (addr + nr * PAGE_SIZE - 1) & ICACHE_SET_MASK; > if (start > end) { > flush_cf_bcache(0, end); > end =3D ICACHE_MAX_ADDR; > } > flush_cf_bcache(start, end); > } else if (CPU_IS_040_OR_060) { > - __asm__ __volatile__("nop\n\t" > - ".chip 68040\n\t" > - "cpushp %%bc,(%0)\n\t" > - ".chip 68k" > - : : "a" (__pa(vaddr))); > + unsigned long paddr =3D __pa(vaddr); > + > + do { > + __asm__ __volatile__("nop\n\t" > + ".chip 68040\n\t" > + "cpushp %%bc,(%0)\n\t" > + ".chip 68k" > + : : "a" (paddr)); > + paddr +=3D PAGE_SIZE; > + } while (--nr); Please use "while (nr--) { ... }", to protect against anyone ever calling this with nr =3D=3D 0. The rest LGTM, I'll give it a try shortly... Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds