From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A20C6FD1D for ; Tue, 21 Mar 2023 08:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 293B06B0075; Tue, 21 Mar 2023 04:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21BA96B0078; Tue, 21 Mar 2023 04:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E5A86B007B; Tue, 21 Mar 2023 04:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ECF406B0075 for ; Tue, 21 Mar 2023 04:50:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BA41DAC0BA for ; Tue, 21 Mar 2023 08:50:18 +0000 (UTC) X-FDA: 80592283716.08.0B73C0C Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf21.hostedemail.com (Postfix) with ESMTP id D25AB1C000C for ; Tue, 21 Mar 2023 08:50:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679388616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f3c3sA3MMjESnwXk4E5cN5peA4kX2fpUwWLFzglk4UI=; b=jxfz2zuDYpDM9WVW3RKABPGLDp7z5A4uv+zCGlwrLq5SppGqju0Tyijj1Ifw5rMNEZLX91 OG+I3a8vWrk1WdgF9MhjnyoN4aokl/WbCSJsWfiSZi7Lw/GgB+Rd8SvsR3UKCyDhsTICI3 Jo1GJ0flUSFnEW4u7ut17bNBkZW/uC8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679388616; a=rsa-sha256; cv=none; b=wxHCOuRCKGXDyHp4kJ7dXm82SafVqy6gI7HUqEX+QWA1TGnGwPaNZMnSW+KPmRGptN1jQ6 aElMDlu3z07vdUPnxz4ap/GezGuKg6MP5aT2utFje34+o5W5+HPjc/9RBmFqjIab33U6/U BaFu5EQmaHdaLao4cQDUAwI0efbLrlM= Received: by mail-qt1-f176.google.com with SMTP id c19so16974266qtn.13 for ; Tue, 21 Mar 2023 01:50:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679388615; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f3c3sA3MMjESnwXk4E5cN5peA4kX2fpUwWLFzglk4UI=; b=XRESuDuTXmWk70CscQ0xNLKs4wAtW0vc9ylGd1Mi5bCzKzo6Qh0MNeNpvPSuLHtWy1 4kZODBDd4Qn/qmDspagba8Y9dHbtWyzzXWyws5NMhBKu47jCPgOFUX5eWvb3EdmrH0AF ler6SUkFymWyR/B2Qzcj8lKOwzgbmuKWH3+F/O3VD0JeC21rSve6tuPzxXfd7LdgId91 u+XL/EFDV3Ucj9qFy13rl6zVl8NGsjnpUo5i37falYdTG0UY5jVvB8JJ5kIbHUs4k6kF 0XWOe+Ch1qMbQ2vOrqdx4iNcc42h9uAHrCmvxxmt3qHnKqKNCQ6zSK0AADHP9QIn5aao /bZw== X-Gm-Message-State: AO0yUKWggyEiI2FzjTD2/FvA0k9b330yc+9UrUV+jJmKx6kIWSg85DCp r+bPRSYE5a/6fIBwYk7ktd3bcnJy+4NZBQ== X-Google-Smtp-Source: AK7set8EWiFD1k0a/SpIKLeav9JMSxNjtXOAnldVR40/qrW9QMx74ADWNe7NsZtATUGojVNmbi5lRQ== X-Received: by 2002:a05:622a:1052:b0:3dd:bd34:3cd8 with SMTP id f18-20020a05622a105200b003ddbd343cd8mr3044990qte.24.1679388615404; Tue, 21 Mar 2023 01:50:15 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id 4-20020a05620a048400b007468bf8362esm3123807qkr.66.2023.03.21.01.50.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 01:50:15 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-53d277c1834so268245237b3.10 for ; Tue, 21 Mar 2023 01:50:14 -0700 (PDT) X-Received: by 2002:a81:ac0d:0:b0:545:45f4:2e50 with SMTP id k13-20020a81ac0d000000b0054545f42e50mr602754ywh.4.1679388614423; Tue, 21 Mar 2023 01:50:14 -0700 (PDT) MIME-Version: 1.0 References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 21 Mar 2023 09:50:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP To: John Paul Adrian Glaubitz Cc: Dave Hansen , Arnd Bergmann , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D25AB1C000C X-Stat-Signature: xoq97nj1bg6yjz7x4w5w1xyj88r4kn5x X-HE-Tag: 1679388616-859380 X-HE-Meta: U2FsdGVkX1/h7KRFlbRwU7ydVh6PbCBj2Vu9Y67uPk/edxq21glG0dL4Xf/6GZ26a/lhZXxvUpZJJc1aik5gUMrl/6cLbEMuM8h2LNDzhNiWfAD3QXjNogDL3Dy9dE5g/LRLKKGCM2ViVrb6Hp9vUIUVpAdku7GIn/Br6kHjPHgOhWqP5l4vhap43R3K57Bx9IJcQqamsmjlnttH11gSaC9FLAr12Hto/YbAAW4cKnvp1pIZt2VgoeNjzOOEP4rrfucxSpcOanAHFSiAhymO06wpZnfmfImRAJvk2he0ycxHktOlJxGO9ig0DLJr0uD6lSc+sDld+nH3fH9fr1DEWNvFnxZwT5Jo0op/h+0stAZ5oK8Q5afCizzYK4OJuOR/AdE3ZlpMMXGiTkdy8MHCoxMhVRXwm6Wb2ehsYFeGPSqZuU01hqEo9UyyaFxV3gxHFUwbkweuBzPtm2f0dylYnwFfOF3Tz7AxXuNOrhTUkzLq/8NHaBzM4Gnr8DqvwYhTeILSWnCbbmfiutficmjkBK5Oot8ioQ81XzCVy0pa587VEdGxwv2fXyPZgyyCjCHhjjfLwoV3uP8p5YlLDW7Lo5TDxl7xFKsslkNhfsrmyGzkzUUsDQX30CE3hIB+Fihd96q1w0THNp5hSLt4EMG8oqFAV1cH33nJZKp9nEwhFCJ1W+oEZMTWYlOSe6bwHeQ9Btc6ernrGW7tG2Qr/y6qWq5WUunymfIBQPYdb2hwRbe6X6bYcqww39dQ37gYdah5t3Vc4ohuLgbLXGhjC9wy/hpXcvirqGy+G3NRIxPxk3urzQnl8OxZaSVp1iHII3zeTAD6jHIfwaDcG2STAf8Vc0qzp0kjHEaPSYfr7XjZnkTAhOG7Q5/4wsKfoizrYnnz93IyXi9HWLOSu6CrkCrJWQpPDZqgglb4WgaPF9gEF72bnppbJwfSzPPZTlb3zusJ8+fKV6UVN5k46s1Fp0W UKqQRgYg vjA6IO7oErTr20U+Ydtkh5lk11P5ySnFLLITb3b8UrX87gWbP51E7o6+I9mpRtiw43pf+uupStDv3KpOhutkyEecVUtVWS6nDftv8HhJdE9Tb58Qx8m+2Mo10alVVRam/Z9pUji9GzCkxRPUuECh1KDd4L+4ABNeJmX/P7AmIJyRtCjuFX1nXotdOWX0bAptXyDNnWQRzJozJsENWU8nU4ocG2nInc0v5NB14FEzEkpf4625LmPVLQcAjIUBAXwEJGTFg1XykzqoxodYRCYTB+uOQXBXHoeL736nH+aLN2/RTGn6f42fiM0MxbaFwrkg6yO80bzJBnYvKpZJosNZAYtvzEeZHH3WnJBLcuLdmNI7nHDO0qPiG54MLN5WldC3efR/Z2IPW1hNHCCzVxQdnCI40eafuOVON89xH7JwNyy8HoOgbbjHx/wLSZRF8wDZAehkCJfzJzieZCKnfgJuo94beuEK6jT2NizBGXPmBLOTNwJFu0L/11IuEqjNj7o/estXr29Qrgt75UACnVnyUKBontgzN+JeiRpnocs/yvWMdtF6VcIlrGbs1TJxAb505WWrs5zkv7/sy7m3Oufkg7hTo9jy/bYfToQ/7vv3ORuaij1xXlJxj57Jsv+ac7HIFBUmT9Lc4it03fTDqAHWoCs4c48W8dGA4HxJxK3SfXTenyoWtQ1TDGpxqwZNKWbuSRUZezZR97nDwjeD5+xRPE5fzA0AQ+Z/QA0VpOkNujE/h9uwf4qvP06bCtVIi5gwBBPJ0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Adrian, On Tue, Mar 21, 2023 at 9:47=E2=80=AFAM John Paul Adrian Glaubitz wrote: > On Tue, 2023-03-21 at 09:30 +0100, Geert Uytterhoeven wrote: > > sh/migor_defconfig: > > > > mm/slab.c: In function =E2=80=98slab_memory_callback=E2=80=99: > > mm/slab.c:1127:23: error: implicit declaration of function =E2=80= =98init_cache_node_node=E2=80=99; did you mean =E2=80=98drain_cache_node_no= de=E2=80=99? [-Werror=3Dimplicit-function-declaration] > > 1127 | ret =3D init_cache_node_node(nid); > > | ^~~~~~~~~~~~~~~~~~~~ > > | drain_cache_node_node > > > > The #ifdef condition protecting the definition of init_cache_node_node(= ) > > no longer matches the conditions protecting the (multiple) users. > > > > Fix this by syncing the conditions. > > > > Fixes: 76af6a054da40553 ("mm/migrate: add CPU hotplug to demotion #ifde= f") > > Reported-by: Randy Dunlap > > Link: https://lore.kernel.org/r/b5bdea22-ed2f-3187-6efe-0c72330270a4@in= fradead.org > > Signed-off-by: Geert Uytterhoeven > > --- > > mm/slab.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/slab.c b/mm/slab.c > > index ba454246ee13dd4d..de1523a78f2e7367 100644 > > --- a/mm/slab.c > > +++ b/mm/slab.c > > @@ -839,7 +839,7 @@ static int init_cache_node(struct kmem_cache *cache= p, int node, gfp_t gfp) > > return 0; > > } > > > > -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || define= d(CONFIG_SMP) > > +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP) > > /* > > * Allocates and initializes node for a node on each slab cache, used = for > > * either memory or cpu hotplug. If memory is being hot-added, the km= em_cache_node > > FWIW, the other #ifdef starting at drain_cache_node_node() closes with "#= endif /* CONFIG_NUMA */", > while this #ifdef just ends with "#endif". Just in case you want to make = this consistent. I guess that's fine, as init_cache_node_node() is a small function. #endif comments are typically used when the start and end markers do not fit on your (80x25 ;-) screen. > Reviewed-by: John Paul Adrian Glaubitz Thanks! Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds