From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595B2C678D4 for ; Mon, 6 Mar 2023 07:22:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66F5C6B0072; Mon, 6 Mar 2023 02:22:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6202B6B0073; Mon, 6 Mar 2023 02:22:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E771280001; Mon, 6 Mar 2023 02:22:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 415706B0072 for ; Mon, 6 Mar 2023 02:22:00 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12B5F120AA0 for ; Mon, 6 Mar 2023 07:22:00 +0000 (UTC) X-FDA: 80537629200.11.0351D05 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 1358D140003 for ; Mon, 6 Mar 2023 07:21:57 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678087318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KF4/rhYJLCb1V3udoZ6HDdLYb1astmKZTSpEt1KMS3k=; b=x3AxHkW1IwJiXrDNKxbSsOffmhG6eGS2qFyXTRuNMplk5f6kaXq7iIpd1I66SAMQmghfBv LUOswdZ7OoX9eewMec+lBJr6dqN06PC1UvWULuwy3OF0MDCXumtdU11lNigWDxxCx9bHfr q9zvU2XvOoQqTfjYMVgSAnBmZPz2bNw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678087318; a=rsa-sha256; cv=none; b=CTKwNilQw/QwJR+6vbHJfifQk25YxraX05eLA84JN9B46rFIm2OiLnvl7IqDBtgaGaJ4RI MScc4ybtpvDteJvCvJyvvsrehLUwCMBkOHi7HMD0GqZLBza3X2m1xOeHRBodTL7Pa3shB3 snJFRZAkm06tBWJdzneeo0kzys6io84= Received: by mail-qt1-f174.google.com with SMTP id c19so9523946qtn.13 for ; Sun, 05 Mar 2023 23:21:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678087317; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KF4/rhYJLCb1V3udoZ6HDdLYb1astmKZTSpEt1KMS3k=; b=AWA3xg/IzFA0cCc44IEUPubtu07XAKhLTYwSI2J0vHd31boXpF4gZPUOZKuRCekeks XXFnJ8+0vViLAKYotUm1ANhFnA4rU4VG5c+lo89P7/uHUxTJ4nLFv2OBoR9yvO5VLHS6 eBW02j33vHHgXoinsIY7R76cOlBGiW9/a0oOFxHu/uVo1VNqERphxhnrFh6YUdD26SaA wH7tIe9wpa42/awLJGYLbtZ/T+w/7nsn5tSNBV8AJY8A8Shyvq1/mxjyRpdAToQQw1f+ JK5xwxJ9rEqR86ru6MZ152AKdQw/nVO+ToNtQptCxwfhu2mRfy/L5E/uxfNPjz7hONtx 96bA== X-Gm-Message-State: AO0yUKWB7/cNMRx4C+iw3xWnyJLn3zi7g0yhrmCVP3/QjYDU5gLE2NRA WoTXe2rs45Ur8Tsnmt2sQ4wxSbGYsC3Mww== X-Google-Smtp-Source: AK7set8BxeXxc82yKLgqzhgkdzLlPB2jiXZqJ0kL5f+J59RAGUHkvnA8eXeX1QDZ+96hKNHsrO3JBw== X-Received: by 2002:a05:622a:284:b0:3bf:cf9d:ccbd with SMTP id z4-20020a05622a028400b003bfcf9dccbdmr14378306qtw.2.1678087316948; Sun, 05 Mar 2023 23:21:56 -0800 (PST) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com. [209.85.219.178]) by smtp.gmail.com with ESMTPSA id q25-20020a37f719000000b007343fceee5fsm6934109qkj.8.2023.03.05.23.21.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 23:21:56 -0800 (PST) Received: by mail-yb1-f178.google.com with SMTP id y144so7104164yby.12 for ; Sun, 05 Mar 2023 23:21:56 -0800 (PST) X-Received: by 2002:a5b:308:0:b0:90d:af77:9ca6 with SMTP id j8-20020a5b0308000000b0090daf779ca6mr5841580ybp.7.1678087316135; Sun, 05 Mar 2023 23:21:56 -0800 (PST) MIME-Version: 1.0 References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-14-willy@infradead.org> <0b00a30e-cb7f-d42b-7d16-0ae8d50ed916@gmail.com> In-Reply-To: <0b00a30e-cb7f-d42b-7d16-0ae8d50ed916@gmail.com> From: Geert Uytterhoeven Date: Mon, 6 Mar 2023 08:21:44 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 13/34] m68k: Implement the new page table range API To: Michael Schmitz Cc: Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: n5hf8c7wcu8rcxcb77dj59usm4wrecbb X-Rspamd-Queue-Id: 1358D140003 X-HE-Tag: 1678087317-979891 X-HE-Meta: U2FsdGVkX19MKz2o/U905I6bV9hQHgazZeHNJEI2f8R7HJCSa5Ej4coava9PsgONukVNGchU75NRCySknAFOq9/YOX/MdMW8kdMEsbr+NwAmqR6U03AWcH+zIX6wBIOjYKlv8iRZYtf+r0wvoHoIeV//TB/Vc81rVS/8w+1CO9OCtPIrRI2dbpeIHGrV11SY1KPUhNmImFZwhXgKVQ4G3xXAgOs+lugtYkpsYPyij11BCYl1qkMSKlS3GDket3Pk8OAm/T2/oUVDIQIHuaGvwEniBv6bzs9H/E9536LKFA81TE0MjfNuB6tt6Ob8tGFIsH5xlePzD2sObpTjlMPF/M/LDinZFuSlcv4zDjdUeFSpYl6pKvQjs+aD9LmecA3ORLzKMIP8k3fZZVUQo55P6NbK8esLvTvYxoGH4jy2sV4NCMupv+kYPEEdQSBLHZ3/b/bISXCjSNV7GOSXdpjLOsCapRsm5uUZJx3p0WmiqCXz6upTwl0YXxwsC1G1XmGjI6JmQOuKDjVRE8l/2XMHW7ESpJEpNUle/IV670vE7t7ihTFiqL+PjQEamSPQv4akHEBmsU4eN7LMNs3MIuVuvmhqLVAAbo4/uI4Lq+nB+5NSap9H0dhFZY9PbJsemn9v9XenH/A040sW2nATABjx0MT14hAt16WlaagiuP9XL6r/D8sfmB2NAlpan9YhK0HQzgRI8C4YiWH6I/xgGO2ywcl1yhHzu2bOdiaQAj3Yy02dM7lCbiMFYi+8OkbSi/tz33YO7vz9J2nELlFMOt/9ValdSDkNNndlJTo9zQT+2Dpa1UWHTa7OiZZUf0n9j/i+GZxxR++cRjGTwilqUe84b+k1jOM1e579cU3t50EkkIOUa+tq9UXNHiRgg88G3pUFeOId0BCrgtwAyO/d9aMoSQ5Bkeqq/zqsDIYY82uUpenk2vHTgJcyVrZlXs2bLuz47q+TqIa3uYrXFQQSU3H vxEpPDO2 AV+LNWE0Yv2ozKts1CRZ/1yBXLBUJADecKkswu69OXVUAc0eMPgYmDvsQqAc/AZYxBvLzHtDKwq8rn2cRmtrmb2/uuy16ycG6u/BfN822P+8TpfuQRRzzEGoBWkvKaJDOlJu88kx4n09RhHEIXcgrFIBoVHKfPyDaUWEKA/+/xNn4xxQMapIKC0FFu4cL14xquQL0Ti9OMMkXKD0nH69ZnlWe12lje6nmBjgVBYOwHn8dWfantfacoa4/vNmrHAx2MQQbg4WGOhoNUDMdx3tZzZBbaNqyq79SYZ8t1TXdLmsmt8m+Oy74H5oTQ8tIoeN7miaR4/tSUKG6OJ8r/Mb69shfJURby5LKp8BmvY2wr5wuTWm71Tu9/HQQBFBQzfeIdtkOefm+W7/YEtv1qCy6tbHd4/3m190icVqjM2pD0U1ZHJqxc/ezdFPgSTgjPoMQughgJGMElUmALXH6R/QteUV6AcBLtBOvnf1B/Pak2JUTqEFObfIfTA+K2/egEpi4oFK6S20NeZ71W7IoM1FmZc66w/X1wEnC8lVWRS7arZ9eeNE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michael, On Sun, Mar 5, 2023 at 9:44=E2=80=AFPM Michael Schmitz wrote: > On 6/03/23 04:28, Matthew Wilcox wrote: > > On Sun, Mar 05, 2023 at 11:16:13AM +0100, Geert Uytterhoeven wrote: > >>> + while (nr--) { > >>> + __asm__ __volatile__("nop\n\t" > >>> + ".chip 68040\n\t" > >>> + "cpushp %%bc,(%0)\n\t" > >>> + ".chip 68k" > >>> + : : "a" (paddr + nr * PA= GE_SIZE)); > >> As gcc (9.5.0) keeps on calculating "paddr + nr * PAGE_SIZE" > >> inside the loop (albeit using a shift instead of a multiplication), > >> please use "paddr" here, followed by "paddr +=3D PAGE_SIZE;". > > Are we certain that contiguous vaddr always maps to contiguous paddr? For a general __flush_pages_to_ram() function, that would not be guaranteed. But as this is meant for folios, it must be true: https://elixir.bootlin.com/linux/latest/source/include/linux/mm_types.h#L32= 0 Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds