From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3877BC021BE for ; Thu, 27 Feb 2025 13:21:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C85A56B008A; Thu, 27 Feb 2025 08:21:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0FF5280003; Thu, 27 Feb 2025 08:21:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A889B280002; Thu, 27 Feb 2025 08:21:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 891146B008A for ; Thu, 27 Feb 2025 08:21:43 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3ED0581639 for ; Thu, 27 Feb 2025 13:21:43 +0000 (UTC) X-FDA: 83165786886.14.492369B Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf15.hostedemail.com (Postfix) with ESMTP id DB907A0067 for ; Thu, 27 Feb 2025 13:21:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740662501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZScFKf+GfAOC+cGkef77m9WTcLt48410fHxRRqxMGc=; b=jBJneZXfRgq7CUnlLtPQhOFTA1P8M2k/iU2bZIMIjXjHkiiQM542gHypBYHMpdpGG98OuT C4YN+n/68AL3tXUjDSjLRcXqLhgJ5UrnWVm+jqRQimRN3pWQ5H5rOwwPtAqD0EVnkipmPY EZgLBYFhiwdTig2a08/Ar1o/z0jDJDY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740662501; a=rsa-sha256; cv=none; b=eiwjbhgCSc9KRo/c281WBRKpJxS89yXLYx2UywEJwPQz2/0fiJoyz2MHoHHeYLCV2A3p9D fhwWd4hXM/IjOp1pUUSv6loZZJsOFPxqJfKcb0mtDWZ+QOTGtw72bQJlnQo2tji6LEp7Hs q7UeeeU210VlrVxUIH6mhygswjMKu5I= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-86714f41f5bso393758241.3 for ; Thu, 27 Feb 2025 05:21:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740662498; x=1741267298; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VZScFKf+GfAOC+cGkef77m9WTcLt48410fHxRRqxMGc=; b=xPDbmrLIpknRWiIRhdGbpm9R9f5kjmCIREgIt0xK0cjeX9jtrU7qxGlnyvwKHsAXoo A6ObbCh4Exf5HmBYyC4Rj7fEimeTAPX1DI7Eeb385b4hFoAEvpNXU7E09B5m++FwVN1D 4A4TkzZ7YQj5uNyOdNiBNM043GakicdAjjVRAU70ih0Z9HZw+7kUldHxGZnKTgLMN7KC VvobgQKpvGzTJpoWlAOjc2gb1hxE6531/nGhpzut+eoZ4GqHf/dImgWTf4W3QXWIjKLa zIn6asuChpajY3ul9+JmX7FfFdlVPIwgS4nQIqBc3OKN4TqmIaAwiMsZAuAnTsOh/m4/ ENGg== X-Forwarded-Encrypted: i=1; AJvYcCUhJFMjIsRG4EdlQ1GfnvCKRrDeTvxQEd3DtpmJ6dmAjMlyNnSDZ78/slWGQO34/M4/c6e9f3sZvQ==@kvack.org X-Gm-Message-State: AOJu0YzuVNmwISaiFOENKWdZqghLGVi4tdsoYSdAmFoamuUcZ9AIVf3J QB6NpB+RVL/pHbtZW8v8K/t21qgqyW5KKkr7Yx91YeNuQNLJXmDWGRdmbYz2 X-Gm-Gg: ASbGncvOfzvX92jEO0L0LJD5gR6fSkfDOJfrsrtLhRpYGecVoLYxdNarsJITWOWawte UbYEGf2ibxn1eRMIAQ/l8Xoe4MiaXxyx6fjK/jnQLTS3IKvO/u9CrCLqhQSLklYu9M62di2jxd0 yPAHPm6q1mhNcuAmzhmLmB8+vJYdqB8Y8C/sUeVT5EcQWnpdHOnQGmBxEKgMTtNQCbEkj5cakIV DoP0y7O1j/gTDPbtgKXAnuNbO+JuHSf26WQRTzPRndwZ342y4sES3kYi+x8+94bxMB3p/HKimxE 5CxJJ8iQ5h9i928sPkk4W9SbVTtH5KC/213MR3PKfWZ4dDHEGd/gaYkef2+eFQeE898h X-Google-Smtp-Source: AGHT+IGPv++vl1JhM18Yik6xkPjJXJjw4FWXJ1gx2u0zBjEGehPvgn4nDKf5sJHNEo40m+wquFr0tg== X-Received: by 2002:a05:6102:c51:b0:4b9:ba60:ec85 with SMTP id ada2fe7eead31-4c01e21391emr3790614137.15.1740662498627; Thu, 27 Feb 2025 05:21:38 -0800 (PST) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com. [209.85.221.173]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-86b3dc339f5sm189920241.15.2025.02.27.05.21.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2025 05:21:37 -0800 (PST) Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-5209437e773so404182e0c.3 for ; Thu, 27 Feb 2025 05:21:35 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXOINmK6S0ma3Hm6OeO0/jAU4YecHVz8sQjGW2knQq9tSn3yYXFpsZ8r46uxsjD+Tmb0BxJY+fOrQ==@kvack.org X-Received: by 2002:a05:6122:1d53:b0:520:51a4:b81c with SMTP id 71dfb90a1353d-5224ccbbe10mr3808700e0c.6.1740662495074; Thu, 27 Feb 2025 05:21:35 -0800 (PST) MIME-Version: 1.0 References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> In-Reply-To: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> From: Geert Uytterhoeven Date: Thu, 27 Feb 2025 14:21:23 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1Jqe6so1GjZXdkUhIIAiYHT08E9WH9vQcbiUEIVlcQBmr8vV6ha0mxzJuRo Message-ID: Subject: Re: [PATCH v2 3/6] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DB907A0067 X-Stat-Signature: h9g8y1hsdga1dyyofaxsr4ia41457at3 X-HE-Tag: 1740662500-479329 X-HE-Meta: U2FsdGVkX1+RiUeewjnkbUGf5U/+sB483bsr/SAkv7TsAKM/U70exs2rKf5KoL45LnfqILacGRyPNRONEB6H4Y7F8mH4bFjVQAlStE4TWRGc4AFGpniCTE80rCrggXFZ6QT0YLNjd1+hrgZ4ky7romtqsIPfWE4x3B5Gc3ffnpwe0JppN0QCaA8NhxcjlOMFgwSKEnff7ny3eyGAre7o9EP0NoLqhaLJJDL4UhEAiaP23Z+kXHKR40HeE2z2EbvHbS60YLxDu5m/UrDJxJZLfciucECYV1HS4N6kAff+TngQZf2p5BPFFh0LCIr+XonhJJng06CAhvmj74qWfpaMWYDdj+wIjErwCbnbXgIsehoHeY/56vCltiqDs4f2S6R6odQRg3ERxR4SuTPp0WIwHP8IlAhiSgvqU+gfnZRiBUYFOmbfMH9NqWCOYazfGk2Ol6x71Di21+Sl8XiivXnmndYed6bYhM1bNwaxu0sz+QBjfTDkhreqXNWJIDYV1klI1uag3YpKKvMFxsiBLcoERwo6la8GtGpojlpxYbvDMZX6idRCTTwh0joW7Q+gkB/wlt9B4TVYPvlts4hoMf8yRuSW4E6R8t3/7bQSaDob2w4uH40jzPPXg1c1B0t6yhbDP4DvHVHDibXniG8XsgMqMkByobmZ2VfK1/AKkSCaieCuLtWSITVK/p7hGCqssY9O//l9ZQRgsWxbEVVYjXHKYFtmHLuULJeNPt9zkwX3u4z9uEwoBxk2xj185HRvyVA9yayAWsRGFIm1MbYoJFe67SSSgMSeVrL8dFqvbOuarQAo3NZu1iNAqWPmhmfhuDBfwKpoInaVzJp8VJ3NJGWD088Bh+ADxyzQbmyv/dFHYWj3O6SGvPQ9kupa5Zp/WxhgnR6CaEdnw1WD3ljByHRPaMIwTI33SeQdPz633HckByQwUKI87ULhnmtu6cznMy+xeJg83zB1TCRr8HZ0lrI DBaMxV2M +rK7wDp5etgzvL8K9BikvwJgo9rDngulylcaOKk08YkTpzhZtp7AzMywjjx30ePu6tJRzbYXQczLnAF+Mc5l7yLGWJM0P3QJ1CI/Zq0eANrfP3wzQEO7tQsZHq0rFPazkUuZLGOYVRDu409zzryrKSntfq1ooLecLCvTwnTsaROA8zmf2qxGQXiBnwE5uU9GL0xn7/5UVaBFLawiG7j6spqYILESBPdhC65Dr7Hzva2vSQksN9jwFT2W6t8JAHNglyY3Jmy16gXXcCqpd7oXyovPyZXi19tCkBiDYYH7M2j/goZRKbPFlu4h604JQYNR071q7WvSSwwpf2zYp1xB7eRj0mYgd51XNEwdwEG5QzPBekbnUdeNiLEEoUQJNpsz6/QtGOdAnu3JqVjN/7jnb26PdIXoiLlU24ImaCqryqv5dM6C3SaIRlbISqc5NpifVgJ15nZCyfOtOxCRk/HLEIa2iit8d7w5jQ4mvjXmGePI6jrKs6YidHrWErgslm6J4f/ZwIYQQLjjhjEVLdrywNfj40AH+VXPfZ+vbGHLdTSpygB9OAyQLsd3GLfm6tThnBoHam24XAqGr8ST9CdMkoldFZ6AB6KBX/bf9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Qi, On Tue, 25 Feb 2025 at 04:46, Qi Zheng wrote: > Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, > nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, > and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of > tlb_remove_page()). This is the same as the implementation of > tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so > convert these architectures to use tlb_remove_ptdesc(). > > The ultimate goal is to make the architecture only use tlb_remove_ptdesc() > or tlb_remove_table() for page table pages. > > Signed-off-by: Qi Zheng > Suggested-by: Peter Zijlstra (Intel) Thanks for your patch! > arch/m68k/include/asm/sun3_pgalloc.h | 3 +-- Acked-by: Geert Uytterhoeven # m68k > --- a/arch/m68k/include/asm/sun3_pgalloc.h > +++ b/arch/m68k/include/asm/sun3_pgalloc.h > @@ -19,8 +19,7 @@ extern const char bad_pmd_string[]; > > #define __pte_free_tlb(tlb, pte, addr) \ > do { \ > - pagetable_dtor(page_ptdesc(pte)); \ > - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ > } while (0) > With only a single statement remaining, you can remove the do { ... } while construct, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds