From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4662BE77188 for ; Thu, 2 Jan 2025 09:12:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D2A6B009B; Thu, 2 Jan 2025 04:12:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BC966B009C; Thu, 2 Jan 2025 04:12:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8847C6B009D; Thu, 2 Jan 2025 04:12:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6ABF46B009B for ; Thu, 2 Jan 2025 04:12:46 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E033B453C0 for ; Thu, 2 Jan 2025 09:12:45 +0000 (UTC) X-FDA: 82961943204.20.32491D0 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 80B224001B for ; Thu, 2 Jan 2025 09:12:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735809129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3th5K23dgb39d9OKLYthjFpGDRZ0eBmfQ6ZolFTBWbU=; b=MRyXIBR3W56IvTXaMhcK4A8viwKRU72HH0mz4FHxBpFEnwgFv9X6eT53t8kBhZxOFwdWm2 GvNk6dVeK2T3APr3dwy6Wot+8WzmeNlALEbWOi6r/gAZ0rKrqaSRQ1jFuKELlROHyTpMkk xjeW2iK41Muq2AtIPXizx3lm9uNcnCk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735809129; a=rsa-sha256; cv=none; b=sf1qQkaBqMEpAhO8NxxB3llt9J5kGk6QKTXXhtniRsvkD+pHxbLiTs5M7J5xo9TpSZsoRB 75BOsNcPWfndk/+uMU/jaqH91GbVXSyiBhoe5YP96uaLjmsOEL20cBJ3OVtu5s9XVTU4eu UlXbsdL7XVSQWFMig8nSCIn0Wj27In4= Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-85b9f2de38eso1815766241.2 for ; Thu, 02 Jan 2025 01:12:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735809162; x=1736413962; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3th5K23dgb39d9OKLYthjFpGDRZ0eBmfQ6ZolFTBWbU=; b=HcVnkmqywf6li+luf+tHrHLNa2mptDFVmQaBEvHCw7XrJ93QaLv8Nna0TgWj3pyg/S EkrSwI5dWFPEqOxnfEWvtfJIJmf4LejrUcX5ZO73noHtT02kd/YnhzeDLFOgkqzVo8CF /ejLfx/hREda3qDLV6Wxbos2QTgYBp3ApGPYJjcnWldN15tKjCtbI7Qhk0qYVuX2o6Vn WZ4hH5iyPuOvYXAgmXFjnuDASiHDTEvFDR3i0a0p1ZZq6tA8jNjZ9So6pZLwu8VuL1+J sY+Zlgn6tLa+mm3DVrd0Ua3zgfijoyckGrFfiIbq4K1IGDJQEq19eMLz56FTM7ho9SEw egcg== X-Forwarded-Encrypted: i=1; AJvYcCV2zE7kZmFIUT14mVALv5AYEr75IJeSiybBkQ7CDM/Zn8VL5zr4+/veNbFBdBw7/1tMam0j+1G2ig==@kvack.org X-Gm-Message-State: AOJu0YyXYpeBErc5BzB1HvZBf6RUAMjNEyjPelvDNEttGqc17+8mpLMv ugnTZxKG6Wn8AR7EY+ign0fVE6TFhNHkFlfmt4HZ0HGbff80coAYIKVCWvvG X-Gm-Gg: ASbGnctL+DWCKIkTLJeKn2mbZsKDpAVboxlka09tcVWxSmHUD0WnchMVpnm+er+X8zZ 0yYwKu4TMGDHMk9orggapDOlnSo8Jgh9lH3UZpWYmZATRwRl9Z/6/IunQzaCW4UbMDp7GEfIrK1 1dMqwlodvRb5Nc+2eKvB04MZ4nOa6dFop3PsByrF6IksBeuM/2XLPmsBQEKihSKHkZ8SYJ4buLs nmFaIIJNwLibPIb5tA9uiNPblN/vSBk89tWMBBdRKcnAYivFCS0tylBYRvJ5KvMgA7xluvtkiIn RcmwCrel/SV/uxoPNf4= X-Google-Smtp-Source: AGHT+IEzLAmHGh/GT5NScB1dmce0pmDv/N2v6mFSc48JiLQlAQkWEEJ1RdQFASq+TdWtonqzVyvdCQ== X-Received: by 2002:a05:6102:2ac2:b0:4af:d487:45ed with SMTP id ada2fe7eead31-4b2cc31f710mr30955403137.4.1735809161979; Thu, 02 Jan 2025 01:12:41 -0800 (PST) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com. [209.85.217.53]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-8610ac6d815sm4831249241.20.2025.01.02.01.12.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 01:12:41 -0800 (PST) Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-4afd68271b6so2609409137.0 for ; Thu, 02 Jan 2025 01:12:41 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVyvXYKvjaEy8NV1zhXYjEc5prZ9db/+p+GOLpTXe/RrH5qyDlzSi69iwBGnna9IyEz0RQAKcqPlQ==@kvack.org X-Received: by 2002:a05:6102:5127:b0:4b2:ae3a:35d6 with SMTP id ada2fe7eead31-4b2cc456f95mr33601922137.19.1735809161046; Thu, 02 Jan 2025 01:12:41 -0800 (PST) MIME-Version: 1.0 References: <20250102072528.650926-1-guoweikang.kernel@gmail.com> In-Reply-To: <20250102072528.650926-1-guoweikang.kernel@gmail.com> From: Geert Uytterhoeven Date: Thu, 2 Jan 2025 10:12:29 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8] mm/memblock: Add memblock_alloc_or_panic interface To: Guo Weikang Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: b9rj1s8kfezjajx7ng5pgfdfkhxs3yr1 X-Rspamd-Queue-Id: 80B224001B X-Rspam-User: X-HE-Tag: 1735809125-655777 X-HE-Meta: U2FsdGVkX1/5fgBkLRw5pi/eWpVLJi9kD001mCJ8oFVjVRLkk8YIcf2KLV3cRLbR2h97ml4nToXoKnBoFPax24aXW8qpFxYtM7tXm9xsCGvqEjFFlMnHeupm8l8urRus/2VCD9X+MQwq61ChqCzeA10YIV6TmTKK21RFz31KN+q6eRwFmnnsfN/I549vAA3wWoFvDrilgWaRzLqd66reqaLjDJrOy9xZ64hPf9WJh0cmA8GCv6++G74GfbXoXFrsc6Snsr1pwUpejjryjjbV7K56MuKSTz0Vg2ahZw1qlp2WQyOQXk+hJm799NmSKCDjK3fNAaH4WKb80Idq4K+5OkHLtXyP1IQD2uO07sT58TWsamdjMKmPWX58tHl2q1I//f8MM4K0fSHs24SXR84JL3O6weIwVd5aHRpPNdqjrtYamKqqxwfNsPH09dfusPR3JRme0abZODB4yL/IZy10Nzdv4K2FrUOIgQno11+Pbypu2qxEQI6t9eIw8bqR5o2eNhaO2FfXPmP/UQHWTuSc7uQPx0q4VDAiparYGiIOKiARlYzXh84HUt6m/ulqNeFGci6s/5eYs8Yf1uZkRyqAddGsN0xCY4/v4WYWxiT1Mc+rujbKXl9ixLnYHJzlHvqB3u8IfZG6RTcZiSf6R6c7vsjxmk2OAIaVPtWaZUsnrkcM38KA76fCLowqfi2sdwxP0SK0iu+sQ3zo9AUbpowzOQPpBiMAJl/0CF3tZAzo67lCI1lViyl9+CdB4K/2vco8LudwEYY6XA23HANkaVq2IvqBje90rnHA/RnHxlVJocf7KFLmkCI0GwJO5VyIBTuvLKV3qZ+r9z3ai99gFsB/qYJ8aK0B/BHu/yRmSJXbOhIxA/IPu196KP2RRSNPOsp8LnzsXaMPJ3A2tckJQcmvTZ6qRwEiRpoJnW9NWlLqgWTBNoAMFXULVWdALeIkDV1tW/W24ZL42lI/Ip9ctQC iCKJBpiQ NIMU3kytgRtI7lK6vvhXwefJm4al1dCg5ygi8fbXsFy6PAlDSPNtpet+/QDtGocbam5qS7dGoQnZ//uwJPft1SUW5oCCc03k3zoCCskfOsu8adK1/JXy6INw6hpfvAayvEDlKQKP43mHRaW7l0Tpa1ziuIzSKzkDY2sLg2+9XKh+MAxm9eg+r1i0h7YIDCngP6bV1ShM444BNdIr/8c0yWkp8TmO4zsNW5R2rhwdDrEg0hkQ5XU0tqOpWhl2Kp0Ak1Jbt7WE5xDadGguptTWMzng6B6y8Sv1rzpfeT7J7ZVuK+rX8Vn9dlS7WI+tcvVv8xD/K1Msv7bk/nBo/JmjrI9g8ppzJ1UjYvfJbyE7sNFd1FT1PTfLErdxPMuo3QGVRgu3ONphiwfbJgLqc9HCcW80fkpPLjbwTWLRfgaOdqHEetrhx8UJbmMsQttbZKja1gAL0IOCno9R/OY92nfWPXg68Cyc2JCsoz0VY8NnRYP/XLJToFlrVmBxQP5vbkzfQAjLk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 2, 2025 at 8:25=E2=80=AFAM Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediat= e > panic is required. To simplify this behavior and reduce repetitive checks= , > introduce `memblock_alloc_or_panic`. This function ensures that memory > allocation failures result in a panic automatically, improving code > readability and consistency across subsystems that require this behavior. > > Signed-off-by: Guo Weikang > arch/m68k/mm/init.c | 5 +- > arch/m68k/mm/mcfmmu.c | 10 +--- > arch/m68k/mm/motorola.c | 5 +- > arch/m68k/mm/sun3mmu.c | 10 +--- > arch/m68k/sun3/sun3dvma.c | 6 +-- Acked-by: Geert Uytterhoeven # m68k Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds