Re: [linux-next:master 7313/8469] drivers/gpio/gpio-sim.c:388:34: warning: unused variable 'gpio_sim_of_match'

[Bartosz Golaszewski <bgolaszewski@baylibre.com>]

On Tue, Mar 30, 2021 at 11:55 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Mar 30, 2021 at 11:26:17AM +0200, Bartosz Golaszewski wrote:
> > On Tue, Mar 30, 2021 at 11:11 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Tue, Mar 30, 2021 at 12:15:04PM +0800, kernel test robot wrote:
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > > head:   9d49ed9ca93b8c564033c1d6808017bc9052b5db
> > > > commit: 3f0279eb9e3767f37939358a42054c226503233a [7313/8469] gpio: sim: new testing module
> > > > config: arm-randconfig-r001-20210330 (attached as .config)
> > > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 482283042f795ecc27838a3b2f76b5494991401c)
> > > > reproduce (this is a W=1 build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         # install arm cross compiling tool for clang build
> > > >         # apt-get install binutils-arm-linux-gnueabi
> > > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3f0279eb9e3767f37939358a42054c226503233a
> > > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > > >         git fetch --no-tags linux-next master
> > > >         git checkout 3f0279eb9e3767f37939358a42054c226503233a
> > > >         # save the attached .config to linux build tree
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > >> drivers/gpio/gpio-sim.c:388:34: warning: unused variable 'gpio_sim_of_match' [-Wunused-const-variable]
> > > >    static const struct of_device_id gpio_sim_of_match[] = {
> > > >                                     ^
> > > >    1 warning generated.
> > >
> > > of_match_ptr() should be removed AFAIU the case.
> > >
> >
> > I'm not using it though... Other drivers do the same thing as I did
> > here. Can this be a false positive?
>
> Ah, you simply missed to add it to the platform driver structure.
>
> No, it's not false positive.
>
> > > > vim +/gpio_sim_of_match +388 drivers/gpio/gpio-sim.c
> > > >
> > > >    387
> > > >  > 388        static const struct of_device_id gpio_sim_of_match[] = {
> > > >    389                { .compatible = "gpio-simulator" },
> > > >    390                { }
> > > >    391        };
> > > >    392        MODULE_DEVICE_TABLE(of, gpio_sim_of_match);
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Indeed. I'll send a patch.

Bartosz