From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 681A5C00A89 for ; Mon, 2 Nov 2020 15:43:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89FBE223AB for ; Mon, 2 Nov 2020 15:43:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="GeZOTcEL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89FBE223AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C34A16B0072; Mon, 2 Nov 2020 10:43:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBD206B0074; Mon, 2 Nov 2020 10:43:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A86236B0075; Mon, 2 Nov 2020 10:43:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 791B36B0072 for ; Mon, 2 Nov 2020 10:43:36 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0E7AF8249980 for ; Mon, 2 Nov 2020 15:43:36 +0000 (UTC) X-FDA: 77439898032.06.crime79_4715767272b1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id D9F311003E4B9 for ; Mon, 2 Nov 2020 15:43:35 +0000 (UTC) X-HE-Tag: crime79_4715767272b1 X-Filterd-Recvd-Size: 4784 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 15:43:35 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id za3so19486732ejb.5 for ; Mon, 02 Nov 2020 07:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nS8GcWnRvgAze9eGONKgTm54dvXOecWjyagLlZce7Is=; b=GeZOTcELL0wHCC2LsYMp4AHDK/U4F0TpiMBx0TLSL9ySl4L4C8XcHcbUz5fZNLjniM TuvyR4acGxkL9PjF4zrWBiY258C6IcsF0J9LR6SowCpPKmCKno9m8GSu4pQU9/WnDZH7 7UkFNkQaU4R7nVWteNdPvBIJxPPgU8WHblr0zM6zQdwUqyKaEmqLaDFu3SLFEdkz8070 +tw2ItP8FRhBWa/R+2tqWgkisP8VzJCQvEhMDs6cgObDq+FQOIe0RTsRoPUGJizua2af DerEr/5gFY6bKe9hU6ejx4bsKfOsV8bd9SlGakYbkn/eCz8qeemmHfgRz2JwvgXFT4AO tsEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nS8GcWnRvgAze9eGONKgTm54dvXOecWjyagLlZce7Is=; b=KLpUJCV18ZcWML9cPAnBZFoyfz8sBU8e0rUqx4H+FTzgDLFqMJTSYeY3ywGIQ6KpFW 5w+NdaFCkkTTN35JtQ/VW+s7DYTj/DY1hRrD1JjhBmZYRb6vQD4v7EqjR1r3yhMqri+2 dZxG+3c+uq4rhuLjZghEEfH5LqbtUpbJC/rurhvuFvVmoVyyu62ulN4a4J1lkU66eSJX hdcq8P1ayilZvM45s4R5kxqb/38CyDVx7bn+ch4nnRKx59b2dKBo3rWv7aBCKXgo1s7C 62c0qmP2J8cIDbF1LCljvzNnUhd5TyFghjDUk+Ag7Oa0MbKdXrI/TL67ZfI3nw7kDzGg 9jeA== X-Gm-Message-State: AOAM533XdH6sXiUzuMr7U9BCu/fJUGSe2iZ/uOQ9gqUzaZKbBzHGCrYr Ahe1DVXWU9JqV10i27jKx3kJMOpe2DaKeEQQkXK+QA== X-Google-Smtp-Source: ABdhPJyfQCPRUI5fZkO4PkZURO7NzoV9R0m8AUPk0K6Fot5LT+TZuLggUEPGTEcOXrVbpzMXVwNY7147yllEhTQsoPY= X-Received: by 2002:a17:906:1c84:: with SMTP id g4mr2189231ejh.155.1604331814011; Mon, 02 Nov 2020 07:43:34 -0800 (PST) MIME-Version: 1.0 References: <20201102152037.963-1-brgl@bgdev.pl> <20201102152037.963-2-brgl@bgdev.pl> <20201102154101.GO27442@casper.infradead.org> In-Reply-To: <20201102154101.GO27442@casper.infradead.org> From: Bartosz Golaszewski Date: Mon, 2 Nov 2020 16:43:22 +0100 Message-ID: Subject: Re: [PATCH v2 1/8] mm: slab: provide krealloc_array() To: Matthew Wilcox Cc: Bartosz Golaszewski , Andy Shevchenko , Sumit Semwal , Gustavo Padovan , =?UTF-8?Q?Christian_K=C3=B6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , linux-media , linux-drm , linaro-mm-sig@lists.linaro.org, LKML , linux-edac@vger.kernel.org, linux-gpio , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev , linux-mm@kvack.org, Linux-ALSA , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 2, 2020 at 4:41 PM Matthew Wilcox wrote: > > On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > > +`krealloc_array`. > > Is there any reason you chose to `do_this` instead of do_this()? The > automarkup script turns do_this() into a nice link to the documentation > which you're adding below. > No, I just didn't know better. Thanks for bringing this to my attention. > Typo 'resising' resizing. Will fix in the next iteration. Bartosz