linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: highmem remove 3 errors
Date: Thu, 2 Oct 2014 19:54:46 +0400	[thread overview]
Message-ID: <CAMo8BfKvvGg7QAH1GqGH98Qsw9v8=Ok0cV+uxKL5RP97p--KpQ@mail.gmail.com> (raw)
In-Reply-To: <1412264685-3368-1-git-send-email-paulmcquad@gmail.com>

On Thu, Oct 2, 2014 at 7:44 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
> pointers should be foo *bar or (foo *)
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
>  mm/highmem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 123bcd3..f6dae74 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -130,7 +130,7 @@ unsigned int nr_free_highpages (void)
>  static int pkmap_count[LAST_PKMAP];
>  static  __cacheline_aligned_in_smp DEFINE_SPINLOCK(kmap_lock);
>
> -pte_t * pkmap_page_table;
> +pte_t *pkmap_page_table;
>
>  /*
>   * Most architectures have no use for kmap_high_get(), so let's abstract
> @@ -291,7 +291,7 @@ void *kmap_high(struct page *page)
>         pkmap_count[PKMAP_NR(vaddr)]++;
>         BUG_ON(pkmap_count[PKMAP_NR(vaddr)] < 2);
>         unlock_kmap();
> -       return (void*) vaddr;
> +       return (void *) vaddr;

checkpatch suggests that
CHECK: No space is necessary after a cast

>  }
>
>  EXPORT_SYMBOL(kmap_high);
> @@ -318,7 +318,7 @@ void *kmap_high_get(struct page *page)
>                 pkmap_count[PKMAP_NR(vaddr)]++;
>         }
>         unlock_kmap_any(flags);
> -       return (void*) vaddr;
> +       return (void *) vaddr;

Here as well.

-- 
Thanks.
-- Max

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-10-02 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 15:44 Paul McQuade
2014-10-02 15:54 ` Max Filippov [this message]
2014-10-02 16:13   ` Max Filippov
2014-10-02 16:44 Paul McQuade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMo8BfKvvGg7QAH1GqGH98Qsw9v8=Ok0cV+uxKL5RP97p--KpQ@mail.gmail.com' \
    --to=jcmvbkbc@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paulmcquad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox