From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD276C433E7 for ; Thu, 3 Sep 2020 07:29:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 687B120775 for ; Thu, 3 Sep 2020 07:29:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a+nbvgq8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 687B120775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D9C396B0068; Thu, 3 Sep 2020 03:29:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4BF96B006C; Thu, 3 Sep 2020 03:29:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3AD18E0001; Thu, 3 Sep 2020 03:29:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id ABB5D6B0068 for ; Thu, 3 Sep 2020 03:29:29 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 56AE73630 for ; Thu, 3 Sep 2020 07:29:29 +0000 (UTC) X-FDA: 77220924858.19.unit65_14080a3270a7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 240201ACEBC for ; Thu, 3 Sep 2020 07:29:29 +0000 (UTC) X-HE-Tag: unit65_14080a3270a7 X-Filterd-Recvd-Size: 5273 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 07:29:28 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id j11so2456199ejk.0 for ; Thu, 03 Sep 2020 00:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z2ZPyKLU1YkrBtAIw6FNyEviDavWBxV/x7RwKxTnSNY=; b=a+nbvgq8jDteeyFU2pmd0V3LboA3T4ib6jbNB2+bFyZ+aLX+5k5xYXVAIuSVnypxrN DYcGkl5XFNBy1yfaOeyaXcDw3kbXueho88n9nxSBMd+kZLG+YFQjYK/jCnSLj18E2eF7 etyrfXYwR2cpswHBvDX9+jlAl6a2CapE4iSF9nw0SoVjNXvpPmW2KPBVhpFpvpHU7+L3 a8Tn6Gb/NEXHnqSzLZAV1VHpIumwtjlYIytkb6ef6ndGQSbI113+OH7f2DrxMBggZQ1O ROQxJYgaAmyXINJW4pBZCmnto/ggRRO+8HBZFMz5hKOOGUD6uQdDl+5uZwsQU5mDs38a dWbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z2ZPyKLU1YkrBtAIw6FNyEviDavWBxV/x7RwKxTnSNY=; b=d5xke3OImc2ZRVAVJ/o0QqyqEX+8Hbw1W/vLUuElyqD1uZyIHNpu3Z5K3PB0PrAK01 nwqGxsVEUSa7Yds8D8ImjK3zjy6DB2i17IDpFR240JgE8gbFx+sO7QBIKjWW9a997+Ai DjvUVUWO2HU+jYvTDgX0udTfrqMEN6y1jfE7B0eWoLdA89bnVMV3zVleECOhXHJVMrbM DUvUmHnVhv8q39eJfCS8b3fjVW5x7jHcrLpxg9p7ajXsnJ3mwSdO7vX80nLfdXhcTOGk A6GXR4rGSwl05NEcpWN17hTiWrZsLt1nY9Y4p8ONPlLYuKSveNVbpo9iiONjZi7d3jpx kvOA== X-Gm-Message-State: AOAM533I9G0BU2Qjh17bePcQrgeHkChxEFTAEjb8yMhSYcwA5v6qrTsO YJ6BZbhik5h3hG5kg7WLcPsjzC5CeXAj+m+SQTM= X-Google-Smtp-Source: ABdhPJywqyR8GIjxi73MMDL2UvtZSyQX7uzjFGvNi6kH8eA5ZNax+GIlMzjUEHcvThINsAkcxV3kJTq3hQqeqY3QKpc= X-Received: by 2002:a17:906:f1c4:: with SMTP id gx4mr822582ejb.98.1599118167544; Thu, 03 Sep 2020 00:29:27 -0700 (PDT) MIME-Version: 1.0 References: <1599116482-7410-1-git-send-email-alex.shi@linux.alibaba.com> <1599116482-7410-3-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: <1599116482-7410-3-git-send-email-alex.shi@linux.alibaba.com> From: Max Filippov Date: Thu, 3 Sep 2020 00:29:16 -0700 Message-ID: Subject: Re: [PATCH v4 3/4] mm/pageblock: work around multiple arch's cmpxchg support issue To: Alex Shi Cc: Anshuman Khandual , David Hildenbrand , Matthew Wilcox , Vlastimil Babka , Alexander Duyck , Andrew Morton , Baolin Wang , Russell King , Yoshinori Sato , Rich Felker , "David S. Miller" , Chris Zankel , LKML , linux-arm-kernel@lists.infradead.org, "open list:SUPERH" , "open list:SPARC + UltraSPAR..." , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 240201ACEBC X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 3, 2020 at 12:01 AM Alex Shi wrote: > > Armv6, sh2, sparc32 and xtensa can not do cmpxchg1, so we have to use > cmpxchg4 on it. [...] > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig> index e00d94b16658..03a6c7fd999d 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -48,6 +48,7 @@ config ARM > select GENERIC_ALLOCATOR > select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY > select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI > + select NO_CMPXCHG_BYTE if CPU_V6 > select GENERIC_CLOCKEVENTS_BROADCAST if SMP > select GENERIC_CPU_AUTOPROBE > select GENERIC_EARLY_IOREMAP > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index d20927128fce..4c7f0ad5b93f 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -155,6 +155,7 @@ menu "System type" > config CPU_SH2 > bool > select SH_INTC > + select NO_CMPXCHG_BYTE > > config CPU_SH2A > bool > diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig > index efeff2c896a5..51ae5c8ede87 100644 > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -58,6 +58,7 @@ config SPARC32 > select CLZ_TAB > select HAVE_UID16 > select OLD_SIGACTION > + select NO_CMPXCHG_BYTE > > config SPARC64 > def_bool 64BIT > diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig > index e997e0119c02..862b008ab09e 100644 > --- a/arch/xtensa/Kconfig > +++ b/arch/xtensa/Kconfig > @@ -42,6 +42,7 @@ config XTENSA > select MODULES_USE_ELF_RELA > select PERF_USE_VMALLOC > select VIRT_TO_BUS > + select NO_CMPXCHG_BYTE Please keep the lists of select statements in Kconfig files above alphabetically sorted. -- Thanks. -- Max