From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84AFEC433EF for ; Wed, 23 Feb 2022 22:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9F4A8D0002; Wed, 23 Feb 2022 17:31:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4C728D0001; Wed, 23 Feb 2022 17:31:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ED658D0002; Wed, 23 Feb 2022 17:31:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 629DD8D0001 for ; Wed, 23 Feb 2022 17:31:01 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E382321F2B for ; Wed, 23 Feb 2022 22:31:00 +0000 (UTC) X-FDA: 79175491080.15.D81A215 Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by imf31.hostedemail.com (Postfix) with ESMTP id 66B7020009 for ; Wed, 23 Feb 2022 22:31:00 +0000 (UTC) Received: by mail-ua1-f42.google.com with SMTP id k5so22037uao.2 for ; Wed, 23 Feb 2022 14:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1RPwSA1q9Nzhq0/2Be8zKvMRRcdwuPwwh16qax7HGnE=; b=K0CZpAIDRgzm1DInotHuxQNOJpRDnhpSUF+ctLbt+rxbs0LQZI1S/EJG354MaIhC1p b45wsq4jtpVp8/TYsrR7yb4UHfBZz2cfnUtGlk70ABA3mLXm2hl2NlxJgQMPfc0P8V/B fAw/G1/6B7k4ewpmyD5SJHfM3X1NDpa/y+ufO0W+38RcacUCr/Jaq2gwTigxybnkPr8G k+GmLhgJ03xfxxcsYrsKSdCyoGsHhW5WrYQEbXEAyQ8dKL6rgE9tfk0rxLHuKnqAg2K+ mJ72+bba2C/Wp8bcOfZzDa9zKelfx9id1sP9BdY2CnJq66D7nJJyZ5eIZZV3Ta5wjXNH Y5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1RPwSA1q9Nzhq0/2Be8zKvMRRcdwuPwwh16qax7HGnE=; b=ITpGw2gbX7sPoIh76wk+sGTIgBLdoMRPZ/PdGDJFvPEbVni3bvA5vETgTlFY9JjpKA 6tvXLAnZEWw02zH5zQrpUCGubtB4SNUGe0SGuGcxJX+/uf59PenN+1pfATToMFEMcwjb a4F2vOxS739zMdSw0+FUDAFslzjdcjroNMz/QjN0+4oddD5A6pfdb1LBYbGY/5g1rgKt aWN8Jxd9C6uaINyqnksCVZNiPcVtx7VA25avpZBOYlRTh8/bjQFydlYqxCF0OH0Zlbhq NIn/aV+UoWRGPYZD4h0dNQalUN0zKuLUi2vRyOjEdG541fiXIq/2K62tf7W+Tunjpqi7 nATA== X-Gm-Message-State: AOAM53048ghkQVH3f8UEZlWLrwRUT27thNFFXAaoGT77CVhSFMf/qD3v S4T1v6OnlGw4qn7cUe2EvdgESuZ2RPUxlxUC/T1EDg== X-Google-Smtp-Source: ABdhPJxcYUHzeNXY0S/1ioCWxi5/56MKJyhukDlovTx8UShV5ojlA1UJTSNGHwOPvWyeZntnlGp/VLuoQHMIA6GpB20= X-Received: by 2002:ab0:69d0:0:b0:345:72b0:ee12 with SMTP id u16-20020ab069d0000000b0034572b0ee12mr946042uaq.78.1645655459242; Wed, 23 Feb 2022 14:30:59 -0800 (PST) MIME-Version: 1.0 References: <20220219012433.890941-1-pcc@google.com> <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com> In-Reply-To: From: Peter Collingbourne Date: Wed, 23 Feb 2022 14:30:48 -0800 Message-ID: Subject: Re: [PATCH] kasan: update function name in comments To: Marco Elver Cc: Miaohe Lin , Andrew Morton , Linux Memory Management List , Andrey Konovalov , kasan-dev , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=K0CZpAID; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of pcc@google.com designates 209.85.222.42 as permitted sender) smtp.mailfrom=pcc@google.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 66B7020009 X-Stat-Signature: eockf9g7yqedh5nt3nmfdfrfya4aedz8 X-HE-Tag: 1645655460-69763 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000321, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 3:15 AM Marco Elver wrote: > > On Sat, 19 Feb 2022 at 03:00, Miaohe Lin wrote: > > > > On 2022/2/19 9:24, Peter Collingbourne wrote: > > > The function kasan_global_oob was renamed to kasan_global_oob_right, > > > but the comments referring to it were not updated. Do so. > > > > > > Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be > > > Signed-off-by: Peter Collingbourne > > > Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test") > > > > This Fixes tag is unneeded. > > > > Except the above nit, this patch looks good to me. Thanks. > > > > Reviewed-by: Miaohe Lin > > Reviewed-by: Marco Elver > > And yes, the Fixes tag should be removed to not have stable teams do > unnecessary work. I thought that Cc: stable@vger.kernel.org controlled whether the patch is to be taken to the stable kernel and Fixes: was more of an informational tag. At least that's what this seems to say: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight > +Cc'ing missing mailing lists (use get_maintainers.pl - in particular, > LKML is missing, which should always be Cc'd for archival purposes so > that things like b4 can work properly). get_maintainers.pl tends to list a lot of reviewers so I try to filter it to only the most important recipients or only use it for "important" patches (like the uaccess logging patch). It's also a bit broken in my workflow -- https://lore.kernel.org/all/20210913233435.24585-1-pcc@google.com/ fixes one of the problems but there are others. Doesn't b4 scan all the mailing lists? So I'd have imagined it wouldn't matter which one you send it to. Peter