From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DF5C433F5 for ; Tue, 26 Apr 2022 18:16:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A6B96B0074; Tue, 26 Apr 2022 14:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62EFE6B0075; Tue, 26 Apr 2022 14:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A9266B007B; Tue, 26 Apr 2022 14:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 33D0A6B0074 for ; Tue, 26 Apr 2022 14:16:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E8BD5275FD for ; Tue, 26 Apr 2022 18:16:08 +0000 (UTC) X-FDA: 79399834416.03.2AA677B Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf23.hostedemail.com (Postfix) with ESMTP id 1DD7614004C for ; Tue, 26 Apr 2022 18:16:02 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id m128so16515197ybm.5 for ; Tue, 26 Apr 2022 11:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NHalnczSrgV7nsCOyAK5ppIla2Ja271UVepo2Mtht40=; b=LMed7+3WdnbUqx53fGaZH7cklJ8mcbKUzxQ4vWrUD0JhVhD1z/0yPBo188RqR3Mqfy dRyraF6qUYiCKCr1DnJcAJXCyDB6E9df6SrzG41rsWsnrr3r8wwaIVWMq/5cYclFqhEK GiiXXU0PxM7lNxYyCZ6shfw3CGtEdBWheNRhRxkcQjtnpkvT2BenoTRFPM116SKAYtjW 0s/aBVHnq+CV5f7KQ8F/lmtQB4kveuTKNTJN6xFggsEIutTZQYd3nboIlT8g83JmccaH SNvK/Hki8bM33pIsSbfYVi7/06kDHS/6O19532LA9rRIhEHWeOr/xL6R+z0/e0Od6olT fIVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NHalnczSrgV7nsCOyAK5ppIla2Ja271UVepo2Mtht40=; b=xlJHy87TH0JcsyrdL5+H36/p/chPkstGLKvgUdY1bnSD8q4a7mpCxWmVOxtxjDnLTc Cn/DrcU6EQ/mMc0dyfkee90QFL3ub4hLUlw+w+cNhJSuU9rkxcBDv5KJ8UvmqYySc3E2 KDdXHiB4QC+PrFfe9z79GAeJBle5W6Y7Ai+lrmkojrWazPprttyjfuTSdDDZ/6WydX4B /1kNakNy2J3eabRDIIJN6w9aR/HAEQwnFDHdNrN94AFG6QIFoz2Y2bmlurKvZRafrVV2 HBHn/qzQJuldaEX6D5Lx5O9i4w89aSr4lIh4P21tyYGKGCQbbxgY6Fe/cJrZCl7bkLqP w7Qw== X-Gm-Message-State: AOAM530ceWLbUrvfS/RZZ5jXfAslirYjgwF9Dh5eH5HbQeP0XoHQxy3v gMBQJkU21lolMMzxzwTYFJ5uBsyUjdWOUPlkhe5BMA== X-Google-Smtp-Source: ABdhPJz7V55S2LOXdb5KVVyv7qUZE5R5SmXc4kGPxdfbTmt31xyPMidCAhKnIhA50wcC6/lGYgkY4q2l0A1ifTcm4bA= X-Received: by 2002:a25:b3c7:0:b0:623:e9fe:e108 with SMTP id x7-20020a25b3c7000000b00623e9fee108mr21492504ybf.335.1650996967408; Tue, 26 Apr 2022 11:16:07 -0700 (PDT) MIME-Version: 1.0 References: <20220422201830.288018-1-pcc@google.com> <202204251346.WbwgrNZw-lkp@intel.com> <147b11c3-dbce-ccd3-3b0c-c5971135f949@suse.cz> In-Reply-To: <147b11c3-dbce-ccd3-3b0c-c5971135f949@suse.cz> From: Peter Collingbourne Date: Tue, 26 Apr 2022 11:15:56 -0700 Message-ID: Subject: Re: [PATCH v3] mm: make minimum slab alignment a runtime property To: Vlastimil Babka Cc: kernel test robot , Andrey Konovalov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Catalin Marinas , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , Pekka Enberg , roman.gushchin@linux.dev, Joonsoo Kim , David Rientjes , Herbert Xu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev , Eric Biederman , Kees Cook Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1DD7614004C X-Stat-Signature: igunr9pqtpgpo9k16367c5cbxrnekz5f X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LMed7+3W; spf=pass (imf23.hostedemail.com: domain of pcc@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=pcc@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1650996962-622585 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 8:12 AM Vlastimil Babka wrote: > > On 4/25/22 07:12, kernel test robot wrote: > > Hi Peter, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on hnaz-mm/master] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024 > > base: https://github.com/hnaz/linux-mm master > > config: arm64-buildonly-randconfig-r002-20220425 (https://download.01.org/0day-ci/archive/20220425/202204251346.WbwgrNZw-lkp@intel.com/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install arm64 cross compiling tool for clang build > > # apt-get install binutils-aarch64-linux-gnu > > # https://github.com/intel-lab-lkp/linux/commit/3aef97055dd4a480e05dff758164f153aaddbb49 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024 > > git checkout 3aef97055dd4a480e05dff758164f153aaddbb49 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 prepare > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > In file included from kernel/bounds.c:10: > > In file included from include/linux/page-flags.h:10: > > In file included from include/linux/bug.h:5: > > In file included from arch/arm64/include/asm/bug.h:26: > > In file included from include/asm-generic/bug.h:22: > > In file included from include/linux/printk.h:9: > > In file included from include/linux/cache.h:6: > > In file included from arch/arm64/include/asm/cache.h:56: > > In file included from include/linux/kasan-enabled.h:5: > > In file included from include/linux/static_key.h:1: > > Hmm looks like a circular include, cache.h is too "low-level" in the > hierarchy to bring in kasan->static_key->jump_label.h definitions? > jump_label.h does include bug.h, but we have it above already and have > already passed #define _LINUX_BUG_H. > > So, a different kind of header with arm64-specific variant? The fix that I'm pursuing starts with: diff --git a/include/linux/printk.h b/include/linux/printk.h index 1522df223c0f..8e8d74edf121 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h @@ -6,7 +6,6 @@ #include #include #include -#include #include #include and fixing the fallout from code that was including printk.h and depending on something from cache.h. So far I haven't found much, only 3 fixups required for an arm64 defconfig kernel but I'm trying some more configs as well. Peter