From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766DAC433EF for ; Fri, 22 Apr 2022 20:08:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAB2E6B0073; Fri, 22 Apr 2022 16:08:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5B886B0074; Fri, 22 Apr 2022 16:08:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D233B6B0075; Fri, 22 Apr 2022 16:08:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id C2D5F6B0073 for ; Fri, 22 Apr 2022 16:08:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9571AEA5 for ; Fri, 22 Apr 2022 20:08:33 +0000 (UTC) X-FDA: 79385602506.28.10A2FF9 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 5DB501A0031 for ; Fri, 22 Apr 2022 20:08:30 +0000 (UTC) Received: by mail-vk1-f180.google.com with SMTP id i27so4342185vkr.5 for ; Fri, 22 Apr 2022 13:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oe1v+8HKmPN5xE9lG49dcb7rjaDAxWTXKsNw822YQmM=; b=n5x2XicX6wPW74Dksn/JJcGTef6fmb3LZJfmWfIbNW6DANox9qPcP5MqfpuwQlpCDf KoTnuASNxeNpGEBOVFUMkGBeuh4jeVYPYDzN84oEq4VvPT6xIZHiulL2k4kfJ5KT/UUw RtDonsGeZSdT3trKWIsDJsVrHud1ugjNH+esPOLHkaO+4fQ748BaNghTc9SBPi+QZ+O+ 8Cdf5JsCnp5fC2/h2avY6ZdmwpgzaTRq5W8xXWXQhomPayl33tegCZuIw1zaupfoFIGM iQds3OVOa4vEkMuPzPDLe+Y58XOuY+lA6JQ7y5NiDNXMaPu7wD/sFme4jtws1QPJXkxa VyHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oe1v+8HKmPN5xE9lG49dcb7rjaDAxWTXKsNw822YQmM=; b=6zSirGRr5WPLygby756aQMuaQPb4DTQoHH+jP2OipUYWkY809/v0U0Ipw+l20v9rTk jX/yKMVZBWV8oZ2aKkylEdFl9U21yrgUa+cLvML2LgDFPxcs3bTSFXEq7473NBkLwqO7 Yja5m5y37g5dzTpFwdy7DJrzmKZR3uMp12XnoUwjCJk6dAZqz3PILmjeQ3woMsPsCE1Z wJRh7kmadOfvkGAHm4GJDh5Rcr9djBjxKiPiEix0EJzFSwzPCg3H9S3D17W0/IjvqFPq X9ouhLqJHFcin3a/BLAkOksWmdkfoXQyE+PLKBn1tOHIOIoyjtJObRIJWMm90YevFZ/c 64Rg== X-Gm-Message-State: AOAM531WVXcPR2DPgFaBHsQGzpO8GQznmcdS5Rr1hU1IwYZYnmtIGmTh 38quVhXoI/pyYJgokiizkFLaZEgG3HloT3mzYHbWYg== X-Google-Smtp-Source: ABdhPJwnyBvl4lVolT8r8TO68OfMOMxgYxm+vCBlAU7uPN5abEv9TLKrIlxLB6z0kTpYjkPB8fzzxj6x+DqKb9Y2+IU= X-Received: by 2002:ac5:c899:0:b0:349:33e8:d676 with SMTP id n25-20020ac5c899000000b0034933e8d676mr2382122vkl.0.1650658111910; Fri, 22 Apr 2022 13:08:31 -0700 (PDT) MIME-Version: 1.0 References: <20220421211549.3884453-1-pcc@google.com> In-Reply-To: From: Peter Collingbourne Date: Fri, 22 Apr 2022 13:08:20 -0700 Message-ID: Subject: Re: [PATCH v2] mm: make minimum slab alignment a runtime property To: Catalin Marinas Cc: Andrey Konovalov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Linux ARM , Linux Memory Management List , Linux Kernel Mailing List , Vlastimil Babka , Pekka Enberg , roman.gushchin@linux.dev, Joonsoo Kim , David Rientjes , Herbert Xu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev , Eric Biederman , Kees Cook Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=n5x2XicX; spf=pass (imf19.hostedemail.com: domain of pcc@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=pcc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5DB501A0031 X-Stat-Signature: b3p7owgfp6k1zd16bnnhm9p83btf9yeu X-HE-Tag: 1650658110-886078 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 11:03 AM Catalin Marinas wrote: > > On Thu, Apr 21, 2022 at 02:15:48PM -0700, Peter Collingbourne wrote: > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index 373b3ef99f4e..80e517593372 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -201,21 +201,33 @@ void kmem_dump_obj(void *object); > > #endif > > > > /* > > - * Setting ARCH_SLAB_MINALIGN in arch headers allows a different alignment. > > + * Setting ARCH_SLAB_MIN_MINALIGN in arch headers allows a different alignment. > > * Intended for arches that get misalignment faults even for 64 bit integer > > * aligned buffers. > > */ > > -#ifndef ARCH_SLAB_MINALIGN > > -#define ARCH_SLAB_MINALIGN __alignof__(unsigned long long) > > +#ifndef ARCH_SLAB_MIN_MINALIGN > > +#define ARCH_SLAB_MIN_MINALIGN __alignof__(unsigned long long) > > +#endif > > Sorry, only a drive-by comment, I'll look at the arm64 parts next week. > I've seen it mentioned in the first version, what's the point of MIN_MIN > and not just MIN? I tried to explain it here: https://lore.kernel.org/all/CAMn1gO5xHZvFSSsW5sTVaUBN_gS-cYYNMG3PnpgCmh7kk_Zx7Q@mail.gmail.com/ In the end I decided to go back to MIN so this is moot. Peter