From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A358C636CA for ; Sat, 17 Jul 2021 02:58:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCB3661278 for ; Sat, 17 Jul 2021 02:58:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCB3661278 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3D5768D00F6; Fri, 16 Jul 2021 22:58:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AC048D00EC; Fri, 16 Jul 2021 22:58:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24C698D00F6; Fri, 16 Jul 2021 22:58:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 04C4C8D00EC for ; Fri, 16 Jul 2021 22:58:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CC9C92A499 for ; Sat, 17 Jul 2021 02:58:49 +0000 (UTC) X-FDA: 78370572378.12.CA0FF13 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 8FCB150254DA for ; Sat, 17 Jul 2021 02:58:49 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id p186so12912460iod.13 for ; Fri, 16 Jul 2021 19:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q+JKIv6hqPelr3xZyX4AN/xjnr9/KSPz21ndUrNdfWk=; b=gZB3XFs4YctFWRQcr3AIXjtExL95BV7PdCJGicm2Gr6SgUuXoZQWDPEzcXJDzhcENt BRFsO0Z9jJ7EOrIHBxA3wrRXn6ggBhqRvnQ0CVxDuWIGyGXzW534e581qFbDd2mo6kMM PoZF73m02ZKgaYSYk71151mbUwxR1WPCjP0ZdcPmsbYa2dMwBOkKy7mybG3Zu6/lRktW miAiWCRQyiAQQDhBvtGD1LWToxcC11v0WWvGN9fS7iS3mkJpXxpEC/wc7NouIJ4ZC/pz o+gCE4YveOiuhTwWz3WLFJC8KMbZasTHafFrYjNKaXknstxN+axL4ofpbNY8p2dfvUP0 sVXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+JKIv6hqPelr3xZyX4AN/xjnr9/KSPz21ndUrNdfWk=; b=Ax+Dnfe418I49n0LLsdd9qUycp7iKbfTZGPNYBxOpxpx0lMNB51ZDhJuyzk9ELHcqG vJU6/nbhOvoXD1kiGN+2N9i+e9/VzEMjpc0kAS0VAjKQbUw/xs1BboP8x9uEpUUxXWJ8 CCku6wwEaxsuAs2v2wTADE7a8esK3Yg2F8X21gy2pmKAV7nJnnRahYf36zzx6Gw/vbAI rnM5e2wEX/iUXajC4GnGpbXQuHj2YX2aN6RM+kAWk2yxRCAPx9LYaXcYw7aqwzqguzxX Ew0Y3h5amBVGYPxampw0DSgO5XPpMbI/gMQAy4MQ0J9hqS9vZoHrB/rcg27q3rtdGFdy jJ+g== X-Gm-Message-State: AOAM5313MfPbsb7t/0o1FXltOEyamHmTtxDPP1l+c4z4Xr6wxYww+pxZ j/xfiMHPzvu4wjCFOxq+gFjMVXnfXyxm+2Y6SzO2Mw== X-Google-Smtp-Source: ABdhPJxDKnBkegYHanD7zJwcvdIx+ZQrUXzneHtsWj+SRasMpccY2hK3i9cO2t/21SQnvSisrpoUY8PjATBolBy1zmE= X-Received: by 2002:a5d:8888:: with SMTP id d8mr9778897ioo.170.1626490728818; Fri, 16 Jul 2021 19:58:48 -0700 (PDT) MIME-Version: 1.0 References: <20210619092002.1791322-1-pcc@google.com> In-Reply-To: From: Peter Collingbourne Date: Fri, 16 Jul 2021 19:58:37 -0700 Message-ID: Subject: Re: [PATCH v4] mm: introduce reference pages To: Matthew Wilcox Cc: John Hubbard , "Kirill A . Shutemov" , Andrew Morton , Catalin Marinas , Evgenii Stepanov , Jann Horn , Linux ARM , Linux Memory Management List , kernel test robot , Linux API , linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8FCB150254DA X-Stat-Signature: zy497bzpzar14psg9e537sbh4q8314em Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=gZB3XFs4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of pcc@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=pcc@google.com X-HE-Tag: 1626490729-266805 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 28, 2021 at 6:11 AM Matthew Wilcox wrote: > > On Sat, Jun 19, 2021 at 02:20:02AM -0700, Peter Collingbourne wrote: > > +++ b/include/linux/mm.h > > @@ -32,6 +32,7 @@ > > #include > > #include > > #include > > +#include > > No. This was because is_refpage_vma needed to access vm_file->f_op to check whether the mapping is a reference page. In v5 I've moved that part of the check into mm/refpage.c. > > +++ b/include/linux/mman.h > > @@ -2,6 +2,7 @@ > > #ifndef _LINUX_MMAN_H > > #define _LINUX_MMAN_H > > > > +#include > > No. Okay, this one was entirely unused; removed. Peter