From: Peter Collingbourne <pcc@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: John Hubbard <jhubbard@nvidia.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Evgenii Stepanov <eugenis@google.com>,
Jann Horn <jannh@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kernel test robot <lkp@intel.com>,
Linux API <linux-api@vger.kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4] mm: introduce reference pages
Date: Fri, 16 Jul 2021 19:58:37 -0700 [thread overview]
Message-ID: <CAMn1gO5GiMwanh2pHk7-BNo0UoSbyxkjAjjdK6URMESR6MCY=Q@mail.gmail.com> (raw)
In-Reply-To: <YNnKSkcAM05tmPta@casper.infradead.org>
On Mon, Jun 28, 2021 at 6:11 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Sat, Jun 19, 2021 at 02:20:02AM -0700, Peter Collingbourne wrote:
> > +++ b/include/linux/mm.h
> > @@ -32,6 +32,7 @@
> > #include <linux/sched.h>
> > #include <linux/pgtable.h>
> > #include <linux/kasan.h>
> > +#include <linux/fs.h>
>
> No.
This was because is_refpage_vma needed to access vm_file->f_op to
check whether the mapping is a reference page. In v5 I've moved that
part of the check into mm/refpage.c.
> > +++ b/include/linux/mman.h
> > @@ -2,6 +2,7 @@
> > #ifndef _LINUX_MMAN_H
> > #define _LINUX_MMAN_H
> >
> > +#include <linux/fs.h>
>
> No.
Okay, this one was entirely unused; removed.
Peter
next prev parent reply other threads:[~2021-07-17 2:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 9:20 Peter Collingbourne
2021-06-28 12:24 ` Kirill A. Shutemov
2021-07-17 2:58 ` Peter Collingbourne
2021-06-28 13:10 ` Matthew Wilcox
2021-07-17 2:58 ` Peter Collingbourne [this message]
2021-06-28 19:33 ` Matthew Wilcox
2021-06-28 19:44 ` John Hubbard
2021-06-28 19:56 ` Matthew Wilcox
2021-07-17 2:58 ` Peter Collingbourne
2021-06-29 7:19 ` John Hubbard
2021-06-29 11:58 ` Matthew Wilcox
2021-06-29 17:48 ` John Hubbard
2021-06-29 18:21 ` Matthew Wilcox
2021-06-29 18:28 ` John Hubbard
2021-07-17 2:59 ` Peter Collingbourne
2021-07-19 20:47 ` David Hildenbrand
2021-07-19 20:50 ` David Hildenbrand
2021-07-19 22:26 ` Peter Collingbourne
2021-07-19 22:30 ` John Hubbard
2021-07-20 7:28 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMn1gO5GiMwanh2pHk7-BNo0UoSbyxkjAjjdK6URMESR6MCY=Q@mail.gmail.com' \
--to=pcc@google.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=eugenis@google.com \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox