From: Peter Collingbourne <pcc@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Marco Elver <elver@google.com>,
andrey.konovalov@linux.dev,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints
Date: Thu, 23 Feb 2023 22:45:07 -0800 [thread overview]
Message-ID: <CAMn1gO4_+-0x4ibpcASy4bLeZ+7rsmjx=0AYKGVDUApUbanSrQ@mail.gmail.com> (raw)
In-Reply-To: <20230215143306.2d563215@rorschach.local.home>
On Wed, Feb 15, 2023 at 11:33 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 15 Feb 2023 09:57:40 +0100
> Marco Elver <elver@google.com> wrote:
>
> > Yes, you are right, and it's something I've wondered how to do better
> > as well. Let's try to consult tracing maintainers on what the right
> > approach is.
>
> I have to go and revisit the config options for CONFIG_FTRACE and
> CONFIG_TRACING, as they were added when this all started (back in
> 2008), and the naming was rather all misnomers back then.
>
> "ftrace" is really for just the function tracing, but CONFIG_FTRACE
> really should just be for the function tracing infrastructure, and
> perhaps not even include trace events :-/ But at the time it was
> created, it was for all the "tracers" (this was added before trace
> events).
It would be great to see this cleaned up. I found this aspect of how
tracing works rather confusing.
So do you think it makes sense for the KASAN tests to "select TRACING"
for now if the code depends on the trace event infrastructure?
Peter
next prev parent reply other threads:[~2023-02-24 6:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 17:17 andrey.konovalov
2022-10-18 17:17 ` [PATCH v3 2/3] kasan: migrate kasan_rcu_uaf test to kunit andrey.konovalov
2022-10-18 17:17 ` [PATCH v3 3/3] kasan: migrate workqueue_uaf " andrey.konovalov
2023-02-14 1:21 ` [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Peter Collingbourne
2023-02-14 6:07 ` Marco Elver
2023-02-15 2:55 ` Peter Collingbourne
2023-02-15 8:57 ` Marco Elver
2023-02-15 19:33 ` Steven Rostedt
2023-02-24 6:45 ` Peter Collingbourne [this message]
2023-05-01 22:02 ` Peter Collingbourne
2023-05-01 22:30 ` Nick Desaulniers
2023-05-05 13:58 ` Steven Rostedt
2023-12-11 16:37 ` Paul Heidekrüger
2023-12-11 17:50 ` Andrey Konovalov
2023-12-11 18:59 ` Paul Heidekrüger
2023-12-11 20:51 ` Andrey Konovalov
2023-12-11 22:47 ` Paul Heidekrüger
2023-12-11 22:56 ` Marco Elver
2023-12-11 23:35 ` Paul Heidekrüger
2023-12-11 23:37 ` Andrey Konovalov
2023-12-12 9:19 ` Paul Heidekrüger
2023-12-12 9:32 ` Marco Elver
2024-01-07 18:22 ` Paul Heidekrüger
2024-02-05 11:34 ` Paul Heidekrüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMn1gO4_+-0x4ibpcASy4bLeZ+7rsmjx=0AYKGVDUApUbanSrQ@mail.gmail.com' \
--to=pcc@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox