From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A489C43334 for ; Fri, 24 Jun 2022 14:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F346C8E0229; Fri, 24 Jun 2022 10:43:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBC9B8E020E; Fri, 24 Jun 2022 10:43:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5D3F8E0229; Fri, 24 Jun 2022 10:43:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C334B8E020E for ; Fri, 24 Jun 2022 10:43:00 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 8787480315 for ; Fri, 24 Jun 2022 14:43:00 +0000 (UTC) X-FDA: 79613396520.11.8A37949 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf09.hostedemail.com (Postfix) with ESMTP id D979F140027 for ; Fri, 24 Jun 2022 14:42:59 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id q9so3024676ljp.4 for ; Fri, 24 Jun 2022 07:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c74mHiS9ndNQXugtz6cvlyHO4YfoU5Amna4jcCNFMrs=; b=H/ksdZ6l5zr/vi1yB0rt5Eri5/yAGDIDhJ+WxLtjolC+ufKy6G6zPlGl+RRyQ8X0yb KHR8ASjiTXJXazdAdIrcuZ2Cs25VbGzQxT++z2kemk7qCE31TwlEGNOFZz1VF98ViVgG DVB/LJous1QnTbkIZZt+g4YbndYf5ChpQiC4rpkQ5ReCIQTQumhdcGb/4pood8k+SwZN paHcsBmYu6mMMyQfqBR3cSwe3jcLr2EN+96eNG+ci+lB+YDn35X5J9KksySor56ctnXt T4lmVaUFlX5DI1QNKrmef517KCnrYSiznbpl/5KssWEh9sSpuWq7z0YsqPsbLgD3MCFS uQtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c74mHiS9ndNQXugtz6cvlyHO4YfoU5Amna4jcCNFMrs=; b=V+gW0V5a0v2Po2z85cz2SNrPfRzmZnipsB9FQVJsaORfAMkZIkZbZCecBOpUNTUn5M huCMz3qxS71bQ+kOIMjcNizdowWLs2vSNVCB1VtvdWq9auTEWeXWY2fkMjjh3XbIikrQ 0eKprv8L8jTMfBChkkPopAiWnRMzK/RsfhHIMs2au+xBseYGFNtMThrknnnv022fYBRn 32Y2l2yZwnvK1fOyA7re2Wq607QguvQWQXkDpnjSjuzp7rTjVPQ/k/gwD++LZR2pcT+Y Nj3k8JwK/Lub4atwIi8LsxdoVhzsGfY7RG2XX4YQ4DdrhEH0PpzhrRh886Z6wnL1DdNe IzGA== X-Gm-Message-State: AJIora8kqDgsT0IBQajPGW/HQ6Dw3vCIu4WJWrx92ZBpWbK+vlwq86sT bG/ECFCF4+vWLbdpvgiVVOD4kgg6g/VFfNmoarQxrA== X-Google-Smtp-Source: AGRyM1vYszCbgCJkIeTLTax5rPL2YqFzl1LowMYrI+vR1nuQeKj/955rGAXK6XhwauP1YAq9QkIKvVeNZu/Zq5Nkw8Y= X-Received: by 2002:a05:651c:1549:b0:258:4386:f6a2 with SMTP id y9-20020a05651c154900b002584386f6a2mr7672748ljp.527.1656081778232; Fri, 24 Jun 2022 07:42:58 -0700 (PDT) MIME-Version: 1.0 References: <6d5c899030b113755e6c093e8bb9ad123280edc6.1655761627.git.ashish.kalra@amd.com> In-Reply-To: <6d5c899030b113755e6c093e8bb9ad123280edc6.1655761627.git.ashish.kalra@amd.com> From: Peter Gonda Date: Fri, 24 Jun 2022 08:42:46 -0600 Message-ID: Subject: Re: [PATCH Part2 v6 24/49] KVM: SVM: Add KVM_SEV_SNP_LAUNCH_START command To: Ashish Kalra Cc: "the arch/x86 maintainers" , LKML , kvm list , linux-coco@lists.linux.dev, linux-mm@kvack.org, Linux Crypto Mailing List , Thomas Gleixner , Ingo Molnar , Joerg Roedel , "Lendacky, Thomas" , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , Tony Luck , Marc Orr , Sathyanarayanan Kuppuswamy , Alper Gun , "Dr. David Alan Gilbert" , jarkko@kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="H/ksdZ6l"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of pgonda@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=pgonda@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656081779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c74mHiS9ndNQXugtz6cvlyHO4YfoU5Amna4jcCNFMrs=; b=sIxDUy9zCkluDv2q85gi5pRtrWP4td74dmFt2AkPFOx7DVjlWYr1drvO1kpOv50hR2Ecb0 tG+KWHKXEBHSh3l2+DFPK7smzdMnhjFhnUeiBX/U7GiOkO4gIYNJCqp0TyynhsZ84UEEh3 aaMPY8f5fMOiLru/6p+bnwEXmMIbcR4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656081779; a=rsa-sha256; cv=none; b=Xt5F8KW7paeiy0UBMJ5fkhA7eVoq3TFtYuvbvXNrfSC0QQdNXVfJuxXKoY9j30SlAB443T Pp8JAcFY9dKtzP/szkoWoD6P43SaRlYB8qS78yrfp4GXc5p7a1KJrOKSk6u9HzPzn7wxAF Ac4XfUSSoyfoM2N2fvrKB+9du9pRqh4= X-Stat-Signature: fbkjmpo3mcf5rn1psz5xpgc758ri5g5k X-Rspamd-Queue-Id: D979F140027 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="H/ksdZ6l"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of pgonda@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=pgonda@google.com X-Rspamd-Server: rspam12 X-HE-Tag: 1656081779-542471 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > +19. KVM_SNP_LAUNCH_START > +------------------------ > + > +The KVM_SNP_LAUNCH_START command is used for creating the memory encryption > +context for the SEV-SNP guest. To create the encryption context, user must > +provide a guest policy, migration agent (if any) and guest OS visible > +workarounds value as defined SEV-SNP specification. > + > +Parameters (in): struct kvm_snp_launch_start > + > +Returns: 0 on success, -negative on error > + > +:: > + > + struct kvm_sev_snp_launch_start { > + __u64 policy; /* Guest policy to use. */ > + __u64 ma_uaddr; /* userspace address of migration agent */ > + __u8 ma_en; /* 1 if the migtation agent is enabled */ migration > + __u8 imi_en; /* set IMI to 1. */ > + __u8 gosvw[16]; /* guest OS visible workarounds */ > + }; > + > +See the SEV-SNP specification for further detail on the launch input. > + > References > ========== > > > +static int snp_decommission_context(struct kvm *kvm) > +{ > + struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; > + struct sev_data_snp_decommission data = {}; > + int ret; > + > + /* If context is not created then do nothing */ > + if (!sev->snp_context) > + return 0; > + > + data.gctx_paddr = __sme_pa(sev->snp_context); > + ret = snp_guest_decommission(&data, NULL); Do we have a similar race like in sev_unbind_asid() with DEACTIVATE and WBINVD/DF_FLUSH? The SNP_DECOMMISSION spec looks quite similar to DEACTIVATE. > + if (WARN_ONCE(ret, "failed to release guest context")) > + return ret; > + > + /* free the context page now */ > + snp_free_firmware_page(sev->snp_context); > + sev->snp_context = NULL; > + > + return 0; > +} > + > void sev_vm_destroy(struct kvm *kvm) > { > struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;