From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A66C433F5 for ; Mon, 3 Oct 2022 18:01:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 414508E0001; Mon, 3 Oct 2022 14:01:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C3A56B0073; Mon, 3 Oct 2022 14:01:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 264328E0001; Mon, 3 Oct 2022 14:01:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 11A0F6B0071 for ; Mon, 3 Oct 2022 14:01:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C94F81C1861 for ; Mon, 3 Oct 2022 18:01:33 +0000 (UTC) X-FDA: 79980405666.17.98C18E8 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf27.hostedemail.com (Postfix) with ESMTP id 2C84740019 for ; Mon, 3 Oct 2022 18:01:32 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id s17so2368348ljs.12 for ; Mon, 03 Oct 2022 11:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=D28XvKTv00teVfLwfyN9M9/AZIufFU4k2cieAlFfcPU=; b=JcyhKWsgCnYxPgaWsHHffDyudEL3s19lLgvoma891PS50XIYA8Q1I6Qj3806CkR5QX fSv8It+f/TW2tXXqcCUQ7TxUSYPfNe8+8N5Bj5S3UXuze44v1O8BJzpkS9mkbdteBiLu aSCE7q78XIVq8PxbqWk0bKpBWA0yNOZiKA/lI6N+FCmHJ9T8cfW4lEp5wGbUSjfKOI0Z a2+5EY+hoxySnbW4SBcjwLdCvMZ1G/HCykEqo8Q8PbJIArj9FtV/AUEo1kHH5moRUZB/ VbN4atttazrqqWo+h0VQpAPKpxkf81kdlYojEVeANjKaqxtJl1x3ykgLW3zO2w5Y+IW4 Q1aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=D28XvKTv00teVfLwfyN9M9/AZIufFU4k2cieAlFfcPU=; b=krc7tkqV69RjpAEReOLOBku05IS4yK2pXQ0GVLrNin+6kqse9kAJFABvZ7gRd7MJyJ xeNRul0huE1jXFcTbd1piL0uB/QgFoTx/U9pn+UdAW6P09VB/UypfMadGc73KRHY/GXe imEqpLLXQnF2YLhyjaE7aiic75rzqBVV29EtB0dgBm3ZLDerClP8u1uK6EEH8spqOPX8 DCvAG8V5I9R4wm5go2WZRcWflvWlWbUZvMNrU3ikjc1Q+nIMPXx9jIdZGJjT9VUJoA/x i+NR2N6pyszvxcnA+f0x1tudxHC89t9kJHwlY41vuR92QzYmye+qzBWSVWEF2aIwZzdR Mp4g== X-Gm-Message-State: ACrzQf21R6O1VoMd46zD8pviztzZyE9FfVe8a29gUzQhdfVX5yW+2Hqo FUCs4y6o7r5adal9RI/x9ALwfn85djdMAvQD2buteQ== X-Google-Smtp-Source: AMsMyM5M6uuSJYdYJkQ0du2kR5gu7HOYyUAaIPU4am61T5nEJo87sAVKGohiuCMu/kOpo2mdhzNUGNGB7bAsVkCoVdc= X-Received: by 2002:a05:651c:1510:b0:26d:cd1d:cc4d with SMTP id e16-20020a05651c151000b0026dcd1dcc4dmr3496274ljf.502.1664820091240; Mon, 03 Oct 2022 11:01:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Gonda Date: Mon, 3 Oct 2022 12:01:19 -0600 Message-ID: Subject: Re: [PATCH Part2 v6 13/49] crypto:ccp: Provide APIs to issue SEV-SNP commands To: Borislav Petkov Cc: "Kalra, Ashish" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "Lendacky, Thomas" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "dovmurik@linux.ibm.com" , "tobin@ibm.com" , "Roth, Michael" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "marcorr@google.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "dgilbert@redhat.com" , "jarkko@kernel.org" Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664820093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D28XvKTv00teVfLwfyN9M9/AZIufFU4k2cieAlFfcPU=; b=LvlWnRys7BfNr1+a92cNehcwm4pZuQE4EgkfXztVqPEooUBu2vsx0Jrmkb/jEX906lpWpA va9fsDdun30Ki5qUl7uFU/lphBeAKfu/TGGX7xDa5yLFq9cxJ5vEMw0/76K/58i8JNDsY3 7rmUejcMBElnxBs944QdsGGaTQkNCRY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JcyhKWsg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of pgonda@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=pgonda@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664820093; a=rsa-sha256; cv=none; b=0a7+XJDvbccjcFLJT6uy8cTt83uyGQOLGToaCv4QHTU7EOAeMAuaobtjTyKeb0qn7rOPbt L1070aTXaNgzOf+iyQ7J03wRHiItgqCxqbdKaXwi0VG3+cP5Qtip9XHC6OtvGQIr5YVSFG PaOBj3m7560ykDl5/E5S6RqBbbVG/NA= X-Rspamd-Queue-Id: 2C84740019 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JcyhKWsg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of pgonda@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=pgonda@google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: 8ogtej6ubffd875ij7s41nqrsayf3fim X-HE-Tag: 1664820092-810071 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 3, 2022 at 11:45 AM Borislav Petkov wrote: > > On Mon, Oct 03, 2022 at 05:11:05PM +0000, Kalra, Ashish wrote: > > They are basically providing the APIs for the hypervisor to manage a > > SNP guest. > > Yes, I know. But that is not my question. Lemme try again. > > My previous comment was: > > "I think you should simply export sev_do_cmd() and call it instead." > > In this case, the API is a single function - sev_do_cmd() - which the > hypervisor calls. > > So my question still stands: why is it better to have silly wrappers > of sev_do_cmd() instead of having the hypervisor call sev_do_cmd() > directly? We already have sev_issue_cmd_external_user() exported right? Another option could be to make these wrappers more helpful and less silly. For example callers need to know the PSP command format right now, see sev_guest_decommission(). int sev_guest_decommission(struct sev_data_decommission *data, int *error) Instead of taking @data this function could just take inputs to create sev_data_decommission: int sev_guest_decommission(u32 handle, int *error) > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette