From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D29C43334 for ; Mon, 13 Jun 2022 11:25:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D7098D017C; Mon, 13 Jun 2022 07:25:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45FBD8D0171; Mon, 13 Jun 2022 07:25:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D9538D017C; Mon, 13 Jun 2022 07:25:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1926D8D0171 for ; Mon, 13 Jun 2022 07:25:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE60935284 for ; Mon, 13 Jun 2022 11:25:30 +0000 (UTC) X-FDA: 79572982020.25.64CC2F4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 1BDC7800B0 for ; Mon, 13 Jun 2022 11:25:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EF4B0B80EA7 for ; Mon, 13 Jun 2022 11:25:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB89CC3411F for ; Mon, 13 Jun 2022 11:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655119526; bh=7W3RCHPt+tsv4dUVuAHZPUmYNjQsn6MQMQZiltiHPMo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lz9aX51p9vnNh7GeV0d19q/w5CU5B8C3AGUXkPandnTViBXtZ/EoAW5D1HeiTuiW1 N/XBH2BADaFpoQJnNWp7c0oY55VDh+DOY7ubLbVbstpgM1GA0In5GVpQOnrPMZAy0B Nhdte+wK2LnWY3bUDvfDdbGB7Z+4Jb7hMh16BxmNAHNwTAzf73UmHiQdW4lIZ6i9e0 gxO99Cr1N1av5effs5Q5uA1lkJh6dCxGPMAsgeE7+ykTaw3rDud6LSSU4I658arYdo vlYbtTPlsWiXzYHmkBqtgWZqyx1Mwt0pByO5t3BZGj0X1i6BwSnjrZpR3q4HFjch96 tFF6X6NmDU1wA== Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-f2a4c51c45so7959228fac.9 for ; Mon, 13 Jun 2022 04:25:26 -0700 (PDT) X-Gm-Message-State: AOAM533HEekISp3GW8TlISE1g6RzutSjSVrcM/C1ymLYijbWQZhL5w89 uXckBgdHfGiEC0d691TfEr3MvnPAt4/e9k1ZWyI= X-Google-Smtp-Source: ABdhPJwye+3Ce8gz8k+4lo9ehXOBU1aZPcGoJ+NlVwPSgSQ16T74tDI4+9Z8khhO9pTdsWAwon+Bdee0S9o3i5/Vjzs= X-Received: by 2002:a05:6871:5c8:b0:f3:3c1c:126f with SMTP id v8-20020a05687105c800b000f33c1c126fmr7435011oan.126.1655119515578; Mon, 13 Jun 2022 04:25:15 -0700 (PDT) MIME-Version: 1.0 References: <20220613082147.183145-1-mawupeng1@huawei.com> <20220613082147.183145-7-mawupeng1@huawei.com> In-Reply-To: From: Ard Biesheuvel Date: Mon, 13 Jun 2022 13:25:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 6/6] memblock: Disable mirror feature if kernelcore is not specified To: Mike Rapoport Cc: Wupeng Ma , corbet@lwn.net, will@kernel.org, catalin.marinas@arm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, david@redhat.com, anshuman.khandual@arm.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655119530; a=rsa-sha256; cv=none; b=4/GA/Ca0YOET10gUHlb9oASXEJ+5SsjxOa28XmblF1QrARgAiKX/FDihrZjwK/m0uAUWJg ZG6n9/O8bTzatVLNrkuOexoOIiK6Qhx8e4+kOurYyBjQ4Oy5uavLmP4Pgdq/KpNgEbzhm5 XleD0LhCsfkPNynJfdhEAT2IRAssN0c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655119530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n1NgkujWOj8l1Qb1xZ8cVtA+TLJef4PyaPOXodeN+u0=; b=fK7SJUJh5iTdPLN8fNBxEZxPobm/gPCrEo2M9mvZ8oPyVgSJHuD5Cof466I/6rNVAXJX0d e0gGn7k303vvTSomDyOR1J8ubOeVEUH/JVRXvXp7rXNon8RDjqAIN2IWoR8mlK46kQD1in CyvcYZ0Gz2J1XKSDfAeTwbRwX+Lm2e0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lz9aX51p; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of ardb@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ardb@kernel.org Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lz9aX51p; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of ardb@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ardb@kernel.org X-Stat-Signature: k7m7r781bkcn5k8mcu4dsir1hx94fmw9 X-Rspamd-Queue-Id: 1BDC7800B0 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1655119529-920292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Jun 2022 at 13:05, Mike Rapoport wrote: > > On Mon, Jun 13, 2022 at 04:21:47PM +0800, Wupeng Ma wrote: > > From: Ma Wupeng > > > > If system have some mirrored memory and mirrored feature is not specified > > in boot parameter, the basic mirrored feature will be enabled and this will > > lead to the following situations: > > > > - memblock memory allocation prefers mirrored region. This may have some > > unexpected influence on numa affinity. > > > > - contiguous memory will be split into several parts if parts of them > > is mirrored memory via memblock_mark_mirror(). > > > > To fix this, variable mirrored_kernelcore will be checked in > > memblock_mark_mirror(). Mark mirrored memory with flag MEMBLOCK_MIRROR iff > > kernelcore=mirror is added in the kernel parameters. > > > > Signed-off-by: Ma Wupeng > > --- > > mm/internal.h | 2 ++ > > mm/memblock.c | 3 +++ > > mm/page_alloc.c | 2 +- > > 3 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index c0f8fbe0445b..ddd2d6a46f1b 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -861,4 +861,6 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > > > > DECLARE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > > > +extern bool mirrored_kernelcore; > > + > > #endif /* __MM_INTERNAL_H */ > > diff --git a/mm/memblock.c b/mm/memblock.c > > index b1d2a0009733..a9f18b988b7f 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -924,6 +924,9 @@ int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size) > > */ > > int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) > > { > > + if (!mirrored_kernelcore) > > + return 0; > > + > > Hmm, this changes the way x86 uses mirrored memory. > This change makes sense for x86 as well, but we should get an Ack from x86 folks. > Also, on second thought, I don't think marking as mirror is what should be affected by the policy. Instead, choose_memblock_flags() should take this into account, in a way that we could refine later if needed.