From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD12C77B7C for ; Fri, 12 May 2023 11:01:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DECB06B0071; Fri, 12 May 2023 07:01:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9DCC6B0074; Fri, 12 May 2023 07:01:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C648B6B0075; Fri, 12 May 2023 07:01:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B7B0E6B0071 for ; Fri, 12 May 2023 07:01:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7AD46160F3B for ; Fri, 12 May 2023 11:01:26 +0000 (UTC) X-FDA: 80781311772.05.6A647DC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 9B450C0037 for ; Fri, 12 May 2023 11:01:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c+TBR77M; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of ardb@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ardb@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683889277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1LmljYcNSoh3f14QbspK6/Wtrw6bPBoRX996WfqJEcg=; b=Z+CBshSqndffbAhXOQWWhSoJ8/gbMQyK9Z6RsNulvAU9N/P21EwVJyYrm4vfbfFiM83+/g VinwTg8hWnAJQwNofLz7HB4sHGKfFBve+gbyEkdXrPAZRzxsWcUTgLk5Xt4sSdphtHjih5 bGO9rb1PTQZHWoGkLkffRJUSdKSLYO8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c+TBR77M; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of ardb@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ardb@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683889277; a=rsa-sha256; cv=none; b=BD/csqp7MPbhtHOcK1yK5QmyMp2OU9AEJZneZB4EGA2pXnZdBcK8Tip+5HifgtBvQQI2KL yqm3VMVjyM3UvFpBaJgyVO9+b3f7+pI9S70/z5mVmOfJKk91JJHr4J3vfuiuTaTQ8/rq41 a3VIto01Dlka1S/mSHWXZ0z7pZmTX3o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 977FC65560 for ; Fri, 12 May 2023 11:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31B1DC43443 for ; Fri, 12 May 2023 11:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683889275; bh=WfMo/UCIoEAhIuI192bDSMME0+1kDUpIrgATnnqtCsM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=c+TBR77M4V+MLrEbx3zrrJ4/a8+IDr2YL33BtcYUwPIvSxPr/r2G8l2K4NsK6Fy97 8+f3fW80e8nIiX7Xonx9W+Uw4mnmGsx/G7R7aGHXI+xJEDO/aCMGCDl03aXIt4Qv4q E033s8QK58HpL5V7+/9PR2Id1fApkv8h59WJu8BbiK4tujxC/uYxKQsWeiM00xUMsg l5jpmCH4h751EpnI0Q+3IOKxwf3y32ZY58Cv/qkNJ5nWBDHZzR65rMjnVAYXYCnTK6 uOBYvkHHruKD80eVRxFlJDfCGUOLaZ7j3iJJPfut+kggGxFl/Xfc0SWJvIryAt1Qqt n1o/ysaCNUGJA== Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4f13ef4ad91so11410907e87.3 for ; Fri, 12 May 2023 04:01:15 -0700 (PDT) X-Gm-Message-State: AC+VfDxwZI8Xzk5Fbj6TYDOMeHPV7whOWIP9g925CdIXMg0ygfoj/Uwt lo6CIfJfJBx+M2kq85dW/x2S7z9FzzLrPrulODY= X-Google-Smtp-Source: ACHHUZ7VTszyNtMqIQDilUbtOaY3L0FxW7t6tphZiH7wZTs+ubZ5Ew8B500wu/GUWe6sp5Gkp5rP8abtaJQ7Qm8Dnjo= X-Received: by 2002:a05:6512:961:b0:4eb:7e:1fa5 with SMTP id v1-20020a056512096100b004eb007e1fa5mr3761436lft.8.1683889272855; Fri, 12 May 2023 04:01:12 -0700 (PDT) MIME-Version: 1.0 References: <20230507234618.18067-1-kirill.shutemov@linux.intel.com> <20230507234618.18067-5-kirill.shutemov@linux.intel.com> <20230508190043.ouauzbghn27khdy4@box.shutemov.name> <20230509005634.qtuiodpirexbxu2k@box.shutemov.name> <20230512015909.2fj7bmp3ejc3owhs@box.shutemov.name> <20230512105919.lgy3cvio6m2vcygn@box.shutemov.name> In-Reply-To: <20230512105919.lgy3cvio6m2vcygn@box.shutemov.name> From: Ard Biesheuvel Date: Fri, 12 May 2023 13:01:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv10 04/11] efi/x86: Implement support for unaccepted memory To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ij61uutoz19xy3d5sqcq1nehq5qyf8ui X-Rspam-User: X-Rspamd-Queue-Id: 9B450C0037 X-Rspamd-Server: rspam07 X-HE-Tag: 1683889277-592343 X-HE-Meta: U2FsdGVkX18NuaYPbB8A1SYz5WsJwMuGTxZEGTm5LZvxwKek6AebcUjabtj6goulik+6SaUxfzwfncgnl7HKNYkjDdVdtmmR2f7DIp987PgHcQxqVZW+xuiqYNeHLQyuyYo6sTTNJB5n6tOybssiUTfroFCrb7ucWdMqm5QrQ+HMNKc2ue1cScyX61udcpYCB3+pT5h+KstaE34VB3OZFNTrfuhQRqhFCxvyUfevBKk0Cr4AoZWP9BIqlStd2ZzGMrjP0fNVaAjYJfiXnO4Ml79pUOnRhwdksZeek4Q6wcwuYydBaNF1i3XN/gUMNB+5hC07VJvqaxWXWLubQvfn2Eqs4wXl+BbmUYms3r6K2d7Xgb3vrsZDF+ol/r1MNwjRBp3MN4JyLdPqZ3RGCdXROCXXI8nkw/y81n4FMPBjv2vTJp5GENYheUwDP7KX7qBuJYNG4hswPTyeeXGQNaA2bdV6+jXiUIH1lxT8vmayEYJlNOoWxHMQHFnaBqLEV8Lgy1q+ur28ZkWJVRFFJQEIuPaO8YO/ck+XC/Va4NLvpjSouUz/sy5mzbE3wMhvmVNo2glWynvXtS69BrB75bNX21bUbt/AbfELZPYx/ZCRy3nF61/De7AcZRDEU4M4fLiyRKpSRl1Fr91RhZnAW+0omPNB1aSnb1qbxgb40CLxHhC5ncnoR1JgWi+X+7V6xN+/+bk6YMZd3NI7id0H/9Hd/U/1XDEPiEOJRYTHHw+eCWEs9JpUap/awnfuFTzFxzvxl2yZK6o7GOsYeWmvyZd27xzU9PQIDKTIV/cZ3s6MVBjcC0AVX9iZVaYp7BQGqqVrLJTWLoBP6IrFWJLoBGZ51w68A/3cDfmr+UFCWvZ+kKtFWbcc0fCjGsHJ3YFeLy2ddMfHGw0uu4Bnb+TmnX+K8EIXFQAfjVftj8FmjsNXNHu/fraS01c+dwBpGU0zU75MexULiiIb/Mxldk8uBjv DLt/nBv8 rDRhqtXZ9BQsIAI3UUw0/TeVQu2bYj2/DaLkZ4Hgw+RFzh4FSgMAteQncbPoqulmAt3MRpFCOqlK66zFF/brEmrTswcR9WtkReniOSBGju50qJafcW99F/7i6Yh+VRwNGm6W2maBbxlkFVTEM2x7x6cAW9RnGtIW/+M69i1YqG8pvjwTj6btUobL7Lj2mWW0D62igpKFVAUY1wpf7B8/LjuAOFeOpm09Xs3nACiCaDCMdL1nVvjDJMYQn5yG+EcALKNKo0Bxufe/BSvwLDl8FPRlTrkj6/MB6s5KzkGg0JA+RucUT/oEyudo6AgX0P+4spL2eQjOPfoNLZr7M4n1WlYVJeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 12 May 2023 at 12:59, Kirill A. Shutemov wrote: > > On Fri, May 12, 2023 at 09:39:30AM +0200, Ard Biesheuvel wrote: > > Please replace PMD_SIZE with something along the lines of > > EFI_UNACCEPTED_UNIT_SIZE and #define it to PMD_SIZE in > > arch/x86/include/asm/efi.h. > > > > The comment below about the size of the bitmap vs the size of the > > address space should probably move there as well. > > Okay, will do. > > > > +void accept_memory(phys_addr_t start, phys_addr_t end) > > > +{ > > > + unsigned long range_start, range_end; > > > + unsigned long bitmap_size; > > > + u64 unit_size; > > > + > > > + if (!unaccepted_table) > > > + return; > > > + > > > + unit_size = unaccepted_table->unit_size; > > > + > > > + /* > > > + * Only care for the part of the range that is represented > > > + * in the bitmap. > > > + */ > > > + if (start < unaccepted_table->phys_base) > > > + start = unaccepted_table->phys_base; > > > + if (end < unaccepted_table->phys_base) > > > + return; > > > + > > > + /* Translate to offsets from the beginning of the bitmap */ > > > + start -= unaccepted_table->phys_base; > > > + end -= unaccepted_table->phys_base; > > > + > > > + /* Make sure not to overrun the bitmap */ > > > + if (end > unaccepted_table->size * unit_size * BITS_PER_BYTE) > > > + end = unaccepted_table->size * unit_size * BITS_PER_BYTE; > > > + > > > > Should we warn here? > > No. accept_memory() is nop for conventional memory (memblock calls it > unconditionally). > > With the fixup, we only allocate bitmap for the range of physical address > space where we have unaccepted memory. So if there's conventional memory > after unaccepted, bitmap will not cover it. > Fair enough.