From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B50CDCDB474 for ; Tue, 17 Oct 2023 15:36:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36AE38003E; Tue, 17 Oct 2023 11:36:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31B7F80009; Tue, 17 Oct 2023 11:36:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E2A18003E; Tue, 17 Oct 2023 11:36:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0A97680009 for ; Tue, 17 Oct 2023 11:36:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0BBF140D33 for ; Tue, 17 Oct 2023 15:36:48 +0000 (UTC) X-FDA: 81355356096.29.1C28D7B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id D758AA001E for ; Tue, 17 Oct 2023 15:36:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a02DY55D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of ardb@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ardb@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697557007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zQqT0Icijbvg9S6mB1pNR2Pch3/DSe5rsPVyjDgEit0=; b=As8hU8jFYWwNPG/Q6ek4teDqFlSzmnCiWOUaTWYC1VRbwVxGN8Xs4+isAGgiI9ivJLE6QQ yENF7oh0Wyo9rey6ZgzKm7a+FGGOjHndynpzxh/FO3EDTna9pRJDd77nPMlNIdx9dt7Kw5 i/+bcZgsyZYn2M7gTir/S5IZihlVRN8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a02DY55D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of ardb@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ardb@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697557007; a=rsa-sha256; cv=none; b=uf6k7hX2sU9koK1ozHU/r6WcaGzJ4XMkbSYGvNoO8ow1o5SANevFW3i41pdZj4Sm1hUunK NNMksr3Em2OJhiDT7MGu07ktmg72siNMYAxpKrDVmO+/1uU5EingVM5fwUe4Hn9Bw38r28 9YGpbw0p96uD/e2EKEIlvErolPfcdLE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id D8299B81EAF for ; Tue, 17 Oct 2023 15:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6183C433AD for ; Tue, 17 Oct 2023 15:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697557003; bh=zQqT0Icijbvg9S6mB1pNR2Pch3/DSe5rsPVyjDgEit0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=a02DY55Dh1N3RncpLznmFnEklwXDgdJqCFix7A8TuEQgcMLambAx1NdmGxsg8+6BF p2GKMqmgFe3vHsPlfOt6rzwf0LKLL0zDGRFLPeuJ1JcNFHKgeQpwceun8HOISVgehM pxbyWSXEt2cVB1Dlir92Cow1MS04UhtikZEjl0d2y/8qt6ieP26pLYbq2MyWHJPx9x 3pMNY+ORuwqRcSH5Rsfba/nVAxYoBF1y3TU9/S6LDSXUcPtFRDk1Eb7Zkhqvf+iVEx AKu2m3WQZXmCkAZAtVp7vOXydZERSm8EW0flkgI49ZSjvKNJO0pKp9SZujF7Wm1zWF 0BOS0s4IRViJQ== Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2c509f2c46cso55355071fa.1 for ; Tue, 17 Oct 2023 08:36:43 -0700 (PDT) X-Gm-Message-State: AOJu0YxDsnLiyGxWmVEjUT3hDrQZ8oXaDTFPLazLLFwkVDAoZE9rrqPa km52yFVEp7LxMONj7AO970hnaWbXQvAODrfBCcQ= X-Google-Smtp-Source: AGHT+IH1t58amR8j4KHDACRp4HQeTt/uvBDMgRckb8/zaW4G8A+1S1h459+WQLX6wkrSospqRbyURn70I8/18qMTnKA= X-Received: by 2002:a05:651c:54f:b0:2c5:21e3:f1fb with SMTP id q15-20020a05651c054f00b002c521e3f1fbmr2210135ljp.23.1697557001696; Tue, 17 Oct 2023 08:36:41 -0700 (PDT) MIME-Version: 1.0 References: <20231016163122.12855-1-kirill.shutemov@linux.intel.com> <20231016213932.6cscnn6tsnzsnvmf@box.shutemov.name> <20231017101717.GJ33217@noisy.programming.kicks-ass.net> In-Reply-To: <20231017101717.GJ33217@noisy.programming.kicks-ass.net> From: Ard Biesheuvel Date: Tue, 17 Oct 2023 17:36:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2] efi/unaccepted: Fix soft lockups caused by parallel memory acceptance To: Peter Zijlstra Cc: "Kirill A. Shutemov" , Matthew Wilcox , Borislav Petkov , Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org, Nikolay Borisov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: qgdyrbpm6tnan4uixjds14nomp8ipaxf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D758AA001E X-HE-Tag: 1697557006-995448 X-HE-Meta: U2FsdGVkX184wrh7FhB4xnrApczR+qHQBS52D6qozquOM8hi6w7R9OsALnnz9yqKZyrslByNuLaxOSPPlMEhqCiDpxPOzkTXHbgUWox1Lx+WjHOOiqbz1Fl+AXNJ1qYDQxt+dj2Zf9JEBoOVWkZhi5ZtCTtq9CYU4vk1/1StR4EXPc6jfsBOI0JkiYBF1PxPYpw1253t8Qd9P3A2WxFsaRi7YmThY1DlYM8wJEewOuT1yxyGgqhuafKuhWrpjQY0tNCvtB9zEsQzTk/vOjZBdCn98y+OQ+bA5k/mmxiqP9XuS6ntmw3Rxa2FylNQwGdIQevuStbD/u6/QXz201Lc48T1LRbb2nAvWlEnttcbr23ghLQKVyFMWlzgXQ/E2CxQt0EfoEAZO9pqraniOV9IWqDfpHIWDxQS0XAUGsObYvj4+Gcp/X9ueXYnAr+mt+7d85EgMW4pJ1D6Zs/4gvR/ErvBOANjD1oc2qK7Cp2jVAJGX9CaJ9TvRjMEK1AgpNQgPI6KV85rJTFP5hK/EnkqxMHoZ6Eji80TNK6sp936eHD0D0upxJ+WHDR3H4A1k+k/Ekzt8nS2ghGJuUbUlLy0OX16XiCq6riewhijTmfK5yePPfkTrlQOWx5DRtjyL0OwMPf8gMGybpHywNQV4bcWX4A2Gotiyt7UdG/VbAMJrcYSlbeT+8uAPlFdAbnyhsl2XjFFECuAkolNKqFX6PV+cftLZPaWTVulGGgTRwV4fFHdgwI3MVx2MbbPud2M/Mb5G8oCmole4cVHNhqG6KCExOE/0jQqM2Qxzw7Cjw/ImnvJ9kHXkGPq5b28HkEPFxgVlg/5Zl2fbCXZ5mLwnRc3Yoedhebh1AiGn8TpbJnEJ/fc4Zei2YQWso2o+FZw7O0lfZ2dS+lWV6MgwIhmpyIfUgeTHpEDtVZdUSWz26rY831FCSsmjnz1azhGauJZB3TP5H48PjvF+wumPLbLbgN CQUW8Vqj vsdiBrL0aRYv8p619RGeX6BStGId/sJ0uBJdv1Dc6UmVjIOwfTHoqrk5FuDkRNW3VCnAn+to8G5WCVNAavNplaMZS5SPcSqI3rbnffIZ5dJ9Kcixpd2QiaTs0kAtCL3OF8NO1HR44A1cuPPIiXi5qn3oeKSR9CcIVcMKxtKj7Ch2mXs1QkdvBvO4FQDpzfv0SHEWc3gBz/fdLijWhL0c3fhh0oVLQ98jHFXgRzXMU4MQNXdiG6x4dZcH5dZqZcafXB0LiVjc0nLlktdYqUMrtoAMAHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 17 Oct 2023 at 12:17, Peter Zijlstra wrote: > > On Tue, Oct 17, 2023 at 09:42:13AM +0200, Ard Biesheuvel wrote: > > > One question I have is whether the sequence > > > > spin_lock_irqsave(&unaccepted_memory_lock, flags); > > ... > > spin_unlock(&unaccepted_memory_lock); > > arch_accept_memory(phys_start, phys_end); > > spin_lock(&unaccepted_memory_lock); > > ... > > spin_unlock_irqrestore(&unaccepted_memory_lock, flags); > > > > is considered sound and is supported by all architectures? > > Yes. Thanks for the clarification I've queued this up now (with the cpu_relax() removed)