From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6F9C433EF for ; Tue, 19 Apr 2022 18:29:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B11DC6B0071; Tue, 19 Apr 2022 14:29:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0686B0073; Tue, 19 Apr 2022 14:29:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9618C6B0074; Tue, 19 Apr 2022 14:29:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 8812A6B0071 for ; Tue, 19 Apr 2022 14:29:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4EF822659 for ; Tue, 19 Apr 2022 18:29:54 +0000 (UTC) X-FDA: 79374467508.15.56DB77D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id 06F2C40012 for ; Tue, 19 Apr 2022 18:29:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0A2FDB818CE for ; Tue, 19 Apr 2022 18:29:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2491C385A9 for ; Tue, 19 Apr 2022 18:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650392990; bh=P3K1tP6cpjTFzC+59oPXafdJm30VtMZbfwvyBn+l0nE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=a0sKRq/vSRMN1bHAzS2oTT7TW9gxljwYhCWZou9JxxntTgmsHAD8oUsvY6T71obXf YYZmX/tGPoiXhARPBnGE9+7b2bbtpuSB3NyP4HiLWfN0XF23q1dqrzvpVCQR+iTvXf 5AuMvLTrDPB/qpIcyK2Rwnf/2Fv/TTUy3OEu29NxKLyqxGbwE5qi/2XJ1v8eQPSz9g itehrMC0jLI4udNJdADiAJgaBAe0OScxUrMGb6oPh+mgN06QsIibsniLRaau+qJNMk fOIAWwNBk0bOiyZdqe/3RX9Z0TERZt6VYuHh3nFQJUHRVK8osn3JxxQEnwOGPnTVLR OcONDhlBPfIng== Received: by mail-yb1-f178.google.com with SMTP id p65so32608607ybp.9 for ; Tue, 19 Apr 2022 11:29:50 -0700 (PDT) X-Gm-Message-State: AOAM532H8dntnV9x0UL5mnBlXJSflufpeh9Dnx35tJc9KiklmA9oZOMx AbOOMjquSssboBbqiMbGpZvxWc62JfvNt9TMg6w= X-Google-Smtp-Source: ABdhPJx9o5nnG+qju6sQJMbe2eMJR893omMynSTe6NVIGWkG2uzYm2akaRvmqHO268QDgzdEY4zNawIK3ayZ+NJ0zEc= X-Received: by 2002:a05:6830:33eb:b0:5f8:d36d:3831 with SMTP id i11-20020a05683033eb00b005f8d36d3831mr6341951otu.265.1650392978707; Tue, 19 Apr 2022 11:29:38 -0700 (PDT) MIME-Version: 1.0 References: <20220414101314.1250667-1-mawupeng1@huawei.com> <20220414101314.1250667-8-mawupeng1@huawei.com> <672ff459-81bd-38ef-882d-e718992d295c@arm.com> In-Reply-To: <672ff459-81bd-38ef-882d-e718992d295c@arm.com> From: Ard Biesheuvel Date: Tue, 19 Apr 2022 20:29:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 7/9] mm: Calc the right pfn if page size is not 4K To: Anshuman Khandual , Andrew Morton Cc: Wupeng Ma , Catalin Marinas , Will Deacon , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , X86 ML , hpa@zyccr.com, Darren Hart , Andy Shevchenko , Mike Rapoport , "Paul E. McKenney" , Peter Zijlstra , Joerg Roedel , songmuchun@bytedance.com, macro@orcam.me.uk, Frederic Weisbecker , W_Armin@gmx.de, John Garry , Sean Christopherson , Thomas Bogendoerfer , chenhuacai@kernel.org, David Hildenbrand , gpiccoli@igalia.com, Mark Rutland , Kefeng Wang , Linux Doc Mailing List , Linux Kernel Mailing List , Linux ARM , linux-efi , linux-ia64@vger.kernel.org, platform-driver-x86@vger.kernel.org, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="a0sKRq/v"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of ardb@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ardb@kernel.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 06F2C40012 X-Stat-Signature: 5ikww8xqday1u56bzwq4k3m1e6fztqtc X-HE-Tag: 1650392992-714596 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 19 Apr 2022 at 13:13, Anshuman Khandual wrote: > > > > On 4/14/22 15:43, Wupeng Ma wrote: > > From: Ma Wupeng > > > > Previous 0x100000 is used to check the 4G limit in > > find_zone_movable_pfns_for_nodes(). This is right in x86 because > > the page size can only be 4K. But 16K and 64K are available in > > arm64. So replace it with PHYS_PFN(SZ_4G). > > > > Signed-off-by: Ma Wupeng > > --- > > mm/page_alloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 6e5b4488a0c5..570d0ebf98df 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -7870,7 +7870,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > > > usable_startpfn = memblock_region_memory_base_pfn(r); > > > > - if (usable_startpfn < 0x100000) { > > + if (usable_startpfn < PHYS_PFN(SZ_4G)) { > > mem_below_4gb_not_mirrored = true; > > continue; > > } > > Regardless PFN value should never be encoded directly. > > Reviewed-by: Anshuman Khandual Acked-by: Ard Biesheuvel Andrew, can you please take this one through the -mm tree? The rest of the series needs a bit more work, but is an obvious fix and there is no point in holding it up. Thanks, Ard.