From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A77C4742C for ; Wed, 11 Nov 2020 07:19:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5734720795 for ; Wed, 11 Nov 2020 07:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="guq6CmAi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5734720795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E0056B0070; Wed, 11 Nov 2020 02:19:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26A136B0072; Wed, 11 Nov 2020 02:19:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1315B6B0073; Wed, 11 Nov 2020 02:19:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id D6BE06B0070 for ; Wed, 11 Nov 2020 02:19:28 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 83C53180AD802 for ; Wed, 11 Nov 2020 07:19:28 +0000 (UTC) X-FDA: 77471286816.23.basin42_3f00ce5272fb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 673A037606 for ; Wed, 11 Nov 2020 07:19:28 +0000 (UTC) X-HE-Tag: basin42_3f00ce5272fb X-Filterd-Recvd-Size: 4465 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 07:19:27 +0000 (UTC) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70F1E22228 for ; Wed, 11 Nov 2020 07:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605079166; bh=CAQVZqtxtSOwUyW8EqmnyD/K8yMmd2zuMQylnTG3pAg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=guq6CmAiRLq4R57MddTf3q6FwEUAeGMSddkiHps3KcyrTTkyZgtGjcSmcOIsYZj0M RIXnQSaNESRz5bdvVKxisfCpa82vtPflR7f31OGH6AfHdtg9UUX+aLE+fkQkqYSZm9 ibIc3iuUQl0WCalegb6OGnkKiHD0ZFDeAI5/tccU= Received: by mail-ot1-f46.google.com with SMTP id n11so1290092ota.2 for ; Tue, 10 Nov 2020 23:19:26 -0800 (PST) X-Gm-Message-State: AOAM533z46z5F9NHPcZ1raoPjbJ5aPg0S9qCJYQWgTPRhZBbSMWTtDeV sHQMc6awqn7ZL2ylZny/sl3bFPOdhQ3yvWHUfWM= X-Google-Smtp-Source: ABdhPJy/FX3/haQPkbbnTxCEyFCfcbR6nBwOK2StlreaD3AMalrsdDe04JmnBGrk4RF2qWP6H6cn3ss1V/mpW5hPHIQ= X-Received: by 2002:a05:6830:214c:: with SMTP id r12mr7308063otd.90.1605079165545; Tue, 10 Nov 2020 23:19:25 -0800 (PST) MIME-Version: 1.0 References: <20201022073307.GP2628@hirez.programming.kicks-ass.net> <133aa0c8c5e2cbc862df109200b982e89046dbc0.camel@perches.com> In-Reply-To: <133aa0c8c5e2cbc862df109200b982e89046dbc0.camel@perches.com> From: Ard Biesheuvel Date: Wed, 11 Nov 2020 08:19:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] treewide: Remove stringification from __alias macro definition To: Joe Perches , Russell King Cc: Peter Zijlstra , Thomas Gleixner , Borislav Petkov , X86 ML , "H. Peter Anvin" , Miguel Ojeda , Marco Elver , Dmitry Vyukov , Herbert Xu , "David S. Miller" , Andrey Ryabinin , Alexander Potapenko , Andrew Morton , Nick Desaulniers , Linux Kernel Mailing List , linux-efi , kasan-dev , Linux Crypto Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (+ Russell) On Thu, 22 Oct 2020 at 18:20, Joe Perches wrote: > > On Thu, 2020-10-22 at 09:33 +0200, Peter Zijlstra wrote: > > On Wed, Oct 21, 2020 at 11:58:25AM -0700, Joe Perches wrote: > > > Like the __section macro, the __alias macro uses > > > macro # stringification to create quotes around > > > the section name used in the __attribute__. > > > > > > Remove the stringification and add quotes or a > > > stringification to the uses instead. > > > > There's a complete lack of rationale for this change. > > I'll eventually post V2. > I'm waiting to see if there are more comments. > > As I wrote in reply to Ard: > > https://lore.kernel.org/lkml/1cecfbfc853b2e71a96ab58661037c28a2f9280e.camel@perches.com/ > > Using quotes in __section caused/causes differences > between clang and gcc. > > https://lkml.org/lkml/2020/9/29/2187 > > Using common styles for details like this is good. > This patch is now causing problems in the ARM tree, because some new uses of __alias() have been queued (for KASAN), and since this is a non-backwards compatible change, we have to choose between breaking the maintainer's tree or breaking -next (given that the change has been pulled in there now) I am still not convinced we need this change, as I don't see how the concerns regarding __section apply to __alias. But if we do, can we please use the same approach, i.e., revert the current patch, and queue it again after v5.11-rc1 with all new occurrences covered as well?