From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11969C433B4 for ; Wed, 12 May 2021 07:00:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A4D861927 for ; Wed, 12 May 2021 07:00:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A4D861927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 943876B0036; Wed, 12 May 2021 03:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F3856B006E; Wed, 12 May 2021 03:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76CBA6B0070; Wed, 12 May 2021 03:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 5964E6B0036 for ; Wed, 12 May 2021 03:00:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 04107181AF5C4 for ; Wed, 12 May 2021 07:00:15 +0000 (UTC) X-FDA: 78131679990.21.9A01D73 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP id 665C478E for ; Wed, 12 May 2021 07:00:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E01461927 for ; Wed, 12 May 2021 07:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620802813; bh=tOlm23mTOpNM0/BbK/ucKXhqG2RgCDl/OY+dbOJpNlE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TWprbVSJw/7Y52OoBeErncbDWObcKZErbEP7n9087p7QetbLh0+ddhF0dJN0VtnRn lhaJ4+89Tu10BwQTI91IyHahseZGISnbKtQyWPsLpVtgfIF4wpK/uY3lvV9CeqvKKs Qm4oX1UuNKwGsbS2+UyX7XTSMGw0C4if2NJXeWFp6J6qhUmeOqCqYiLW7HZqQaxZMD hzXx6rD62P4ySuu6A/z3yiTrdX+ILDtXlWY79HqfY9F2ol/tEHUqEwFXymm5jxxXK1 3GFKD42/JceAA8vvRrC9wsMlC3bDu13YowtjQ3uvy57H47TSehrxh17TUspc5foTb2 U853PsOiPLu5g== Received: by mail-ot1-f50.google.com with SMTP id q7-20020a9d57870000b02902a5c2bd8c17so19727945oth.5 for ; Wed, 12 May 2021 00:00:13 -0700 (PDT) X-Gm-Message-State: AOAM530mMV/tSbqF3PYqO/LdBBaIp2DJQTMbrHQDpRI7GgGtCyGJ4+sL 1r2LLR78kgfw5IMeuvjgmwctVLdotBv4DUIf+Fk= X-Google-Smtp-Source: ABdhPJxU0Rx7jp0gaYTPEDkowYZKavU9wU/cyN0P5bupNnkZT/v5SN2zcx17yX3HlQYWKlMd1elbP469y2PbHzA/c0M= X-Received: by 2002:a9d:7cd8:: with SMTP id r24mr17652427otn.90.1620802812741; Wed, 12 May 2021 00:00:12 -0700 (PDT) MIME-Version: 1.0 References: <20210511100550.28178-1-rppt@kernel.org> In-Reply-To: <20210511100550.28178-1-rppt@kernel.org> From: Ard Biesheuvel Date: Wed, 12 May 2021 09:00:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() To: Mike Rapoport Cc: Andrew Morton , Anshuman Khandual , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm , Linux ARM , Linux Kernel Mailing List , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TWprbVSJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of ardb@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=ardb@kernel.org X-Stat-Signature: scgm5d4p1z39t5pwt75uoqtrmjwjt749 X-Rspamd-Queue-Id: 665C478E X-Rspamd-Server: rspam02 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620802814-349195 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 May 2021 at 12:05, Mike Rapoport wrote: > > From: Mike Rapoport > > Hi, > > These patches aim to remove CONFIG_HOLES_IN_ZONE and essentially hardwire > pfn_valid_within() to 1. > > The idea is to mark NOMAP pages as reserved in the memory map and restore > the intended semantics of pfn_valid() to designate availability of struct > page for a pfn. > > With this the core mm will be able to cope with the fact that it cannot use > NOMAP pages and the holes created by NOMAP ranges within MAX_ORDER blocks > will be treated correctly even without the need for pfn_valid_within. > > The patches are boot tested on qemu-system-aarch64. > Did you use EFI boot when testing this? The memory map is much more fragmented in that case, so this would be a good data point. > I beleive it would be best to route these via mmotm tree. > > v4: > * rebase on v5.13-rc1 > > v3: Link: https://lore.kernel.org/lkml/20210422061902.21614-1-rppt@kernel.org > * Fix minor issues found by Anshuman > * Freshen up the declaration of pfn_valid() to make it consistent with > pfn_is_map_memory() > * Add more Acked-by and Reviewed-by tags, thanks Anshuman and David > > v2: Link: https://lore.kernel.org/lkml/20210421065108.1987-1-rppt@kernel.org > * Add check for PFN overflow in pfn_is_map_memory() > * Add Acked-by and Reviewed-by tags, thanks David. > > v1: Link: https://lore.kernel.org/lkml/20210420090925.7457-1-rppt@kernel.org > * Add comment about the semantics of pfn_valid() as Anshuman suggested > * Extend comments about MEMBLOCK_NOMAP, per Anshuman > * Use pfn_is_map_memory() name for the exported wrapper for > memblock_is_map_memory(). It is still local to arch/arm64 in the end > because of header dependency issues. > > rfc: Link: https://lore.kernel.org/lkml/20210407172607.8812-1-rppt@kernel.org > > Mike Rapoport (4): > include/linux/mmzone.h: add documentation for pfn_valid() > memblock: update initialization of reserved pages > arm64: decouple check whether pfn is in linear map from pfn_valid() > arm64: drop pfn_valid_within() and simplify pfn_valid() > > arch/arm64/Kconfig | 3 --- > arch/arm64/include/asm/memory.h | 2 +- > arch/arm64/include/asm/page.h | 3 ++- > arch/arm64/kvm/mmu.c | 2 +- > arch/arm64/mm/init.c | 14 +++++++++++++- > arch/arm64/mm/ioremap.c | 4 ++-- > arch/arm64/mm/mmu.c | 2 +- > include/linux/memblock.h | 4 +++- > include/linux/mmzone.h | 11 +++++++++++ > mm/memblock.c | 28 ++++++++++++++++++++++++++-- > 10 files changed, 60 insertions(+), 13 deletions(-) > > > base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5 > -- > 2.28.0 >