From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2095AC433E0 for ; Sat, 27 Jun 2020 07:58:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC28B20706 for ; Sat, 27 Jun 2020 07:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gOEMIbZQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC28B20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 777586B009E; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 727BC6B009F; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 662E06B00A0; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 4B9B26B009E for ; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0319B180AD807 for ; Sat, 27 Jun 2020 07:58:04 +0000 (UTC) X-FDA: 76974238488.30.crack00_5b0de3626e5c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D4EF4180B3C85 for ; Sat, 27 Jun 2020 07:58:03 +0000 (UTC) X-HE-Tag: crack00_5b0de3626e5c X-Filterd-Recvd-Size: 3019 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Sat, 27 Jun 2020 07:58:03 +0000 (UTC) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 838A6212CC for ; Sat, 27 Jun 2020 07:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593244682; bh=2/cm0M8v0eEtEFJEA8Dif5Ov9yE8KEk2CBe8/6XUXWM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gOEMIbZQ5LnRjtui26c5ZekgfuHOCD/wNPRfzXO6NWYj/K5k+yrpmPjt+ueSyxrAn tEnXIgGvVa2aqhClJei5hf31zLUuRBVV83FLOBPRf22h1GtSTSZc0BH1827KlPArAA MWBf3/6LUrTmk7lo7nr0XO4PNnhrTQVIrLR3UbQI= Received: by mail-ot1-f41.google.com with SMTP id 95so138393otw.10 for ; Sat, 27 Jun 2020 00:58:02 -0700 (PDT) X-Gm-Message-State: AOAM532hx31ZDus8Dtep1Gk74MdTv9nogTOccrMKsFKWaoOr/Z3tcRLw d7+KRuw+lvYJHv84NX7A8jdOaiZ+ZE9/BAFiuw8= X-Google-Smtp-Source: ABdhPJyvEZ4ya/6GghXmbfDKYZlNzJQbzAIIUY/SlUz7bnD/Np9o6UmM8NkCsnN45BvB9WbnoZS7OhBRZNX9Vc6iEnA= X-Received: by 2002:a4a:9210:: with SMTP id f16mr5775705ooh.13.1593244681878; Sat, 27 Jun 2020 00:58:01 -0700 (PDT) MIME-Version: 1.0 References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> <20200627075659.GA12509@lst.de> In-Reply-To: <20200627075659.GA12509@lst.de> From: Ard Biesheuvel Date: Sat, 27 Jun 2020 09:57:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page To: Christoph Hellwig Cc: Andrew Morton , linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , linux-mm@kvack.org, Jessica Yu , Vitaly Kuznetsov , Will Deacon , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D4EF4180B3C85 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 27 Jun 2020 at 09:57, Christoph Hellwig wrote: > > On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > > + NUMA_NO_NODE, __func__); > > > > Why is this passing a string for the 'caller' argument, and not the > > address of the caller? > > Dementia. Fix sent. :-)