From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A810C2D0A3 for ; Mon, 9 Nov 2020 07:40:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C44E2206CB for ; Mon, 9 Nov 2020 07:40:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DEDESS5U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C44E2206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E005A6B0036; Mon, 9 Nov 2020 02:40:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAD396B005D; Mon, 9 Nov 2020 02:40:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9D4C6B0068; Mon, 9 Nov 2020 02:40:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 9BF9B6B0036 for ; Mon, 9 Nov 2020 02:40:34 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4BECD180AD802 for ; Mon, 9 Nov 2020 07:40:34 +0000 (UTC) X-FDA: 77464082388.12.robin81_340ecba272ea Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 0EF341800DCA0 for ; Mon, 9 Nov 2020 07:40:34 +0000 (UTC) X-HE-Tag: robin81_340ecba272ea X-Filterd-Recvd-Size: 5429 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Nov 2020 07:40:33 +0000 (UTC) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28868221FC for ; Mon, 9 Nov 2020 07:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604907632; bh=CdqrK974gDlyEi/kvuoxck4jtpAjC9LfgZm6/XYiZgY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DEDESS5UTt89rYpFy1JTo9+eem+U8D0PsL3fFNaZMEE3KjiBJ03elc67iZw4FU1bB mUCHsOebOnjlDvpmNwsrc6KtbCEsHjGYM+OqDZbmyt8Ed0JpSoV3utniogLonjsiOn ABNS9Tkomj/MdnUmIA1AYQqsNKjurVKyqcJyGsJk= Received: by mail-ot1-f46.google.com with SMTP id f16so8035692otl.11 for ; Sun, 08 Nov 2020 23:40:32 -0800 (PST) X-Gm-Message-State: AOAM532v4qU6iqbAc0Xph8wKaHzle18/q8erick0V8UEwJ6hws4pZclP di86NpjvRyztAEeJxE2c47Bzg9+sJWTuQqB0cE4= X-Google-Smtp-Source: ABdhPJzngTfH1SnBjj+5ECgJpfUB+wr03SXOGvAH4gaRFZ2p15uaAw/DgQYJzq6/q9wQlR70F3l67DMeWQ/5c/moYT8= X-Received: by 2002:a9d:62c1:: with SMTP id z1mr9182745otk.108.1604907631229; Sun, 08 Nov 2020 23:40:31 -0800 (PST) MIME-Version: 1.0 References: <20201108222156.GA1049451@ubuntu-m3-large-x86> <20201109001712.3384097-1-natechancellor@gmail.com> In-Reply-To: <20201109001712.3384097-1-natechancellor@gmail.com> From: Ard Biesheuvel Date: Mon, 9 Nov 2020 08:40:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: boot: Quote aliased symbol names in string.c To: Nathan Chancellor Cc: Andrew Morton , Abbott Liu , Ahmad Fatoum , Andrey Ryabinin , Florian Fainelli , Linus Walleij , Joe Perches , Russell King , Stephen Rothwell , kasan-dev , Linux ARM , Linux Memory Management List , Linux Next Mailing List , Linux Kernel Mailing List , Naresh Kamboju , =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Nov 2020 at 01:19, Nathan Chancellor w= rote: > > Patch "treewide: Remove stringification from __alias macro definition" > causes arguments to __alias to no longer be quoted automatically, which > breaks CONFIG_KASAN on ARM after commit d6d51a96c7d6 ("ARM: 9014/2: > Replace string mem* functions for KASan"): > > arch/arm/boot/compressed/string.c:24:1: error: attribute 'alias' argument= not a string > 24 | void *__memcpy(void *__dest, __const void *__src, size_t __n) __a= lias(memcpy); > | ^~~~ > arch/arm/boot/compressed/string.c:25:1: error: attribute 'alias' argument= not a string > 25 | void *__memmove(void *__dest, __const void *__src, size_t count) = __alias(memmove); > | ^~~~ > arch/arm/boot/compressed/string.c:26:1: error: attribute 'alias' argument= not a string > 26 | void *__memset(void *s, int c, size_t count) __alias(memset); > | ^~~~ > make[3]: *** [scripts/Makefile.build:283: arch/arm/boot/compressed/string= .o] Error 1 > > Quote the names like the treewide patch does so there is no more error. > > Reported-by: Naresh Kamboju > Reported-by: Valdis Kl=C4=93tnieks > Signed-off-by: Nathan Chancellor Acked-by: Ard Biesheuvel > --- > > Hi Andrew, > > Stephen said I should send this along to you so that it can be applied > as part of the post -next series. Please let me know if you need any > more information or clarification, I tried to document it succinctly in > the commit message. > > Cheers, > Nathan > > arch/arm/boot/compressed/string.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/compressed/string.c b/arch/arm/boot/compressed= /string.c > index 8c0fa276d994..cc6198f8a348 100644 > --- a/arch/arm/boot/compressed/string.c > +++ b/arch/arm/boot/compressed/string.c > @@ -21,9 +21,9 @@ > #undef memcpy > #undef memmove > #undef memset > -void *__memcpy(void *__dest, __const void *__src, size_t __n) __alias(me= mcpy); > -void *__memmove(void *__dest, __const void *__src, size_t count) __alias= (memmove); > -void *__memset(void *s, int c, size_t count) __alias(memset); > +void *__memcpy(void *__dest, __const void *__src, size_t __n) __alias("m= emcpy"); > +void *__memmove(void *__dest, __const void *__src, size_t count) __alias= ("memmove"); > +void *__memset(void *s, int c, size_t count) __alias("memset"); > #endif > > void *memcpy(void *__dest, __const void *__src, size_t __n) > -- > 2.29.2 >