From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3044C433E0 for ; Wed, 3 Feb 2021 18:31:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20A1664DE8 for ; Wed, 3 Feb 2021 18:31:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20A1664DE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C6F36B0005; Wed, 3 Feb 2021 13:31:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69DDF6B0006; Wed, 3 Feb 2021 13:31:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B3CD6B006E; Wed, 3 Feb 2021 13:31:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 3F7756B0005 for ; Wed, 3 Feb 2021 13:31:19 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E3725181AEF21 for ; Wed, 3 Feb 2021 18:31:18 +0000 (UTC) X-FDA: 77777799036.16.music45_3413410275d5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id B7C81100E6917 for ; Wed, 3 Feb 2021 18:31:18 +0000 (UTC) X-HE-Tag: music45_3413410275d5 X-Filterd-Recvd-Size: 4685 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 18:31:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A60B464E88 for ; Wed, 3 Feb 2021 18:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612377076; bh=qgQXHCOO+dJ+yb7nrlrPLjaNfhwMNTK/2D37AWkM2GU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=b4uhGDj52vIKbtPiEWqq6RhUatbEdurtjYlGgyr7LWPklmvbj2u1z3+Lx/k8RQt1T HZyqx68WLYsu0TznjDJ4lHXrDYntGoKDBbhRJbobky+2Wimi2VREIb0PAqlN2675og yel0vm/LPzBvVmayjkxbnfd1aLeDkst1I/ksdo8xNE7QQiN++Vk5S9f6/rE0g7RxVW CNsnE3vQA9eiJdh+dYpOaM1CJzZRrh8QDUsYjDhbx83MMfxkt4LlijKd+Ye5miJ6dO 32WsIbWjST/lwfcIqaPl5Q31R+Sr31uywgKs8ywZ/frDesQ3LJQKNykE3EdgTCIbqe qcRKP1h0Vzd9w== Received: by mail-oo1-f47.google.com with SMTP id q3so117507oog.4 for ; Wed, 03 Feb 2021 10:31:16 -0800 (PST) X-Gm-Message-State: AOAM530lAeSwKFDAus4Wd8r6PuH6snEX/JzhlPFescnegFkLaGnVqwsg sa9Jgje2nAp2wo4+xWbPzrEZ6Ra+zQKd3nDZFZw= X-Google-Smtp-Source: ABdhPJzwd5KGkhGPt/OEU87BbYt91cpEEmblkRtD+YcxL6JmFSvKeQgDP7VxawLeDkwKP+ZjxzWQ0TT7IuF1t2mYdTQ= X-Received: by 2002:a05:6820:283:: with SMTP id q3mr2987191ood.13.1612377075690; Wed, 03 Feb 2021 10:31:15 -0800 (PST) MIME-Version: 1.0 References: <20210109103252.812517-1-lecopzer@gmail.com> In-Reply-To: <20210109103252.812517-1-lecopzer@gmail.com> From: Ard Biesheuvel Date: Wed, 3 Feb 2021 19:31:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC To: Lecopzer Chen Cc: Linux Kernel Mailing List , Linux Memory Management List , kasan-dev , Linux ARM , Dan Williams , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com, Will Deacon , Catalin Marinas , Andrey Konovalov , Mark Brown , Guenter Roeck , Mike Rapoport , Tyler Hicks , Robin Murphy , Vincenzo Frascino , "Gustavo A. R. Silva" , Lecopzer Chen Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 9 Jan 2021 at 11:33, Lecopzer Chen wrote: > > Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > ("kasan: support backing vmalloc space with real shadow memory") > > Acroding to how x86 ported it [1], they early allocated p4d and pgd, > but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64 > by not to populate the vmalloc area except for kimg address. > > Test environment: > 4G and 8G Qemu virt, > 39-bit VA + 4k PAGE_SIZE with 3-level page table, > test by lib/test_kasan.ko and lib/test_kasan_module.ko > > It also works in Kaslr with CONFIG_RANDOMIZE_MODULE_REGION_FULL > and randomize module region inside vmalloc area. > > > [1]: commit 0609ae011deb41c ("x86/kasan: support KASAN_VMALLOC") > > Signed-off-by: Lecopzer Chen > Acked-by: Andrey Konovalov > Tested-by: Andrey Konovalov > > > v2 -> v1 > 1. kasan_init.c tweak indent > 2. change Kconfig depends only on HAVE_ARCH_KASAN > 3. support randomized module region. > > v1: > https://lore.kernel.org/lkml/20210103171137.153834-1-lecopzer@gmail.com/ > > Lecopzer Chen (4): > arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC > arm64: kasan: abstract _text and _end to KERNEL_START/END > arm64: Kconfig: support CONFIG_KASAN_VMALLOC > arm64: kaslr: support randomized module area with KASAN_VMALLOC > I failed to realize that VMAP_STACK and KASAN are currently mutually exclusive on arm64, and that this series actually fixes that, which is a big improvement, so it would make sense to call that out. This builds and runs fine for me on a VM running under KVM. Tested-by: Ard Biesheuvel