From: Huang Shijie <shijie8@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Huang Shijie <b32955@freescale.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/compaction : check the watermark when cc->order is -1
Date: Sat, 14 Jan 2012 10:10:57 +0800 [thread overview]
Message-ID: <CAMiH66F0Oow6jvXuwr0+6s+0wOV4nvu=_chfe8_NJhpacZE80A@mail.gmail.com> (raw)
In-Reply-To: <20120113112832.GR4118@suse.de>
hi,
> When I glanced at this first, I missed that you altered the watermark
> check as well. When I said "Code wise the patch is fine", I was wrong.
> Compaction works in units of pageblocks and the watermark check
> is necessary. Reducing it to COMPACT_CLUSTER_MAX*2 leads to the
> possibility of compaction via /proc causing livelocks in low memory
> situations depending on the value of min_free_kbytes.
ok, thanks a lot for the explanation.
Huang Shijie
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-14 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 2:50 Huang Shijie
2012-01-12 5:59 ` Huang Shijie
2012-01-12 12:05 ` Mel Gorman
2012-01-13 2:31 ` Huang Shijie
2012-01-13 11:28 ` Mel Gorman
2012-01-14 2:10 ` Huang Shijie [this message]
2012-01-12 8:15 ` Minchan Kim
2012-01-12 8:31 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMiH66F0Oow6jvXuwr0+6s+0wOV4nvu=_chfe8_NJhpacZE80A@mail.gmail.com' \
--to=shijie8@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=b32955@freescale.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox