From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA6AC47082 for ; Thu, 3 Jun 2021 04:18:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 727FE613E3 for ; Thu, 3 Jun 2021 04:18:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 727FE613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 084936B006C; Thu, 3 Jun 2021 00:18:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0343F6B006E; Thu, 3 Jun 2021 00:18:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E176F6B0070; Thu, 3 Jun 2021 00:18:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id B38E16B006C for ; Thu, 3 Jun 2021 00:18:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 56A85EFDB for ; Thu, 3 Jun 2021 04:18:51 +0000 (UTC) X-FDA: 78211106862.19.82A51A8 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf11.hostedemail.com (Postfix) with ESMTP id 413BD20010A3 for ; Thu, 3 Jun 2021 04:18:34 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id m137so1138416oig.6 for ; Wed, 02 Jun 2021 21:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=23qUvFEybs5ImEGPrUMvy9mMOYc+i6Y2SflWzXrEu1U=; b=HhwAkONVMjYMN/S5Qbi6dH2WSwGZ7bq24t3U1AplvK1a4OPZDVZ46xxIHQkuVFzu9E Lp86Qa+bkr5KhlnSgou9JMBF/nSqiDj7ju2mrpveoBzJkehUZQMpgAyC+OclP8wyYl5d 7qUiJ+RQsqqBr922BFcmwHfJrtFqQWQkEGyGXf/kk7BdtdsJTR6xXVDHKt/4EwOmve6P nz84iHaKlGdnV0VOv2Y9zV+HTVQ6bbiFHF+uNrJMbQ5XxpFn2DqWZ8yuklBcDo+BesM7 z6k7K60WyzWMM2x/IjiWFJH7TFZyu6LpRcdqVFzDVzI1MY/Z65K5nf2c3kCCZuxchyfe 1WoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=23qUvFEybs5ImEGPrUMvy9mMOYc+i6Y2SflWzXrEu1U=; b=K2xB7oq1yCurcJu579Cso+LMnMw3/WkPKzvi6oDNj5BQ4ASXwMmtNBuU9wqJ8kEPN4 EBUyZAeL2z+WDoQQ5UAG4nBa8UUiv1jNoeZk12aevm13cgHPE257IqsBZOh+7/nBTb4y UHheWFVqNEtGPd/2UfyLKuDexnwhZywl0jIUKAltnxufbPbn8XpSQtVUz77FLtyhiubM sM9nIU/thMwjuq8rU6XTTZ0pnYKsPvuqvdHVBrN4CssWh3gEgJh+g6smnZa61o2G3gwZ q9DVFr428YmJnSkXRBOfMwbIk6hKn3qXS7qZLkkANN4ni2ciqNtvGWe1Owi4gCgBU51s KfyQ== X-Gm-Message-State: AOAM5320jo+nyxh7/xsPxzrvBS0W2NC2rthz6oHcRnaot2QhOumIreay engwwOYuI1z5Qyja5pSqg8jE+gkrmC9Vr+7AAz8= X-Google-Smtp-Source: ABdhPJwSdeMRX3lDY+eR4gXjGB43SWFmihLQhRf8T/7k2eEIAZd+dB6q2ZhK9CfRGLsItHvwrrwAhqgPFLRNuVXyHbI= X-Received: by 2002:aca:d905:: with SMTP id q5mr3530614oig.149.1622693930208; Wed, 02 Jun 2021 21:18:50 -0700 (PDT) MIME-Version: 1.0 References: <202106021822.Do0Ih08d-lkp@intel.com> In-Reply-To: From: Sergio Paracuellos Date: Thu, 3 Jun 2021 06:18:39 +0200 Message-ID: Subject: Re: [linux-next:master 1932/6331] drivers/phy/ralink/phy-mt7621-pci.c:341:34: warning: unused variable 'mt7621_pci_phy_ids' To: Nick Desaulniers Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Vinod Koul Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 413BD20010A3 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=HhwAkONV; spf=pass (imf11.hostedemail.com: domain of sergioparacuellos@gmail.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=sergioparacuellos@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: smodaojtz5t1tn5fnmt5h91zejrykk5w X-HE-Tag: 1622693914-434715 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nick, On Wed, Jun 2, 2021 at 8:18 PM Nick Desaulniers wrote: > > On Wed, Jun 2, 2021 at 11:09 AM Sergio Paracuellos > wrote: > > > > Hi Nick, > > > > On Wed, Jun 2, 2021 at 6:47 PM Nick Desaulniers wrote: > > > > > > On Wed, Jun 2, 2021 at 3:38 AM Sergio Paracuellos > > > wrote: > > > > > > > > Hi, > > > > > > > > On Wed, Jun 2, 2021 at 12:27 PM kernel test robot wrote: > > > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > > > head: ed5d0667a6540293c9485dd95babb5f1e241226a > > > > > commit: 28dcfba1a0d622b0330ae3f4a9d7c7f2c245de7a [1932/6331] phy: ralink: Kconfig: enable COMPILE_TEST on mt7621-pci-phy driver > > > > > config: x86_64-randconfig-r016-20210602 (attached as .config) > > > > > > ^ randconfig > > > > > > > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project db26cd30b6dd65e88d786e97a1e453af5cd48966) > > > > > reproduce (this is a W=1 build): > > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > > chmod +x ~/bin/make.cross > > > > > # install x86_64 cross compiling tool for clang build > > > > > # apt-get install binutils-x86-64-linux-gnu > > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=28dcfba1a0d622b0330ae3f4a9d7c7f2c245de7a > > > > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > > > git fetch --no-tags linux-next master > > > > > git checkout 28dcfba1a0d622b0330ae3f4a9d7c7f2c245de7a > > > > > # save the attached .config to linux build tree > > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > > Reported-by: kernel test robot > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > > drivers/phy/ralink/phy-mt7621-pci.c:277:4: warning: cast to smaller integer type 'unsigned int' from 'void *' [-Wvoid-pointer-to-int-cast] > > > > > (unsigned int)mt7621_phy->port_base, mt7621_phy->has_dual_port); > > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > include/linux/dev_printk.h:118:33: note: expanded from macro 'dev_info' > > > > > _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__) > > > > > > > > Already fixed in: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/commit/drivers/phy/ralink/phy-mt7621-pci.c?h=next&id=652a6a2e3824ce2ebf79a2d5326940d05c4db036 > > > > > > > > > ^~~~~~~~~~~ > > > > > >> drivers/phy/ralink/phy-mt7621-pci.c:341:34: warning: unused variable 'mt7621_pci_phy_ids' [-Wunused-const-variable] > > > > > static const struct of_device_id mt7621_pci_phy_ids[] = { > > > > > ^ > > > > > > > > Mmmm... This one is used through MODULE_DEVICE_TABLE macro... Am I > > > > missing something?? > > > > > > Pretty sure there's a config in MODULE_DEVICE_TABLE that's being > > > disabled by the randconfig; the definition of mt7621_pci_phy_ids > > > should also be behind preprocessor checks for that. > > > > So, the driver uses 'mt7621_pci_phy_ids' in two places : > > > > static const struct of_device_id mt7621_pci_phy_ids[] = { > > { .compatible = "mediatek,mt7621-pci-phy" }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, mt7621_pci_phy_ids); > > ^ > > This one is inside the 'MODULE' preprocessor directive. > > > > static struct platform_driver mt7621_pci_phy_driver = { > > .probe = mt7621_pci_phy_probe, > > .driver = { > > .name = "mt7621-pci-phy", > > .of_match_table = of_match_ptr(mt7621_pci_phy_ids), > > ^ > > This one is inside 'CONFIG_OF' > > }, > > }; > > > > randconfig is not setting 'CONFIG_OF' nor defining MODULE. I've been > > ^ yeah gating the definition on CONFIG_OF would resolve this. > > > looking into different drivers code and all of them follow the same > > pattern and nothing is behind preprocessor checks at all. So I wonder > > They are starting to when they get these warnings from 0day bot; > there's a lot of drivers though. I see. Thanks for clarification. I will search for a driver already fixing this and send a similar patch to silence this one also. > > > if this is really something that needs to be fixed. > > It's a W=1 build as well; fix it or don't. I'm a sign, not a cop. > Thank you very much for your help. Best regards, Sergio Paracuellos > > > > Thanks in advance for clarifications. > > > > Best regards, > > Sergio Paracuellos > > > > > > > > > > > > > > > > 2 warnings generated. > > > > > > > > > > > > > > > vim +/mt7621_pci_phy_ids +341 drivers/phy/ralink/phy-mt7621-pci.c > > > > > > > > > > d87da32372a03c Sergio Paracuellos 2020-11-21 340 > > > > > d87da32372a03c Sergio Paracuellos 2020-11-21 @341 static const struct of_device_id mt7621_pci_phy_ids[] = { > > > > > d87da32372a03c Sergio Paracuellos 2020-11-21 342 { .compatible = "mediatek,mt7621-pci-phy" }, > > > > > d87da32372a03c Sergio Paracuellos 2020-11-21 343 {}, > > > > > d87da32372a03c Sergio Paracuellos 2020-11-21 344 }; > > > > > 8145dcb07d0c8b Sergio Paracuellos 2020-12-01 345 MODULE_DEVICE_TABLE(of, mt7621_pci_phy_ids); > > > > > d87da32372a03c Sergio Paracuellos 2020-11-21 346 > > > > > > > > > > :::::: The code at line 341 was first introduced by commit > > > > > :::::: d87da32372a03ce121fc65ccd2c9a43edf56b364 phy: ralink: Add PHY driver for MT7621 PCIe PHY > > > > > > > > > > :::::: TO: Sergio Paracuellos > > > > > :::::: CC: Vinod Koul > > > > > > > > > > --- > > > > > 0-DAY CI Kernel Test Service, Intel Corporation > > > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > > > > > > > Best regards, > > > > Sergio Paracuellos > > > > > > > > -- > > > > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > > > > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/CAMhs-H8qyOKQmPtChYO%2BjfC%2BZmj8U9yGeZJORUx14MzyLeT5QA%40mail.gmail.com. > > > > > > > > > > > > -- > > > Thanks, > > > ~Nick Desaulniers > > > > -- > Thanks, > ~Nick Desaulniers