From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E7ABC11F67 for ; Tue, 29 Jun 2021 14:57:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D296461DC2 for ; Tue, 29 Jun 2021 14:57:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D296461DC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 078028D0151; Tue, 29 Jun 2021 10:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04EF98D00F0; Tue, 29 Jun 2021 10:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0BB08D0151; Tue, 29 Jun 2021 10:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id BD2EB8D00F0 for ; Tue, 29 Jun 2021 10:57:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9386C1817E5F8 for ; Tue, 29 Jun 2021 14:57:37 +0000 (UTC) X-FDA: 78307065354.01.E65667D Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf19.hostedemail.com (Postfix) with ESMTP id 4ABE8B000092 for ; Tue, 29 Jun 2021 14:57:37 +0000 (UTC) Received: by mail-vs1-f49.google.com with SMTP id x12so12280637vsp.4 for ; Tue, 29 Jun 2021 07:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pMq2jgUDcedYazBIanUdJgioOTeKEQg3ZpkwrR4x76k=; b=nUIOWMf16mziWL8VJ1EHnnBka/2oEEqZ2tJOI+Uu1U6PcbQsMCEF2HeJIEOHCKbR3O LnOh6aTqMfJrpBlu9oBn8jlrnoq0J6YvlpNdHJaGXn9SZINT0zEeTspqYBUSGgSHCB3c 9ZutQfOe1iL09UZgS4d+hkIu2YFoO3ShHzRJI4MJIe2GlaZX06xWIjeug1DMqjCSvQIu jKupGRrqsofV5tfsuJaf8Q7d3UYEtP9gbBCV45lFD5taV1Y90iSUG+gPYrvH0YuXGZva 7Fnns5mV9Zuhkk6E1sdllg71pZSIgUECzqZ7Aq15ZE6Q5KTabaaepVMnfMev1ecri3rI bqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pMq2jgUDcedYazBIanUdJgioOTeKEQg3ZpkwrR4x76k=; b=uc9kQMn1o2T1udhSb5B7sgYx7kvOkPWHCS2McgRDhNdSTAVfQNAQ+aHkDz71nWK18g hpHp6inG7CTEE0qT1LpPJYr19IOoUs3dMeIRiH8VsyHlZ3huo1/9CkIt2qgRyp6HBMmD 3u4roIhdkllIBpaZhkYsXVkSnrEMctMchILT1EuSX8e527ezCn1rTibFcDXZOtBwLy1m iCRRlEaYEWW4gCAOyOq5OKyiPfZCg1XLp1GJa2iB9RXJ86nAFeMOdtxUVXkyayNwoW2k yACd6v7AnrVP/OXuOVoLBYvQl8bi+m0o9L9gUMx9UX8Z/0wANoh40naXlgKPrCIKE3vu 5R6g== X-Gm-Message-State: AOAM531axpSCtpMCIK6huEd47mDKVVWgqnN20MTFdhc7V4syqjmbYdO1 ca4RA0MSZzdL2A2h+Fc+ifcYAW5u6EKxLM4mNyM= X-Google-Smtp-Source: ABdhPJyzkd8o/j+UtOqS+gkPBSshkC2qlBDaXm+Ct8Cj8PsRPZ55LZUlvBBUe+kaoofAnAxXB190YA78/69/8dRn14c= X-Received: by 2002:a67:e116:: with SMTP id d22mr2966990vsl.49.1624978656537; Tue, 29 Jun 2021 07:57:36 -0700 (PDT) MIME-Version: 1.0 References: <202106292154.jnaieNvX-lkp@intel.com> In-Reply-To: From: Sergio Paracuellos Date: Tue, 29 Jun 2021 16:57:25 +0200 Message-ID: Subject: Re: [linux-next:master 6546/14055] arch/mips/include/asm/mach-ralink/rt305x.h:18:23: error: 'RT305X_SOC_RT3050' undeclared To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Linus Walleij Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4ABE8B000092 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=nUIOWMf1; spf=pass (imf19.hostedemail.com: domain of sergioparacuellos@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=sergioparacuellos@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: qanquki6xszy4o89tewwyjkwxfnten9a X-HE-Tag: 1624978657-619311 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 29, 2021 at 4:16 PM Sergio Paracuellos wrote: > > Hi, > > On Tue, Jun 29, 2021 at 3:10 PM kernel test robot wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 73748627df83aab934c81332ca83a44ab8c7b3e3 > > commit: 3a1b0ca5a83b69f95ab9641ae0e77526a6fee384 [6546/14055] pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file > > config: mips-randconfig-c003-20210629 (attached as .config) > > compiler: mipsel-linux-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3a1b0ca5a83b69f95ab9641ae0e77526a6fee384 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 3a1b0ca5a83b69f95ab9641ae0e77526a6fee384 > > # save the attached .config to linux build tree > > mkdir build_dir > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > In file included from drivers/pinctrl/ralink/pinctrl-rt305x.c:3: > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3050': > > >> arch/mips/include/asm/mach-ralink/rt305x.h:18:23: error: 'RT305X_SOC_RT3050' undeclared (first use in this function) > > 18 | return ralink_soc == RT305X_SOC_RT3050; > > | ^~~~~~~~~~~~~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h:18:23: note: each undeclared identifier is reported only once for each function it appears in > > >> arch/mips/include/asm/mach-ralink/rt305x.h:18:2: error: 'ralink_soc' has an incomplete type 'enum ralink_soc_type' > > 18 | return ralink_soc == RT305X_SOC_RT3050; > > | ^~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3052': > > >> arch/mips/include/asm/mach-ralink/rt305x.h:23:23: error: 'RT305X_SOC_RT3052' undeclared (first use in this function) > > 23 | return ralink_soc == RT305X_SOC_RT3052; > > | ^~~~~~~~~~~~~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h:23:2: error: 'ralink_soc' has an incomplete type 'enum ralink_soc_type' > > 23 | return ralink_soc == RT305X_SOC_RT3052; > > | ^~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3350': > > >> arch/mips/include/asm/mach-ralink/rt305x.h:33:23: error: 'RT305X_SOC_RT3350' undeclared (first use in this function) > > 33 | return ralink_soc == RT305X_SOC_RT3350; > > | ^~~~~~~~~~~~~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h:33:2: error: 'ralink_soc' has an incomplete type 'enum ralink_soc_type' > > 33 | return ralink_soc == RT305X_SOC_RT3350; > > | ^~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3352': > > >> arch/mips/include/asm/mach-ralink/rt305x.h:38:23: error: 'RT305X_SOC_RT3352' undeclared (first use in this function) > > 38 | return ralink_soc == RT305X_SOC_RT3352; > > | ^~~~~~~~~~~~~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h:38:2: error: 'ralink_soc' has an incomplete type 'enum ralink_soc_type' > > 38 | return ralink_soc == RT305X_SOC_RT3352; > > | ^~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt5350': > > >> arch/mips/include/asm/mach-ralink/rt305x.h:43:23: error: 'RT305X_SOC_RT5350' undeclared (first use in this function) > > 43 | return ralink_soc == RT305X_SOC_RT5350; > > | ^~~~~~~~~~~~~~~~~ > > arch/mips/include/asm/mach-ralink/rt305x.h:43:2: error: 'ralink_soc' has an incomplete type 'enum ralink_soc_type' > > 43 | return ralink_soc == RT305X_SOC_RT5350; > > | ^~~~~~ > > In file included from drivers/pinctrl/ralink/pinctrl-rt305x.c:3: > > arch/mips/include/asm/mach-ralink/rt305x.h:44:1: error: control reaches end of non-void function [-Werror=return-type] > > 44 | } > > | ^ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3050': > > arch/mips/include/asm/mach-ralink/rt305x.h:19:1: error: control reaches end of non-void function [-Werror=return-type] > > 19 | } > > | ^ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3052': > > arch/mips/include/asm/mach-ralink/rt305x.h:24:1: error: control reaches end of non-void function [-Werror=return-type] > > 24 | } > > | ^ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3350': > > arch/mips/include/asm/mach-ralink/rt305x.h:34:1: error: control reaches end of non-void function [-Werror=return-type] > > 34 | } > > | ^ > > arch/mips/include/asm/mach-ralink/rt305x.h: In function 'soc_is_rt3352': > > arch/mips/include/asm/mach-ralink/rt305x.h:39:1: error: control reaches end of non-void function [-Werror=return-type] > > 39 | } > > | ^ > > cc1: some warnings being treated as errors > > There is a missing include after creating the file > 'drivers/pinctrl/ralink/pinctrl-rt305x.c': #include > > > Previous to this move, 'arch/mips/ralink/rt305x.c' was including > '' and before this include in > the same C file '' is being included. I > don't know why this is being including in C file and not > in the header itself. So to be coherent we should add the include > in the new > 'drivers/pinctrl/ralink/pinctrl-rt305x.c' > as follows: > > diff --git a/drivers/pinctrl/ralink/pinctrl-rt305x.c > b/drivers/pinctrl/ralink/pinctrl-rt305x.c > index 699fe18e7000..5d8fa156c003 100644 > --- a/drivers/pinctrl/ralink/pinctrl-rt305x.c > +++ b/drivers/pinctrl/ralink/pinctrl-rt305x.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > > +#include > #include > #include > #include > > This should fix the problem. Maybe there is a better solution... > Linus, what do you think? I have already sent this patch: https://lkml.org/lkml/2021/6/29/414 Linus, let me know if this is ok for you. Thanks, Sergio Paracuellos > > Best regards, > Sergio Paracuellos > > > > > > > vim +/RT305X_SOC_RT3050 +18 arch/mips/include/asm/mach-ralink/rt305x.h > > > > 2809b31770d7fd John Crispin 2013-01-20 15 > > 2809b31770d7fd John Crispin 2013-01-20 16 static inline int soc_is_rt3050(void) > > 2809b31770d7fd John Crispin 2013-01-20 17 { > > 418d29c8706170 John Crispin 2015-11-04 @18 return ralink_soc == RT305X_SOC_RT3050; > > 2809b31770d7fd John Crispin 2013-01-20 19 } > > 2809b31770d7fd John Crispin 2013-01-20 20 > > 2809b31770d7fd John Crispin 2013-01-20 21 static inline int soc_is_rt3052(void) > > 2809b31770d7fd John Crispin 2013-01-20 22 { > > 418d29c8706170 John Crispin 2015-11-04 @23 return ralink_soc == RT305X_SOC_RT3052; > > 2809b31770d7fd John Crispin 2013-01-20 24 } > > 2809b31770d7fd John Crispin 2013-01-20 25 > > 2809b31770d7fd John Crispin 2013-01-20 26 static inline int soc_is_rt305x(void) > > 2809b31770d7fd John Crispin 2013-01-20 27 { > > 2809b31770d7fd John Crispin 2013-01-20 28 return soc_is_rt3050() || soc_is_rt3052(); > > 2809b31770d7fd John Crispin 2013-01-20 29 } > > 2809b31770d7fd John Crispin 2013-01-20 30 > > 2809b31770d7fd John Crispin 2013-01-20 31 static inline int soc_is_rt3350(void) > > 2809b31770d7fd John Crispin 2013-01-20 32 { > > 418d29c8706170 John Crispin 2015-11-04 @33 return ralink_soc == RT305X_SOC_RT3350; > > 2809b31770d7fd John Crispin 2013-01-20 34 } > > 2809b31770d7fd John Crispin 2013-01-20 35 > > 2809b31770d7fd John Crispin 2013-01-20 36 static inline int soc_is_rt3352(void) > > 2809b31770d7fd John Crispin 2013-01-20 37 { > > 418d29c8706170 John Crispin 2015-11-04 @38 return ralink_soc == RT305X_SOC_RT3352; > > 2809b31770d7fd John Crispin 2013-01-20 39 } > > 2809b31770d7fd John Crispin 2013-01-20 40 > > 2809b31770d7fd John Crispin 2013-01-20 41 static inline int soc_is_rt5350(void) > > 2809b31770d7fd John Crispin 2013-01-20 42 { > > 418d29c8706170 John Crispin 2015-11-04 @43 return ralink_soc == RT305X_SOC_RT5350; > > 2809b31770d7fd John Crispin 2013-01-20 44 } > > 2809b31770d7fd John Crispin 2013-01-20 45 > > > > :::::: The code at line 18 was first introduced by commit > > :::::: 418d29c8706170c6801998e48341181b274a47a8 MIPS: ralink: Unify SoC id handling > > > > :::::: TO: John Crispin > > :::::: CC: Ralf Baechle > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org